Skip to content

Commit 96ed496

Browse files
committed
fix: gate react/jsx-runtime upgrade only for React >= 17 tests (#28256)
#28252 broke RDT tests with React 16.x. These changes gate the `jsx-runtime` upgrade only for cases when we are testing against React >= 17. Validated with: ``` ./scripts/circleci/download_devtools_regression_build.js 16.0 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 16.0 --ci && ./scripts/circleci/download_devtools_regression_build.js 16.5 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 16.5 --ci && ./scripts/circleci/download_devtools_regression_build.js 16.8 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 16.8 --ci && ./scripts/circleci/download_devtools_regression_build.js 17.0 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 17.0 --ci && ./scripts/circleci/download_devtools_regression_build.js 18.0 --replaceBuild && node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion 18.0 --ci ``` DiffTrain build for commit 65d95b8.
1 parent dedce27 commit 96ed496

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25600,7 +25600,7 @@ if (__DEV__) {
2560025600
return root;
2560125601
}
2560225602

25603-
var ReactVersion = "18.3.0-canary-103cddbb9-20240206";
25603+
var ReactVersion = "18.3.0-canary-65d95b837-20240206";
2560425604

2560525605
// Might add PROFILE later.
2560625606

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9150,7 +9150,7 @@ var devToolsConfig$jscomp$inline_1012 = {
91509150
throw Error("TestRenderer does not support findFiberByHostInstance()");
91519151
},
91529152
bundleType: 0,
9153-
version: "18.3.0-canary-103cddbb9-20240206",
9153+
version: "18.3.0-canary-65d95b837-20240206",
91549154
rendererPackageName: "react-test-renderer"
91559155
};
91569156
var internals$jscomp$inline_1190 = {
@@ -9181,7 +9181,7 @@ var internals$jscomp$inline_1190 = {
91819181
scheduleRoot: null,
91829182
setRefreshHandler: null,
91839183
getCurrentFiber: null,
9184-
reconcilerVersion: "18.3.0-canary-103cddbb9-20240206"
9184+
reconcilerVersion: "18.3.0-canary-65d95b837-20240206"
91859185
};
91869186
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91879187
var hook$jscomp$inline_1191 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9578,7 +9578,7 @@ var devToolsConfig$jscomp$inline_1054 = {
95789578
throw Error("TestRenderer does not support findFiberByHostInstance()");
95799579
},
95809580
bundleType: 0,
9581-
version: "18.3.0-canary-103cddbb9-20240206",
9581+
version: "18.3.0-canary-65d95b837-20240206",
95829582
rendererPackageName: "react-test-renderer"
95839583
};
95849584
var internals$jscomp$inline_1231 = {
@@ -9609,7 +9609,7 @@ var internals$jscomp$inline_1231 = {
96099609
scheduleRoot: null,
96109610
setRefreshHandler: null,
96119611
getCurrentFiber: null,
9612-
reconcilerVersion: "18.3.0-canary-103cddbb9-20240206"
9612+
reconcilerVersion: "18.3.0-canary-65d95b837-20240206"
96139613
};
96149614
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96159615
var hook$jscomp$inline_1232 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-103cddbb9-20240206";
27+
var ReactVersion = "18.3.0-canary-65d95b837-20240206";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,4 +543,4 @@ exports.useSyncExternalStore = function (
543543
exports.useTransition = function () {
544544
return ReactCurrentDispatcher.current.useTransition();
545545
};
546-
exports.version = "18.3.0-canary-103cddbb9-20240206";
546+
exports.version = "18.3.0-canary-65d95b837-20240206";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ exports.useSyncExternalStore = function (
539539
exports.useTransition = function () {
540540
return ReactCurrentDispatcher.current.useTransition();
541541
};
542-
exports.version = "18.3.0-canary-103cddbb9-20240206";
542+
exports.version = "18.3.0-canary-65d95b837-20240206";
543543
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
544544
"function" ===
545545
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
103cddbb9d433b08622c43336b170ffc63acdee3
1+
65d95b837e797a0690221dd1824955d3d3afd278

0 commit comments

Comments
 (0)