Skip to content

Commit 96dd1bf

Browse files
eps1loneps1lon
committed
fixture(attribute-behavior): Ensure we find the rendered element if we render into document
1 parent 3273bd1 commit 96dd1bf

File tree

2 files changed

+44
-44
lines changed

2 files changed

+44
-44
lines changed

‎fixtures/attribute-behavior/AttributeTableSnapshot.md

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -6201,27 +6201,27 @@
62016201
## `lang` (on `<html>` inside `<document>`)
62026202
| Test Case | Flags | Result |
62036203
| --- | --- | --- |
6204-
| `lang=(string)`| (initial, ssr mismatch)| `<undefined>` |
6205-
| `lang=(empty string)`| (initial, ssr mismatch)| `<undefined>` |
6206-
| `lang=(array with string)`| (initial, ssr mismatch)| `<undefined>` |
6207-
| `lang=(empty array)`| (initial, ssr mismatch)| `<undefined>` |
6208-
| `lang=(object)`| (initial, ssr mismatch)| `<undefined>` |
6209-
| `lang=(numeric string)`| (initial, ssr mismatch)| `<undefined>` |
6210-
| `lang=(-1)`| (initial, ssr mismatch)| `<undefined>` |
6211-
| `lang=(0)`| (initial, ssr mismatch)| `<undefined>` |
6212-
| `lang=(integer)`| (initial, ssr mismatch)| `<undefined>` |
6213-
| `lang=(NaN)`| (initial, warning, ssr mismatch)| `<undefined>` |
6214-
| `lang=(float)`| (initial, ssr mismatch)| `<undefined>` |
6215-
| `lang=(true)`| (initial, warning, ssr mismatch)| `<undefined>` |
6216-
| `lang=(false)`| (initial, warning, ssr mismatch)| `<undefined>` |
6217-
| `lang=(string 'true')`| (initial, ssr mismatch)| `<undefined>` |
6218-
| `lang=(string 'false')`| (initial, ssr mismatch)| `<undefined>` |
6219-
| `lang=(string 'on')`| (initial, ssr mismatch)| `<undefined>` |
6220-
| `lang=(string 'off')`| (initial, ssr mismatch)| `<undefined>` |
6221-
| `lang=(symbol)`| (initial, warning, ssr mismatch)| `<undefined>` |
6222-
| `lang=(function)`| (initial, warning, ssr mismatch)| `<undefined>` |
6223-
| `lang=(null)`| (initial, ssr mismatch)| `<undefined>` |
6224-
| `lang=(undefined)`| (initial, ssr mismatch)| `<undefined>` |
6204+
| `lang=(string)`| (changed, ssr mismatch)| `"a string"` |
6205+
| `lang=(empty string)`| (initial)| `<empty string>` |
6206+
| `lang=(array with string)`| (changed, ssr mismatch)| `"string"` |
6207+
| `lang=(empty array)`| (initial)| `<empty string>` |
6208+
| `lang=(object)`| (changed, ssr mismatch)| `"result of toString()"` |
6209+
| `lang=(numeric string)`| (changed, ssr mismatch)| `"42"` |
6210+
| `lang=(-1)`| (changed, ssr mismatch)| `"-1"` |
6211+
| `lang=(0)`| (changed, ssr mismatch)| `"0"` |
6212+
| `lang=(integer)`| (changed, ssr mismatch)| `"1"` |
6213+
| `lang=(NaN)`| (changed, warning, ssr mismatch)| `"NaN"` |
6214+
| `lang=(float)`| (changed, ssr mismatch)| `"99.99"` |
6215+
| `lang=(true)`| (initial, warning)| `<empty string>` |
6216+
| `lang=(false)`| (initial, warning)| `<empty string>` |
6217+
| `lang=(string 'true')`| (changed, ssr mismatch)| `"true"` |
6218+
| `lang=(string 'false')`| (changed, ssr mismatch)| `"false"` |
6219+
| `lang=(string 'on')`| (changed, ssr mismatch)| `"on"` |
6220+
| `lang=(string 'off')`| (changed, ssr mismatch)| `"off"` |
6221+
| `lang=(symbol)`| (initial, warning)| `<empty string>` |
6222+
| `lang=(function)`| (initial, warning)| `<empty string>` |
6223+
| `lang=(null)`| (initial)| `<empty string>` |
6224+
| `lang=(undefined)`| (initial)| `<empty string>` |
62256225

62266226
## `length` (on `<div>` inside `<div>`)
62276227
| Test Case | Flags | Result |
@@ -12276,27 +12276,27 @@
1227612276
## `version` (on `<html>` inside `<document>`)
1227712277
| Test Case | Flags | Result |
1227812278
| --- | --- | --- |
12279-
| `version=(string)`| (initial, ssr mismatch)| `<undefined>` |
12280-
| `version=(empty string)`| (initial, ssr mismatch)| `<undefined>` |
12281-
| `version=(array with string)`| (initial, ssr mismatch)| `<undefined>` |
12282-
| `version=(empty array)`| (initial, ssr mismatch)| `<undefined>` |
12283-
| `version=(object)`| (initial, ssr mismatch)| `<undefined>` |
12284-
| `version=(numeric string)`| (initial, ssr mismatch)| `<undefined>` |
12285-
| `version=(-1)`| (initial, ssr mismatch)| `<undefined>` |
12286-
| `version=(0)`| (initial, ssr mismatch)| `<undefined>` |
12287-
| `version=(integer)`| (initial, ssr mismatch)| `<undefined>` |
12288-
| `version=(NaN)`| (initial, warning, ssr mismatch)| `<undefined>` |
12289-
| `version=(float)`| (initial, ssr mismatch)| `<undefined>` |
12290-
| `version=(true)`| (initial, warning, ssr mismatch)| `<undefined>` |
12291-
| `version=(false)`| (initial, warning, ssr mismatch)| `<undefined>` |
12292-
| `version=(string 'true')`| (initial, ssr mismatch)| `<undefined>` |
12293-
| `version=(string 'false')`| (initial, ssr mismatch)| `<undefined>` |
12294-
| `version=(string 'on')`| (initial, ssr mismatch)| `<undefined>` |
12295-
| `version=(string 'off')`| (initial, ssr mismatch)| `<undefined>` |
12296-
| `version=(symbol)`| (initial, warning, ssr mismatch)| `<undefined>` |
12297-
| `version=(function)`| (initial, warning, ssr mismatch)| `<undefined>` |
12298-
| `version=(null)`| (initial, ssr mismatch)| `<undefined>` |
12299-
| `version=(undefined)`| (initial, ssr mismatch)| `<undefined>` |
12279+
| `version=(string)`| (changed, ssr mismatch)| `"a string"` |
12280+
| `version=(empty string)`| (initial)| `<empty string>` |
12281+
| `version=(array with string)`| (changed, ssr mismatch)| `"string"` |
12282+
| `version=(empty array)`| (initial)| `<empty string>` |
12283+
| `version=(object)`| (changed, ssr mismatch)| `"result of toString()"` |
12284+
| `version=(numeric string)`| (changed, ssr mismatch)| `"42"` |
12285+
| `version=(-1)`| (changed, ssr mismatch)| `"-1"` |
12286+
| `version=(0)`| (changed, ssr mismatch)| `"0"` |
12287+
| `version=(integer)`| (changed, ssr mismatch)| `"1"` |
12288+
| `version=(NaN)`| (changed, warning, ssr mismatch)| `"NaN"` |
12289+
| `version=(float)`| (changed, ssr mismatch)| `"99.99"` |
12290+
| `version=(true)`| (initial, warning)| `<empty string>` |
12291+
| `version=(false)`| (initial, warning)| `<empty string>` |
12292+
| `version=(string 'true')`| (changed, ssr mismatch)| `"true"` |
12293+
| `version=(string 'false')`| (changed, ssr mismatch)| `"false"` |
12294+
| `version=(string 'on')`| (changed, ssr mismatch)| `"on"` |
12295+
| `version=(string 'off')`| (changed, ssr mismatch)| `"off"` |
12296+
| `version=(symbol)`| (initial, warning)| `<empty string>` |
12297+
| `version=(function)`| (initial, warning)| `<empty string>` |
12298+
| `version=(null)`| (initial)| `<empty string>` |
12299+
| `version=(undefined)`| (initial)| `<empty string>` |
1230012300

1230112301
## `version` (on `<svg>` inside `<div>`)
1230212302
| Test Case | Flags | Result |

‎fixtures/attribute-behavior/src/App.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,12 +284,12 @@ function getRenderedAttributeValue(
284284
try {
285285
let container = createContainer();
286286
renderer.render(react.createElement(tagName, baseProps), container);
287-
defaultValue = read(container.firstChild);
287+
defaultValue = read(container.lastChild);
288288
canonicalDefaultValue = getCanonicalizedValue(defaultValue);
289289

290290
container = createContainer();
291291
renderer.render(react.createElement(tagName, props), container);
292-
result = read(container.firstChild);
292+
result = read(container.lastChild);
293293
canonicalResult = getCanonicalizedValue(result);
294294
didWarn = _didWarn;
295295
didError = false;

0 commit comments

Comments
 (0)