Skip to content

Commit 95923cc

Browse files
committed
Enable "next major" feature flags
The canary channel now represents v19, so we can turn these flags on.
1 parent bfe9275 commit 95923cc

File tree

2 files changed

+37
-26
lines changed

2 files changed

+37
-26
lines changed

packages/shared/ReactFeatureFlags.js

Lines changed: 28 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -127,47 +127,48 @@ export const syncLaneExpirationMs = 250;
127127
export const transitionLaneExpirationMs = 5000;
128128

129129
// -----------------------------------------------------------------------------
130-
// Ready for next major.
130+
// Already landed in main
131131
//
132-
// Alias __NEXT_MAJOR__ to __EXPERIMENTAL__ for easier skimming.
132+
// TODO: Audit these flags and decide which ones can be removed from the
133+
// codebase and which ones need to remain for Meta or RN. Any remaining ones
134+
// should be moved them into the appropriate section in this file.
133135
// -----------------------------------------------------------------------------
134-
const __NEXT_MAJOR__ = __EXPERIMENTAL__;
135136

136137
// Removes legacy style context
137-
export const disableLegacyContext = __NEXT_MAJOR__;
138+
export const disableLegacyContext = true;
138139

139140
// Not ready to break experimental yet.
140141
// Disable javascript: URL strings in href for XSS protection.
141-
export const disableJavaScriptURLs = __NEXT_MAJOR__;
142+
export const disableJavaScriptURLs = true;
142143

143144
// Not ready to break experimental yet.
144145
// Modern <StrictMode /> behaviour aligns more with what components
145146
// components will encounter in production, especially when used With <Offscreen />.
146147
// TODO: clean up legacy <StrictMode /> once tests pass WWW.
147-
export const useModernStrictMode = __NEXT_MAJOR__;
148+
export const useModernStrictMode = true;
148149

149150
// Not ready to break experimental yet.
150151
// Remove IE and MsApp specific workarounds for innerHTML
151-
export const disableIEWorkarounds = __NEXT_MAJOR__;
152+
export const disableIEWorkarounds = true;
152153

153154
// Changes the behavior for rendering custom elements in both server rendering
154155
// and client rendering, mostly to allow JSX attributes to apply to the custom
155156
// element's object properties instead of only HTML attributes.
156157
// https://github.com/facebook/react/issues/11347
157-
export const enableCustomElementPropertySupport = __NEXT_MAJOR__;
158+
export const enableCustomElementPropertySupport = true;
158159

159160
// Filter certain DOM attributes (e.g. src, href) if their values are empty
160161
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
161162
// request for certain browsers.
162-
export const enableFilterEmptyStringAttributesDOM = __NEXT_MAJOR__;
163+
export const enableFilterEmptyStringAttributesDOM = true;
163164

164165
// Disabled caching behavior of `react/cache` in client runtimes.
165166
export const disableClientCache = false;
166167

167168
// Changes Server Components Reconciliation when they have keys
168-
export const enableServerComponentKeys = __NEXT_MAJOR__;
169+
export const enableServerComponentKeys = true;
169170

170-
export const enableBigIntSupport = __NEXT_MAJOR__;
171+
export const enableBigIntSupport = true;
171172

172173
/**
173174
* Enables a new error detection for infinite render loops from updates caused
@@ -180,8 +181,8 @@ export const enableInfiniteRenderLoopDetection = true;
180181

181182
// Passes `ref` as a normal prop instead of stripping it from the props object
182183
// during element creation.
183-
export const enableRefAsProp = __NEXT_MAJOR__;
184-
export const disableStringRefs = __NEXT_MAJOR__;
184+
export const enableRefAsProp = true;
185+
export const disableStringRefs = true;
185186

186187
// Not ready to break experimental yet.
187188
// Needs more internal cleanup
@@ -191,17 +192,27 @@ export const enableReactTestRendererWarning = false;
191192
// Disables legacy mode
192193
// This allows us to land breaking changes to remove legacy mode APIs in experimental builds
193194
// before removing them in stable in the next Major
194-
export const disableLegacyMode = __NEXT_MAJOR__;
195+
export const disableLegacyMode = true;
195196

196197
// HTML boolean attributes need a special PropertyInfoRecord.
197198
// Between support of these attributes in browsers and React supporting them as
198199
// boolean props library users can use them as `<div someBooleanAttribute="" />`.
199200
// However, once React considers them as boolean props an empty string will
200201
// result in false property i.e. break existing usage.
201-
export const enableNewBooleanProps = __NEXT_MAJOR__;
202+
export const enableNewBooleanProps = true;
202203

203204
// Make <Context> equivalent to <Context.Provider> instead of <Context.Consumer>
204-
export const enableRenderableContext = __NEXT_MAJOR__;
205+
export const enableRenderableContext = true;
206+
207+
// -----------------------------------------------------------------------------
208+
// Ready for next major.
209+
//
210+
// Alias __NEXT_MAJOR__ to __EXPERIMENTAL__ for easier skimming.
211+
212+
// This section is currently empty.
213+
// -----------------------------------------------------------------------------
214+
//
215+
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
205216

206217
// -----------------------------------------------------------------------------
207218
// Chopping Block
@@ -210,7 +221,7 @@ export const enableRenderableContext = __NEXT_MAJOR__;
210221
// when we plan to enable them.
211222
// -----------------------------------------------------------------------------
212223

213-
export const disableModulePatternComponents = __NEXT_MAJOR__;
224+
export const disableModulePatternComponents = true;
214225

215226
export const enableUseRefAccessWarning = false;
216227

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,16 @@ export const enableInfiniteRenderLoopDetection = false;
8787
//
8888
// We really need to get rid of this whole module. Any test renderer specific
8989
// flags should be handled by the Fiber config.
90-
const __NEXT_MAJOR__ = __EXPERIMENTAL__;
91-
export const enableRefAsProp = __NEXT_MAJOR__;
92-
export const disableStringRefs = __NEXT_MAJOR__;
90+
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
91+
export const enableRefAsProp = true;
92+
export const disableStringRefs = true;
9393
export const enableReactTestRendererWarning = false;
94-
export const enableBigIntSupport = __NEXT_MAJOR__;
95-
export const disableLegacyMode = __NEXT_MAJOR__;
96-
export const disableLegacyContext = __NEXT_MAJOR__;
97-
export const enableNewBooleanProps = __NEXT_MAJOR__;
98-
export const disableModulePatternComponents = __NEXT_MAJOR__;
99-
export const enableRenderableContext = __NEXT_MAJOR__;
94+
export const enableBigIntSupport = true;
95+
export const disableLegacyMode = true;
96+
export const disableLegacyContext = true;
97+
export const enableNewBooleanProps = true;
98+
export const disableModulePatternComponents = true;
99+
export const enableRenderableContext = true;
100100

101101
// Flow magic to verify the exports of this file match the original version.
102102
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

0 commit comments

Comments
 (0)