Skip to content

Commit 91db3a0

Browse files
kassenskassens
committed
Revert "Cleanup enableSyncDefaultUpdate flag (#26236)" (#26528)
This reverts commit c6baac3. DiffTrain build for [a7b421f](a7b421f)
1 parent 34cf2ef commit 91db3a0

17 files changed

+106
-60
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7eca7179173c91d3a3501140df0afd45886d1769
1+
a7b421fb4e0d0aa29aa2c3436c7c8756f2bae2d2

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-3b6fb960";
30+
var ReactVersion = "18.3.0-www-modern-1ad32b8c";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-8960db8a";
72+
var ReactVersion = "18.3.0-www-classic-00b5e5d4";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -173,6 +173,7 @@ var revertRemovalOfSiblingPrerendering =
173173
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
174174
enableLazyContextPropagation =
175175
dynamicFeatureFlags.enableLazyContextPropagation,
176+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
176177
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
177178
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
178179
enableDeferRootSchedulingToMicrotask =
@@ -27688,7 +27689,9 @@ function createHostRootFiber(
2768827689
}
2768927690

2769027691
if (
27691-
// Only for internal experiments.
27692+
// We only use this flag for our repo tests to check both behaviors.
27693+
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
27694+
!enableSyncDefaultUpdates || // Only for internal experiments.
2769227695
concurrentUpdatesByDefaultOverride
2769327696
) {
2769427697
mode |= ConcurrentUpdatesByDefaultMode;

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-9c618c06";
72+
var ReactVersion = "18.3.0-www-modern-41062e02";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -173,6 +173,7 @@ var revertRemovalOfSiblingPrerendering =
173173
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
174174
enableLazyContextPropagation =
175175
dynamicFeatureFlags.enableLazyContextPropagation,
176+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
176177
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
177178
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
178179
enableDeferRootSchedulingToMicrotask =
@@ -27348,7 +27349,9 @@ function createHostRootFiber(
2734827349
}
2734927350

2735027351
if (
27351-
// Only for internal experiments.
27352+
// We only use this flag for our repo tests to check both behaviors.
27353+
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
27354+
!enableSyncDefaultUpdates || // Only for internal experiments.
2735227355
concurrentUpdatesByDefaultOverride
2735327356
) {
2735427357
mode |= ConcurrentUpdatesByDefaultMode;

‎compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9723,7 +9723,7 @@ var slice = Array.prototype.slice,
97239723
return null;
97249724
},
97259725
bundleType: 0,
9726-
version: "18.3.0-www-modern-79c13b02",
9726+
version: "18.3.0-www-modern-d3bd6c4b",
97279727
rendererPackageName: "react-art"
97289728
};
97299729
var internals$jscomp$inline_1322 = {
@@ -9754,7 +9754,7 @@ var internals$jscomp$inline_1322 = {
97549754
scheduleRoot: null,
97559755
setRefreshHandler: null,
97569756
getCurrentFiber: null,
9757-
reconcilerVersion: "18.3.0-www-modern-79c13b02"
9757+
reconcilerVersion: "18.3.0-www-modern-d3bd6c4b"
97589758
};
97599759
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97609760
var hook$jscomp$inline_1323 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ var disableInputAttributeSyncing =
138138
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
139139
enableLazyContextPropagation =
140140
dynamicFeatureFlags.enableLazyContextPropagation,
141+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
141142
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
142143
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
143144
enableCustomElementPropertySupport =
@@ -33328,7 +33329,9 @@ function createHostRootFiber(
3332833329
}
3332933330

3333033331
if (
33331-
// Only for internal experiments.
33332+
// We only use this flag for our repo tests to check both behaviors.
33333+
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
33334+
!enableSyncDefaultUpdates || // Only for internal experiments.
3333233335
concurrentUpdatesByDefaultOverride
3333333336
) {
3333433337
mode |= ConcurrentUpdatesByDefaultMode;
@@ -33883,7 +33886,7 @@ function createFiberRoot(
3388333886
return root;
3388433887
}
3388533888

33886-
var ReactVersion = "18.3.0-www-classic-838e60a2";
33889+
var ReactVersion = "18.3.0-www-classic-03029d27";
3388733890

3388833891
function createPortal$1(
3388933892
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@ var disableInputAttributeSyncing =
255255
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
256256
enableLazyContextPropagation =
257257
dynamicFeatureFlags.enableLazyContextPropagation,
258+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
258259
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
259260
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
260261
enableCustomElementPropertySupport =
@@ -33167,7 +33168,9 @@ function createHostRootFiber(
3316733168
}
3316833169

3316933170
if (
33170-
// Only for internal experiments.
33171+
// We only use this flag for our repo tests to check both behaviors.
33172+
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
33173+
!enableSyncDefaultUpdates || // Only for internal experiments.
3317133174
concurrentUpdatesByDefaultOverride
3317233175
) {
3317333176
mode |= ConcurrentUpdatesByDefaultMode;
@@ -33722,7 +33725,7 @@ function createFiberRoot(
3372233725
return root;
3372333726
}
3372433727

33725-
var ReactVersion = "18.3.0-www-modern-79c13b02";
33728+
var ReactVersion = "18.3.0-www-modern-d3bd6c4b";
3372633729

3372733730
function createPortal$1(
3372833731
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var ReactSharedInternals =
4848
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
4949
enableLazyContextPropagation =
5050
dynamicFeatureFlags.enableLazyContextPropagation,
51+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
5152
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
5253
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
5354
enableCustomElementPropertySupport =
@@ -11826,11 +11827,14 @@ function createFiberRoot(
1182611827
containerInfo.hydrationCallbacks = hydrationCallbacks;
1182711828
enableTransitionTracing &&
1182811829
(containerInfo.transitionCallbacks = transitionCallbacks);
11829-
1 === tag
11830-
? ((tag = 1),
11830+
if (1 === tag) {
11831+
if (
11832+
((tag = 1),
1183111833
!0 === isStrictMode && (tag |= 24),
11832-
concurrentUpdatesByDefaultOverride && (tag |= 32))
11833-
: (tag = 0);
11834+
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
11835+
)
11836+
tag |= 32;
11837+
} else tag = 0;
1183411838
isStrictMode = createFiber(3, null, null, tag);
1183511839
containerInfo.current = isStrictMode;
1183611840
isStrictMode.stateNode = containerInfo;
@@ -15957,7 +15961,7 @@ Internals.Events = [
1595715961
var devToolsConfig$jscomp$inline_1810 = {
1595815962
findFiberByHostInstance: getClosestInstanceFromNode,
1595915963
bundleType: 0,
15960-
version: "18.3.0-www-classic-edf1acce",
15964+
version: "18.3.0-www-classic-a4789d5a",
1596115965
rendererPackageName: "react-dom"
1596215966
};
1596315967
var internals$jscomp$inline_2206 = {
@@ -15987,7 +15991,7 @@ var internals$jscomp$inline_2206 = {
1598715991
scheduleRoot: null,
1598815992
setRefreshHandler: null,
1598915993
getCurrentFiber: null,
15990-
reconcilerVersion: "18.3.0-www-classic-edf1acce"
15994+
reconcilerVersion: "18.3.0-www-classic-a4789d5a"
1599115995
};
1599215996
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1599315997
var hook$jscomp$inline_2207 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16227,4 +16231,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1622716231
);
1622816232
};
1622916233
exports.unstable_runWithPriority = runWithPriority;
16230-
exports.version = "18.3.0-www-classic-edf1acce";
16234+
exports.version = "18.3.0-www-classic-a4789d5a";

‎compiled/facebook-www/ReactDOM-prod.modern.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
105105
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
106106
enableLazyContextPropagation =
107107
dynamicFeatureFlags.enableLazyContextPropagation,
108+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
108109
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
109110
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
110111
enableCustomElementPropertySupport =
@@ -11626,11 +11627,14 @@ function createFiberRoot(
1162611627
containerInfo.hydrationCallbacks = hydrationCallbacks;
1162711628
enableTransitionTracing &&
1162811629
(containerInfo.transitionCallbacks = transitionCallbacks);
11629-
1 === tag
11630-
? ((tag = 1),
11630+
if (1 === tag) {
11631+
if (
11632+
((tag = 1),
1163111633
!0 === isStrictMode && (tag |= 24),
11632-
concurrentUpdatesByDefaultOverride && (tag |= 32))
11633-
: (tag = 0);
11634+
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
11635+
)
11636+
tag |= 32;
11637+
} else tag = 0;
1163411638
isStrictMode = createFiber(3, null, null, tag);
1163511639
containerInfo.current = isStrictMode;
1163611640
isStrictMode.stateNode = containerInfo;
@@ -15484,7 +15488,7 @@ Internals.Events = [
1548415488
var devToolsConfig$jscomp$inline_1768 = {
1548515489
findFiberByHostInstance: getClosestInstanceFromNode,
1548615490
bundleType: 0,
15487-
version: "18.3.0-www-modern-0c23841c",
15491+
version: "18.3.0-www-modern-3446cb1a",
1548815492
rendererPackageName: "react-dom"
1548915493
};
1549015494
var internals$jscomp$inline_2169 = {
@@ -15515,7 +15519,7 @@ var internals$jscomp$inline_2169 = {
1551515519
scheduleRoot: null,
1551615520
setRefreshHandler: null,
1551715521
getCurrentFiber: null,
15518-
reconcilerVersion: "18.3.0-www-modern-0c23841c"
15522+
reconcilerVersion: "18.3.0-www-modern-3446cb1a"
1551915523
};
1552015524
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1552115525
var hook$jscomp$inline_2170 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15684,4 +15688,4 @@ exports.unstable_createEventHandle = function (type, options) {
1568415688
return eventHandle;
1568515689
};
1568615690
exports.unstable_runWithPriority = runWithPriority;
15687-
exports.version = "18.3.0-www-modern-0c23841c";
15691+
exports.version = "18.3.0-www-modern-3446cb1a";

‎compiled/facebook-www/ReactDOM-profiling.classic.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ var ReactSharedInternals =
5959
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
6060
enableLazyContextPropagation =
6161
dynamicFeatureFlags.enableLazyContextPropagation,
62+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
6263
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
6364
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
6465
enableCustomElementPropertySupport =
@@ -12594,11 +12595,14 @@ function createFiberRoot(
1259412595
containerInfo.hydrationCallbacks = hydrationCallbacks;
1259512596
enableTransitionTracing &&
1259612597
(containerInfo.transitionCallbacks = transitionCallbacks);
12597-
1 === tag
12598-
? ((tag = 1),
12598+
if (1 === tag) {
12599+
if (
12600+
((tag = 1),
1259912601
!0 === isStrictMode && (tag |= 24),
12600-
concurrentUpdatesByDefaultOverride && (tag |= 32))
12601-
: (tag = 0);
12602+
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
12603+
)
12604+
tag |= 32;
12605+
} else tag = 0;
1260212606
isDevToolsPresent && (tag |= 2);
1260312607
isStrictMode = createFiber(3, null, null, tag);
1260412608
containerInfo.current = isStrictMode;
@@ -16731,7 +16735,7 @@ Internals.Events = [
1673116735
var devToolsConfig$jscomp$inline_1889 = {
1673216736
findFiberByHostInstance: getClosestInstanceFromNode,
1673316737
bundleType: 0,
16734-
version: "18.3.0-www-classic-cf74bdbb",
16738+
version: "18.3.0-www-classic-ecdb4e3a",
1673516739
rendererPackageName: "react-dom"
1673616740
};
1673716741
(function (internals) {
@@ -16775,7 +16779,7 @@ var devToolsConfig$jscomp$inline_1889 = {
1677516779
scheduleRoot: null,
1677616780
setRefreshHandler: null,
1677716781
getCurrentFiber: null,
16778-
reconcilerVersion: "18.3.0-www-classic-cf74bdbb"
16782+
reconcilerVersion: "18.3.0-www-classic-ecdb4e3a"
1677916783
});
1678016784
assign(Internals, {
1678116785
ReactBrowserEventEmitter: {
@@ -17002,7 +17006,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
1700217006
);
1700317007
};
1700417008
exports.unstable_runWithPriority = runWithPriority;
17005-
exports.version = "18.3.0-www-classic-cf74bdbb";
17009+
exports.version = "18.3.0-www-classic-ecdb4e3a";
1700617010

1700717011
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1700817012
if (

‎compiled/facebook-www/ReactDOM-profiling.modern.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
116116
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
117117
enableLazyContextPropagation =
118118
dynamicFeatureFlags.enableLazyContextPropagation,
119+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
119120
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
120121
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
121122
enableCustomElementPropertySupport =
@@ -12388,11 +12389,14 @@ function createFiberRoot(
1238812389
containerInfo.hydrationCallbacks = hydrationCallbacks;
1238912390
enableTransitionTracing &&
1239012391
(containerInfo.transitionCallbacks = transitionCallbacks);
12391-
1 === tag
12392-
? ((tag = 1),
12392+
if (1 === tag) {
12393+
if (
12394+
((tag = 1),
1239312395
!0 === isStrictMode && (tag |= 24),
12394-
concurrentUpdatesByDefaultOverride && (tag |= 32))
12395-
: (tag = 0);
12396+
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
12397+
)
12398+
tag |= 32;
12399+
} else tag = 0;
1239612400
isDevToolsPresent && (tag |= 2);
1239712401
isStrictMode = createFiber(3, null, null, tag);
1239812402
containerInfo.current = isStrictMode;
@@ -16252,7 +16256,7 @@ Internals.Events = [
1625216256
var devToolsConfig$jscomp$inline_1847 = {
1625316257
findFiberByHostInstance: getClosestInstanceFromNode,
1625416258
bundleType: 0,
16255-
version: "18.3.0-www-modern-b6e8e2d5",
16259+
version: "18.3.0-www-modern-e4ad6703",
1625616260
rendererPackageName: "react-dom"
1625716261
};
1625816262
(function (internals) {
@@ -16297,7 +16301,7 @@ var devToolsConfig$jscomp$inline_1847 = {
1629716301
scheduleRoot: null,
1629816302
setRefreshHandler: null,
1629916303
getCurrentFiber: null,
16300-
reconcilerVersion: "18.3.0-www-modern-b6e8e2d5"
16304+
reconcilerVersion: "18.3.0-www-modern-e4ad6703"
1630116305
});
1630216306
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
1630316307
exports.createPortal = function (children, container) {
@@ -16453,7 +16457,7 @@ exports.unstable_createEventHandle = function (type, options) {
1645316457
return eventHandle;
1645416458
};
1645516459
exports.unstable_runWithPriority = runWithPriority;
16456-
exports.version = "18.3.0-www-modern-b6e8e2d5";
16460+
exports.version = "18.3.0-www-modern-e4ad6703";
1645716461

1645816462
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1645916463
if (

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ var disableInputAttributeSyncing =
127127
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
128128
enableLazyContextPropagation =
129129
dynamicFeatureFlags.enableLazyContextPropagation,
130+
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
130131
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
131132
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
132133
enableCustomElementPropertySupport =
@@ -35382,7 +35383,9 @@ function createHostRootFiber(
3538235383
}
3538335384

3538435385
if (
35385-
// Only for internal experiments.
35386+
// We only use this flag for our repo tests to check both behaviors.
35387+
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
35388+
!enableSyncDefaultUpdates || // Only for internal experiments.
3538635389
concurrentUpdatesByDefaultOverride
3538735390
) {
3538835391
mode |= ConcurrentUpdatesByDefaultMode;
@@ -35937,7 +35940,7 @@ function createFiberRoot(
3593735940
return root;
3593835941
}
3593935942

35940-
var ReactVersion = "18.3.0-www-classic-ec050b8e";
35943+
var ReactVersion = "18.3.0-www-classic-83bb419e";
3594135944

3594235945
function createPortal$1(
3594335946
children,

0 commit comments

Comments
 (0)