Skip to content

Commit 8f2986f

Browse files
mondaychenmondaychen
committed
[DevTools][BE] move shared types & constants to consolidated locations (#26572)
## Summary This pull request aims to improve the maintainability of the codebase by consolidating types and constants that are shared between the backend and frontend. This consolidation will allow us to maintain backwards compatibility in the frontend in the future. To achieve this, we have moved the shared types and constants to the following blessed files: - react-devtools-shared/src/constants - react-devtools-shared/src/types - react-devtools-shared/src/backend/types - react-devtools-shared/src/backend/NativeStyleEditor/types Please note that the inclusion of NativeStyleEditor in this list is temporary, and we plan to remove it once we have a better plugin system in place. ## How did you test this change? I have tested it by running `yarn flow dom-node`, which reports no errors. DiffTrain build for commit 451736b.
1 parent b38019b commit 8f2986f

File tree

13 files changed

+19
-19
lines changed

13 files changed

+19
-19
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23891,7 +23891,7 @@ function createFiberRoot(
2389123891
return root;
2389223892
}
2389323893

23894-
var ReactVersion = "18.3.0-next-fec97ecbc-20230410";
23894+
var ReactVersion = "18.3.0-next-451736b55-20230410";
2389523895

2389623896
// Might add PROFILE later.
2389723897

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8688,7 +8688,7 @@ var devToolsConfig$jscomp$inline_1028 = {
86888688
throw Error("TestRenderer does not support findFiberByHostInstance()");
86898689
},
86908690
bundleType: 0,
8691-
version: "18.3.0-next-fec97ecbc-20230410",
8691+
version: "18.3.0-next-451736b55-20230410",
86928692
rendererPackageName: "react-test-renderer"
86938693
};
86948694
var internals$jscomp$inline_1220 = {
@@ -8719,7 +8719,7 @@ var internals$jscomp$inline_1220 = {
87198719
scheduleRoot: null,
87208720
setRefreshHandler: null,
87218721
getCurrentFiber: null,
8722-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
8722+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
87238723
};
87248724
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
87258725
var hook$jscomp$inline_1221 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9114,7 +9114,7 @@ var devToolsConfig$jscomp$inline_1070 = {
91149114
throw Error("TestRenderer does not support findFiberByHostInstance()");
91159115
},
91169116
bundleType: 0,
9117-
version: "18.3.0-next-fec97ecbc-20230410",
9117+
version: "18.3.0-next-451736b55-20230410",
91189118
rendererPackageName: "react-test-renderer"
91199119
};
91209120
var internals$jscomp$inline_1261 = {
@@ -9145,7 +9145,7 @@ var internals$jscomp$inline_1261 = {
91459145
scheduleRoot: null,
91469146
setRefreshHandler: null,
91479147
getCurrentFiber: null,
9148-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
9148+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
91499149
};
91509150
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91519151
var hook$jscomp$inline_1262 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-fec97ecbc-20230410";
30+
var ReactVersion = "18.3.0-next-451736b55-20230410";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-fec97ecbc-20230410";
642+
exports.version = "18.3.0-next-451736b55-20230410";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-fec97ecbc-20230410";
645+
exports.version = "18.3.0-next-451736b55-20230410";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
fec97ecbc4bc2e0e1407160289a8f5fac5241cbc
1+
451736b557ebf53dd6d6b92c55cad14f7eba864c

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27187,7 +27187,7 @@ function createFiberRoot(
2718727187
return root;
2718827188
}
2718927189

27190-
var ReactVersion = "18.3.0-next-fec97ecbc-20230410";
27190+
var ReactVersion = "18.3.0-next-451736b55-20230410";
2719127191

2719227192
function createPortal$1(
2719327193
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9555,7 +9555,7 @@ var roots = new Map(),
95559555
devToolsConfig$jscomp$inline_1052 = {
95569556
findFiberByHostInstance: getInstanceFromNode,
95579557
bundleType: 0,
9558-
version: "18.3.0-next-fec97ecbc-20230410",
9558+
version: "18.3.0-next-451736b55-20230410",
95599559
rendererPackageName: "react-native-renderer",
95609560
rendererConfig: {
95619561
getInspectorDataForViewTag: function () {
@@ -9597,7 +9597,7 @@ var internals$jscomp$inline_1297 = {
95979597
scheduleRoot: null,
95989598
setRefreshHandler: null,
95999599
getCurrentFiber: null,
9600-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
9600+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
96019601
};
96029602
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96039603
var hook$jscomp$inline_1298 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10264,7 +10264,7 @@ var roots = new Map(),
1026410264
devToolsConfig$jscomp$inline_1130 = {
1026510265
findFiberByHostInstance: getInstanceFromNode,
1026610266
bundleType: 0,
10267-
version: "18.3.0-next-fec97ecbc-20230410",
10267+
version: "18.3.0-next-451736b55-20230410",
1026810268
rendererPackageName: "react-native-renderer",
1026910269
rendererConfig: {
1027010270
getInspectorDataForViewTag: function () {
@@ -10319,7 +10319,7 @@ var roots = new Map(),
1031910319
scheduleRoot: null,
1032010320
setRefreshHandler: null,
1032110321
getCurrentFiber: null,
10322-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
10322+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
1032310323
});
1032410324
exports.createPortal = function (children, containerTag) {
1032510325
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27708,7 +27708,7 @@ function createFiberRoot(
2770827708
return root;
2770927709
}
2771027710

27711-
var ReactVersion = "18.3.0-next-fec97ecbc-20230410";
27711+
var ReactVersion = "18.3.0-next-451736b55-20230410";
2771227712

2771327713
function createPortal$1(
2771427714
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9815,7 +9815,7 @@ var roots = new Map(),
98159815
devToolsConfig$jscomp$inline_1107 = {
98169816
findFiberByHostInstance: getInstanceFromTag,
98179817
bundleType: 0,
9818-
version: "18.3.0-next-fec97ecbc-20230410",
9818+
version: "18.3.0-next-451736b55-20230410",
98199819
rendererPackageName: "react-native-renderer",
98209820
rendererConfig: {
98219821
getInspectorDataForViewTag: function () {
@@ -9857,7 +9857,7 @@ var internals$jscomp$inline_1359 = {
98579857
scheduleRoot: null,
98589858
setRefreshHandler: null,
98599859
getCurrentFiber: null,
9860-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
9860+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
98619861
};
98629862
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
98639863
var hook$jscomp$inline_1360 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10524,7 +10524,7 @@ var roots = new Map(),
1052410524
devToolsConfig$jscomp$inline_1185 = {
1052510525
findFiberByHostInstance: getInstanceFromTag,
1052610526
bundleType: 0,
10527-
version: "18.3.0-next-fec97ecbc-20230410",
10527+
version: "18.3.0-next-451736b55-20230410",
1052810528
rendererPackageName: "react-native-renderer",
1052910529
rendererConfig: {
1053010530
getInspectorDataForViewTag: function () {
@@ -10579,7 +10579,7 @@ var roots = new Map(),
1057910579
scheduleRoot: null,
1058010580
setRefreshHandler: null,
1058110581
getCurrentFiber: null,
10582-
reconcilerVersion: "18.3.0-next-fec97ecbc-20230410"
10582+
reconcilerVersion: "18.3.0-next-451736b55-20230410"
1058310583
});
1058410584
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1058510585
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)