Skip to content

Commit 88574c1

Browse files
authored
Fix enableTransitionTracing flag (#24801)
Move `enableTransitionTracing` to `dynamicFeatureFlags` so it runs when you run `yarn test`
1 parent a4bed46 commit 88574c1

File tree

5 files changed

+10
-2
lines changed

5 files changed

+10
-2
lines changed

packages/react-noop-renderer/src/createReactNoop.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -806,6 +806,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
806806
false,
807807
'',
808808
onRecoverableError,
809+
null,
809810
);
810811
roots.set(rootID, root);
811812
}
@@ -859,6 +860,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
859860
false,
860861
'',
861862
onRecoverableError,
863+
null,
862864
);
863865
return {
864866
_Scheduler: Scheduler,

packages/react-reconciler/src/ReactFiber.new.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,9 @@ export function createFiberFromLegacyHidden(
734734
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
735735
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
736736
fiber.lanes = lanes;
737+
// Adding a stateNode for legacy hidden because it's currently using
738+
// the offscreen implementation, which depends on a state node
739+
fiber.stateNode = {};
737740
return fiber;
738741
}
739742

packages/react-reconciler/src/ReactFiber.old.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,9 @@ export function createFiberFromLegacyHidden(
734734
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
735735
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
736736
fiber.lanes = lanes;
737+
// Adding a stateNode for legacy hidden because it's currently using
738+
// the offscreen implementation, which depends on a state node
739+
fiber.stateNode = {};
737740
return fiber;
738741
}
739742

packages/react/index.classic.fb.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export {
3434
startTransition,
3535
startTransition as unstable_startTransition, // TODO: Remove once call sights updated to startTransition
3636
unstable_Cache,
37+
unstable_TracingMarker,
3738
unstable_DebugTracingMode,
3839
unstable_LegacyHidden,
3940
unstable_Offscreen,

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ export const {
3333
enableSyncDefaultUpdates,
3434
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
3535
enableClientRenderFallbackOnTextMismatch,
36+
enableTransitionTracing,
3637
} = dynamicFeatureFlags;
3738

3839
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
@@ -106,8 +107,6 @@ export const enableUseMutableSource = true;
106107

107108
export const enableCustomElementPropertySupport = __EXPERIMENTAL__;
108109

109-
export const enableTransitionTracing = false;
110-
111110
export const enableSymbolFallbackForWWW = true;
112111
// Flow magic to verify the exports of this file match the original version.
113112
// eslint-disable-next-line no-unused-vars

0 commit comments

Comments
 (0)