Skip to content

Commit 7d2f2b9

Browse files
committed
refactor[react-devtools]: propagate settings from global hook object to frontend (#30610)
Stacked on #30597 and whats under it. See [this commit](59b4efa). With this change, the initial values for console patching settings are propagated from hook (which is the source of truth now, because of #30596) to the UI. Instead of reading from `localStorage` the frontend is now requesting it from the hook. This happens when settings modal is rendered, and wrapped in a transition. Also, this is happening even if settings modal is not opened yet, so we have enough time to fetch this data without displaying loader or similar UI. DiffTrain build for [e33acfd](e33acfd)
1 parent acd2b4f commit 7d2f2b9

34 files changed

+176
-189
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
fce46066571e7bf3ab6ce5bfe5fd3a615e098421
1+
e33acfd67f0003272a9aec7a0725d19a429f2460
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
fce46066571e7bf3ab6ce5bfe5fd3a615e098421
1+
e33acfd67f0003272a9aec7a0725d19a429f2460

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2000,7 +2000,7 @@ __DEV__ &&
20002000
exports.useTransition = function () {
20012001
return resolveDispatcher().useTransition();
20022002
};
2003-
exports.version = "19.0.0-www-classic-fce46066-20240918";
2003+
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
20042004
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20052005
"function" ===
20062006
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1980,7 +1980,7 @@ __DEV__ &&
19801980
exports.useTransition = function () {
19811981
return resolveDispatcher().useTransition();
19821982
};
1983-
exports.version = "19.0.0-www-modern-fce46066-20240918";
1983+
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
19841984
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19851985
"function" ===
19861986
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-fce46066-20240918";
668+
exports.version = "19.0.0-www-classic-e33acfd6-20240918";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-fce46066-20240918";
668+
exports.version = "19.0.0-www-modern-e33acfd6-20240918";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-fce46066-20240918";
672+
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-fce46066-20240918";
672+
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17026,11 +17026,11 @@ __DEV__ &&
1702617026
(function () {
1702717027
var internals = {
1702817028
bundleType: 1,
17029-
version: "19.0.0-www-classic-fce46066-20240918",
17029+
version: "19.0.0-www-classic-e33acfd6-20240918",
1703017030
rendererPackageName: "react-art",
1703117031
currentDispatcherRef: ReactSharedInternals,
1703217032
findFiberByHostInstance: getInstanceFromNode,
17033-
reconcilerVersion: "19.0.0-www-classic-fce46066-20240918"
17033+
reconcilerVersion: "19.0.0-www-classic-e33acfd6-20240918"
1703417034
};
1703517035
internals.overrideHookState = overrideHookState;
1703617036
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17064,7 +17064,7 @@ __DEV__ &&
1706417064
exports.Shape = Shape;
1706517065
exports.Surface = Surface;
1706617066
exports.Text = Text;
17067-
exports.version = "19.0.0-www-classic-fce46066-20240918";
17067+
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
1706817068
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1706917069
"function" ===
1707017070
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16472,11 +16472,11 @@ __DEV__ &&
1647216472
(function () {
1647316473
var internals = {
1647416474
bundleType: 1,
16475-
version: "19.0.0-www-modern-fce46066-20240918",
16475+
version: "19.0.0-www-modern-e33acfd6-20240918",
1647616476
rendererPackageName: "react-art",
1647716477
currentDispatcherRef: ReactSharedInternals,
1647816478
findFiberByHostInstance: getInstanceFromNode,
16479-
reconcilerVersion: "19.0.0-www-modern-fce46066-20240918"
16479+
reconcilerVersion: "19.0.0-www-modern-e33acfd6-20240918"
1648016480
};
1648116481
internals.overrideHookState = overrideHookState;
1648216482
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16510,7 +16510,7 @@ __DEV__ &&
1651016510
exports.Shape = Shape;
1651116511
exports.Surface = Surface;
1651216512
exports.Text = Text;
16513-
exports.version = "19.0.0-www-modern-fce46066-20240918";
16513+
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
1651416514
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1651516515
"function" ===
1651616516
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)