Skip to content

Commit 7bcc687

Browse files
authored
Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects (#25080)
1 parent 7a22727 commit 7bcc687

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

packages/react-reconciler/src/ReactFiberCommitWork.new.js

-11
Original file line numberDiff line numberDiff line change
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
10991099
recursivelyTraverseReappearLayoutEffects(
11001100
finishedRoot,
11011101
finishedWork,
1102-
committedLanes,
11031102
includeWorkInProgressEffects,
11041103
);
11051104
} else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
27042703
finishedRoot: FiberRoot,
27052704
current: Fiber | null,
27062705
finishedWork: Fiber,
2707-
committedLanes: Lanes,
27082706
// This function visits both newly finished work and nodes that were re-used
27092707
// from a previously committed tree. We cannot check non-static flags if the
27102708
// node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
27192717
recursivelyTraverseReappearLayoutEffects(
27202718
finishedRoot,
27212719
finishedWork,
2722-
committedLanes,
27232720
includeWorkInProgressEffects,
27242721
);
27252722
// TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
27302727
recursivelyTraverseReappearLayoutEffects(
27312728
finishedRoot,
27322729
finishedWork,
2733-
committedLanes,
27342730
includeWorkInProgressEffects,
27352731
);
27362732

@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
27722768
recursivelyTraverseReappearLayoutEffects(
27732769
finishedRoot,
27742770
finishedWork,
2775-
committedLanes,
27762771
includeWorkInProgressEffects,
27772772
);
27782773

@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
27922787
recursivelyTraverseReappearLayoutEffects(
27932788
finishedRoot,
27942789
finishedWork,
2795-
committedLanes,
27962790
includeWorkInProgressEffects,
27972791
);
27982792
// TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
28052799
recursivelyTraverseReappearLayoutEffects(
28062800
finishedRoot,
28072801
finishedWork,
2808-
committedLanes,
28092802
includeWorkInProgressEffects,
28102803
);
28112804

@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
28252818
recursivelyTraverseReappearLayoutEffects(
28262819
finishedRoot,
28272820
finishedWork,
2828-
committedLanes,
28292821
includeWorkInProgressEffects,
28302822
);
28312823
}
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
28352827
recursivelyTraverseReappearLayoutEffects(
28362828
finishedRoot,
28372829
finishedWork,
2838-
committedLanes,
28392830
includeWorkInProgressEffects,
28402831
);
28412832
break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
28462837
function recursivelyTraverseReappearLayoutEffects(
28472838
finishedRoot: FiberRoot,
28482839
parentFiber: Fiber,
2849-
committedLanes: Lanes,
28502840
includeWorkInProgressEffects: boolean,
28512841
) {
28522842
// This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
28652855
finishedRoot,
28662856
current,
28672857
child,
2868-
committedLanes,
28692858
childShouldIncludeWorkInProgressEffects,
28702859
);
28712860
child = child.sibling;

packages/react-reconciler/src/ReactFiberCommitWork.old.js

-11
Original file line numberDiff line numberDiff line change
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
10991099
recursivelyTraverseReappearLayoutEffects(
11001100
finishedRoot,
11011101
finishedWork,
1102-
committedLanes,
11031102
includeWorkInProgressEffects,
11041103
);
11051104
} else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
27042703
finishedRoot: FiberRoot,
27052704
current: Fiber | null,
27062705
finishedWork: Fiber,
2707-
committedLanes: Lanes,
27082706
// This function visits both newly finished work and nodes that were re-used
27092707
// from a previously committed tree. We cannot check non-static flags if the
27102708
// node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
27192717
recursivelyTraverseReappearLayoutEffects(
27202718
finishedRoot,
27212719
finishedWork,
2722-
committedLanes,
27232720
includeWorkInProgressEffects,
27242721
);
27252722
// TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
27302727
recursivelyTraverseReappearLayoutEffects(
27312728
finishedRoot,
27322729
finishedWork,
2733-
committedLanes,
27342730
includeWorkInProgressEffects,
27352731
);
27362732

@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
27722768
recursivelyTraverseReappearLayoutEffects(
27732769
finishedRoot,
27742770
finishedWork,
2775-
committedLanes,
27762771
includeWorkInProgressEffects,
27772772
);
27782773

@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
27922787
recursivelyTraverseReappearLayoutEffects(
27932788
finishedRoot,
27942789
finishedWork,
2795-
committedLanes,
27962790
includeWorkInProgressEffects,
27972791
);
27982792
// TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
28052799
recursivelyTraverseReappearLayoutEffects(
28062800
finishedRoot,
28072801
finishedWork,
2808-
committedLanes,
28092802
includeWorkInProgressEffects,
28102803
);
28112804

@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
28252818
recursivelyTraverseReappearLayoutEffects(
28262819
finishedRoot,
28272820
finishedWork,
2828-
committedLanes,
28292821
includeWorkInProgressEffects,
28302822
);
28312823
}
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
28352827
recursivelyTraverseReappearLayoutEffects(
28362828
finishedRoot,
28372829
finishedWork,
2838-
committedLanes,
28392830
includeWorkInProgressEffects,
28402831
);
28412832
break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
28462837
function recursivelyTraverseReappearLayoutEffects(
28472838
finishedRoot: FiberRoot,
28482839
parentFiber: Fiber,
2849-
committedLanes: Lanes,
28502840
includeWorkInProgressEffects: boolean,
28512841
) {
28522842
// This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
28652855
finishedRoot,
28662856
current,
28672857
child,
2868-
committedLanes,
28692858
childShouldIncludeWorkInProgressEffects,
28702859
);
28712860
child = child.sibling;

0 commit comments

Comments
 (0)