Skip to content

Commit 7ae2fa4

Browse files
hoxyqhoxyq
committed
feat[react-devtools/extension]: use chrome.storage to persist settings across sessions (#30636)
Stacked on #30610 and whats under it. See [last commit](248ddba). Now, we are using [`chrome.storage`](https://developer.chrome.com/docs/extensions/reference/api/storage) to persist settings for the browser extension across different sessions. Once settings are updated from the UI, the `Store` will emit `settingsUpdated` event, and we are going to persist them via `chrome.storage.local.set` in `main/index.js`. When hook is being injected, we are going to pass a `Promise`, which is going to be resolved after the settings are read from the storage via `chrome.storage.local.get` in `hookSettingsInjector.js`. DiffTrain build for [f37c7bc](f37c7bc)
1 parent 7d2f2b9 commit 7ae2fa4

34 files changed

+179
-176
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e33acfd67f0003272a9aec7a0725d19a429f2460
1+
f37c7bc6539b4da38f7080b5486eb00bdb2c3237

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e33acfd67f0003272a9aec7a0725d19a429f2460
1+
f37c7bc6539b4da38f7080b5486eb00bdb2c3237

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2000,7 +2000,7 @@ __DEV__ &&
20002000
exports.useTransition = function () {
20012001
return resolveDispatcher().useTransition();
20022002
};
2003-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
2003+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";
20042004
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20052005
"function" ===
20062006
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1980,7 +1980,7 @@ __DEV__ &&
19801980
exports.useTransition = function () {
19811981
return resolveDispatcher().useTransition();
19821982
};
1983-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
1983+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";
19841984
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19851985
"function" ===
19861986
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
668+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
668+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
672+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
672+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17026,11 +17026,11 @@ __DEV__ &&
1702617026
(function () {
1702717027
var internals = {
1702817028
bundleType: 1,
17029-
version: "19.0.0-www-classic-e33acfd6-20240918",
17029+
version: "19.0.0-www-classic-f37c7bc6-20240918",
1703017030
rendererPackageName: "react-art",
1703117031
currentDispatcherRef: ReactSharedInternals,
1703217032
findFiberByHostInstance: getInstanceFromNode,
17033-
reconcilerVersion: "19.0.0-www-classic-e33acfd6-20240918"
17033+
reconcilerVersion: "19.0.0-www-classic-f37c7bc6-20240918"
1703417034
};
1703517035
internals.overrideHookState = overrideHookState;
1703617036
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17064,7 +17064,7 @@ __DEV__ &&
1706417064
exports.Shape = Shape;
1706517065
exports.Surface = Surface;
1706617066
exports.Text = Text;
17067-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
17067+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";
1706817068
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1706917069
"function" ===
1707017070
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16472,11 +16472,11 @@ __DEV__ &&
1647216472
(function () {
1647316473
var internals = {
1647416474
bundleType: 1,
16475-
version: "19.0.0-www-modern-e33acfd6-20240918",
16475+
version: "19.0.0-www-modern-f37c7bc6-20240918",
1647616476
rendererPackageName: "react-art",
1647716477
currentDispatcherRef: ReactSharedInternals,
1647816478
findFiberByHostInstance: getInstanceFromNode,
16479-
reconcilerVersion: "19.0.0-www-modern-e33acfd6-20240918"
16479+
reconcilerVersion: "19.0.0-www-modern-f37c7bc6-20240918"
1648016480
};
1648116481
internals.overrideHookState = overrideHookState;
1648216482
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16510,7 +16510,7 @@ __DEV__ &&
1651016510
exports.Shape = Shape;
1651116511
exports.Surface = Surface;
1651216512
exports.Text = Text;
16513-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
16513+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";
1651416514
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1651516515
"function" ===
1651616516
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10853,13 +10853,13 @@ var slice = Array.prototype.slice,
1085310853
})(React.Component);
1085410854
var internals$jscomp$inline_1439 = {
1085510855
bundleType: 0,
10856-
version: "19.0.0-www-classic-e33acfd6-20240918",
10856+
version: "19.0.0-www-classic-f37c7bc6-20240918",
1085710857
rendererPackageName: "react-art",
1085810858
currentDispatcherRef: ReactSharedInternals,
1085910859
findFiberByHostInstance: function () {
1086010860
return null;
1086110861
},
10862-
reconcilerVersion: "19.0.0-www-classic-e33acfd6-20240918"
10862+
reconcilerVersion: "19.0.0-www-classic-f37c7bc6-20240918"
1086310863
};
1086410864
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1086510865
var hook$jscomp$inline_1440 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10885,4 +10885,4 @@ exports.RadialGradient = RadialGradient;
1088510885
exports.Shape = TYPES.SHAPE;
1088610886
exports.Surface = Surface;
1088710887
exports.Text = Text;
10888-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
10888+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";

‎compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10367,13 +10367,13 @@ var slice = Array.prototype.slice,
1036710367
})(React.Component);
1036810368
var internals$jscomp$inline_1431 = {
1036910369
bundleType: 0,
10370-
version: "19.0.0-www-modern-e33acfd6-20240918",
10370+
version: "19.0.0-www-modern-f37c7bc6-20240918",
1037110371
rendererPackageName: "react-art",
1037210372
currentDispatcherRef: ReactSharedInternals,
1037310373
findFiberByHostInstance: function () {
1037410374
return null;
1037510375
},
10376-
reconcilerVersion: "19.0.0-www-modern-e33acfd6-20240918"
10376+
reconcilerVersion: "19.0.0-www-modern-f37c7bc6-20240918"
1037710377
};
1037810378
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1037910379
var hook$jscomp$inline_1432 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10399,4 +10399,4 @@ exports.RadialGradient = RadialGradient;
1039910399
exports.Shape = TYPES.SHAPE;
1040010400
exports.Surface = Surface;
1040110401
exports.Text = Text;
10402-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
10402+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18576,41 +18576,41 @@ __DEV__ &&
1857618576
: !1;
1857718577
}
1857818578
function getActiveElementDeep(containerInfo) {
18579-
var $jscomp$optchain$tmp652994824$1, $jscomp$nullish$tmp0;
18579+
var $jscomp$optchain$tmpm375336033$1, $jscomp$nullish$tmp0;
1858018580
containerInfo =
1858118581
null !=
1858218582
($jscomp$nullish$tmp0 =
1858318583
null == containerInfo
1858418584
? void 0
1858518585
: null ==
18586-
($jscomp$optchain$tmp652994824$1 = containerInfo.ownerDocument)
18586+
($jscomp$optchain$tmpm375336033$1 = containerInfo.ownerDocument)
1858718587
? void 0
18588-
: $jscomp$optchain$tmp652994824$1.defaultView)
18588+
: $jscomp$optchain$tmpm375336033$1.defaultView)
1858918589
? $jscomp$nullish$tmp0
1859018590
: window;
1859118591
for (
18592-
$jscomp$optchain$tmp652994824$1 = getActiveElement(
18592+
$jscomp$optchain$tmpm375336033$1 = getActiveElement(
1859318593
containerInfo.document
1859418594
);
18595-
$jscomp$optchain$tmp652994824$1 instanceof
18595+
$jscomp$optchain$tmpm375336033$1 instanceof
1859618596
containerInfo.HTMLIFrameElement;
1859718597

1859818598
) {
1859918599
try {
1860018600
var JSCompiler_inline_result =
1860118601
"string" ===
18602-
typeof $jscomp$optchain$tmp652994824$1.contentWindow.location.href;
18602+
typeof $jscomp$optchain$tmpm375336033$1.contentWindow.location.href;
1860318603
} catch (err) {
1860418604
JSCompiler_inline_result = !1;
1860518605
}
1860618606
if (JSCompiler_inline_result)
18607-
containerInfo = $jscomp$optchain$tmp652994824$1.contentWindow;
18607+
containerInfo = $jscomp$optchain$tmpm375336033$1.contentWindow;
1860818608
else break;
18609-
$jscomp$optchain$tmp652994824$1 = getActiveElement(
18609+
$jscomp$optchain$tmpm375336033$1 = getActiveElement(
1861018610
containerInfo.document
1861118611
);
1861218612
}
18613-
return $jscomp$optchain$tmp652994824$1;
18613+
return $jscomp$optchain$tmpm375336033$1;
1861418614
}
1861518615
function hasSelectionCapabilities(elem) {
1861618616
var nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();
@@ -27774,11 +27774,11 @@ __DEV__ &&
2777427774
: flushSyncErrorInBuildsThatSupportLegacyMode;
2777527775
(function () {
2777627776
var isomorphicReactPackageVersion = React.version;
27777-
if ("19.0.0-www-classic-e33acfd6-20240918" !== isomorphicReactPackageVersion)
27777+
if ("19.0.0-www-classic-f37c7bc6-20240918" !== isomorphicReactPackageVersion)
2777827778
throw Error(
2777927779
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2778027780
(isomorphicReactPackageVersion +
27781-
"\n - react-dom: 19.0.0-www-classic-e33acfd6-20240918\nLearn more: https://react.dev/warnings/version-mismatch")
27781+
"\n - react-dom: 19.0.0-www-classic-f37c7bc6-20240918\nLearn more: https://react.dev/warnings/version-mismatch")
2778227782
);
2778327783
})();
2778427784
("function" === typeof Map &&
@@ -27822,11 +27822,11 @@ __DEV__ &&
2782227822
!(function () {
2782327823
var internals = {
2782427824
bundleType: 1,
27825-
version: "19.0.0-www-classic-e33acfd6-20240918",
27825+
version: "19.0.0-www-classic-f37c7bc6-20240918",
2782627826
rendererPackageName: "react-dom",
2782727827
currentDispatcherRef: ReactSharedInternals,
2782827828
findFiberByHostInstance: getClosestInstanceFromNode,
27829-
reconcilerVersion: "19.0.0-www-classic-e33acfd6-20240918"
27829+
reconcilerVersion: "19.0.0-www-classic-f37c7bc6-20240918"
2783027830
};
2783127831
internals.overrideHookState = overrideHookState;
2783227832
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -28479,7 +28479,7 @@ __DEV__ &&
2847928479
exports.useFormStatus = function () {
2848028480
return resolveDispatcher().useHostTransitionStatus();
2848128481
};
28482-
exports.version = "19.0.0-www-classic-e33acfd6-20240918";
28482+
exports.version = "19.0.0-www-classic-f37c7bc6-20240918";
2848328483
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2848428484
"function" ===
2848528485
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17910,41 +17910,41 @@ __DEV__ &&
1791017910
: !1;
1791117911
}
1791217912
function getActiveElementDeep(containerInfo) {
17913-
var $jscomp$optchain$tmpm872852562$1, $jscomp$nullish$tmp0;
17913+
var $jscomp$optchain$tmp1329410009$1, $jscomp$nullish$tmp0;
1791417914
containerInfo =
1791517915
null !=
1791617916
($jscomp$nullish$tmp0 =
1791717917
null == containerInfo
1791817918
? void 0
1791917919
: null ==
17920-
($jscomp$optchain$tmpm872852562$1 = containerInfo.ownerDocument)
17920+
($jscomp$optchain$tmp1329410009$1 = containerInfo.ownerDocument)
1792117921
? void 0
17922-
: $jscomp$optchain$tmpm872852562$1.defaultView)
17922+
: $jscomp$optchain$tmp1329410009$1.defaultView)
1792317923
? $jscomp$nullish$tmp0
1792417924
: window;
1792517925
for (
17926-
$jscomp$optchain$tmpm872852562$1 = getActiveElement(
17926+
$jscomp$optchain$tmp1329410009$1 = getActiveElement(
1792717927
containerInfo.document
1792817928
);
17929-
$jscomp$optchain$tmpm872852562$1 instanceof
17929+
$jscomp$optchain$tmp1329410009$1 instanceof
1793017930
containerInfo.HTMLIFrameElement;
1793117931

1793217932
) {
1793317933
try {
1793417934
var JSCompiler_inline_result =
1793517935
"string" ===
17936-
typeof $jscomp$optchain$tmpm872852562$1.contentWindow.location.href;
17936+
typeof $jscomp$optchain$tmp1329410009$1.contentWindow.location.href;
1793717937
} catch (err) {
1793817938
JSCompiler_inline_result = !1;
1793917939
}
1794017940
if (JSCompiler_inline_result)
17941-
containerInfo = $jscomp$optchain$tmpm872852562$1.contentWindow;
17941+
containerInfo = $jscomp$optchain$tmp1329410009$1.contentWindow;
1794217942
else break;
17943-
$jscomp$optchain$tmpm872852562$1 = getActiveElement(
17943+
$jscomp$optchain$tmp1329410009$1 = getActiveElement(
1794417944
containerInfo.document
1794517945
);
1794617946
}
17947-
return $jscomp$optchain$tmpm872852562$1;
17947+
return $jscomp$optchain$tmp1329410009$1;
1794817948
}
1794917949
function hasSelectionCapabilities(elem) {
1795017950
var nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();
@@ -26891,11 +26891,11 @@ __DEV__ &&
2689126891
return_targetInst = null;
2689226892
(function () {
2689326893
var isomorphicReactPackageVersion = React.version;
26894-
if ("19.0.0-www-modern-e33acfd6-20240918" !== isomorphicReactPackageVersion)
26894+
if ("19.0.0-www-modern-f37c7bc6-20240918" !== isomorphicReactPackageVersion)
2689526895
throw Error(
2689626896
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2689726897
(isomorphicReactPackageVersion +
26898-
"\n - react-dom: 19.0.0-www-modern-e33acfd6-20240918\nLearn more: https://react.dev/warnings/version-mismatch")
26898+
"\n - react-dom: 19.0.0-www-modern-f37c7bc6-20240918\nLearn more: https://react.dev/warnings/version-mismatch")
2689926899
);
2690026900
})();
2690126901
("function" === typeof Map &&
@@ -26938,11 +26938,11 @@ __DEV__ &&
2693826938
!(function () {
2693926939
var internals = {
2694026940
bundleType: 1,
26941-
version: "19.0.0-www-modern-e33acfd6-20240918",
26941+
version: "19.0.0-www-modern-f37c7bc6-20240918",
2694226942
rendererPackageName: "react-dom",
2694326943
currentDispatcherRef: ReactSharedInternals,
2694426944
findFiberByHostInstance: getClosestInstanceFromNode,
26945-
reconcilerVersion: "19.0.0-www-modern-e33acfd6-20240918"
26945+
reconcilerVersion: "19.0.0-www-modern-f37c7bc6-20240918"
2694626946
};
2694726947
internals.overrideHookState = overrideHookState;
2694826948
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27547,7 +27547,7 @@ __DEV__ &&
2754727547
exports.useFormStatus = function () {
2754827548
return resolveDispatcher().useHostTransitionStatus();
2754927549
};
27550-
exports.version = "19.0.0-www-modern-e33acfd6-20240918";
27550+
exports.version = "19.0.0-www-modern-f37c7bc6-20240918";
2755127551
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2755227552
"function" ===
2755327553
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)