Skip to content

Commit 74404dc

Browse files
josephsavonajosephsavona
committed
[compiler] Fix bug with reassigning function param in destructuring (#33624)
Closes #33577, a bug with ExtractScopeDeclarationsFromDestructuring and codegen when a function param is reassigned. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33624). * #33643 * #33642 * #33640 * #33625 * __->__ #33624 DiffTrain build for [9894c48](9894c48)
1 parent e2d0006 commit 74404dc

26 files changed

+117
-117
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-123ff13b-20250625
1+
19.2.0-native-fb-9894c488-20250625

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c3a3a6310c465f22276962de2f0f2319>>
10+
* @generated SignedSource<<7aa7f8cead56b79b2800cf27ea3aee1f>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
407+
exports.version = "19.2.0-native-fb-9894c488-20250625";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2b56cd6a7ad78f2b3d764aab65963425>>
10+
* @generated SignedSource<<86f6e52b601c9212c0a2df00969cfc08>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
206+
exports.version = "19.2.0-native-fb-9894c488-20250625";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2b56cd6a7ad78f2b3d764aab65963425>>
10+
* @generated SignedSource<<86f6e52b601c9212c0a2df00969cfc08>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
206+
exports.version = "19.2.0-native-fb-9894c488-20250625";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a3b8c05cfd93cba258be674731c9d6f5>>
10+
* @generated SignedSource<<8e074ca71cd180d0d1552d9f50c8a2ee>>
1111
*/
1212

1313
/*
@@ -28651,11 +28651,11 @@ __DEV__ &&
2865128651
};
2865228652
(function () {
2865328653
var isomorphicReactPackageVersion = React.version;
28654-
if ("19.2.0-native-fb-123ff13b-20250625" !== isomorphicReactPackageVersion)
28654+
if ("19.2.0-native-fb-9894c488-20250625" !== isomorphicReactPackageVersion)
2865528655
throw Error(
2865628656
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2865728657
(isomorphicReactPackageVersion +
28658-
"\n - react-dom: 19.2.0-native-fb-123ff13b-20250625\nLearn more: https://react.dev/warnings/version-mismatch")
28658+
"\n - react-dom: 19.2.0-native-fb-9894c488-20250625\nLearn more: https://react.dev/warnings/version-mismatch")
2865928659
);
2866028660
})();
2866128661
("function" === typeof Map &&
@@ -28692,10 +28692,10 @@ __DEV__ &&
2869228692
!(function () {
2869328693
var internals = {
2869428694
bundleType: 1,
28695-
version: "19.2.0-native-fb-123ff13b-20250625",
28695+
version: "19.2.0-native-fb-9894c488-20250625",
2869628696
rendererPackageName: "react-dom",
2869728697
currentDispatcherRef: ReactSharedInternals,
28698-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625"
28698+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625"
2869928699
};
2870028700
internals.overrideHookState = overrideHookState;
2870128701
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -28833,5 +28833,5 @@ __DEV__ &&
2883328833
listenToAllSupportedEvents(container);
2883428834
return new ReactDOMHydrationRoot(initialChildren);
2883528835
};
28836-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
28836+
exports.version = "19.2.0-native-fb-9894c488-20250625";
2883728837
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<46e83bd3e42ab9040d6bb857d6199d99>>
10+
* @generated SignedSource<<214e9b286178f179f61d19d4e2e33862>>
1111
*/
1212

1313
/*
@@ -17121,14 +17121,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712117121
};
1712217122
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1712317123
if (
17124-
"19.2.0-native-fb-123ff13b-20250625" !==
17124+
"19.2.0-native-fb-9894c488-20250625" !==
1712517125
isomorphicReactPackageVersion$jscomp$inline_2023
1712617126
)
1712717127
throw Error(
1712817128
formatProdErrorMessage(
1712917129
527,
1713017130
isomorphicReactPackageVersion$jscomp$inline_2023,
17131-
"19.2.0-native-fb-123ff13b-20250625"
17131+
"19.2.0-native-fb-9894c488-20250625"
1713217132
)
1713317133
);
1713417134
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17150,10 +17150,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715017150
};
1715117151
var internals$jscomp$inline_2542 = {
1715217152
bundleType: 0,
17153-
version: "19.2.0-native-fb-123ff13b-20250625",
17153+
version: "19.2.0-native-fb-9894c488-20250625",
1715417154
rendererPackageName: "react-dom",
1715517155
currentDispatcherRef: ReactSharedInternals,
17156-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625"
17156+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625"
1715717157
};
1715817158
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1715917159
var hook$jscomp$inline_2543 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17251,4 +17251,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725117251
listenToAllSupportedEvents(container);
1725217252
return new ReactDOMHydrationRoot(initialChildren);
1725317253
};
17254-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
17254+
exports.version = "19.2.0-native-fb-9894c488-20250625";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9e77781e22bbfffb66b15e57cfb2de13>>
10+
* @generated SignedSource<<eb8cdf2cbf395b9ef82489ee3b5a7d46>>
1111
*/
1212

1313
/*
@@ -19053,14 +19053,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1905319053
};
1905419054
var isomorphicReactPackageVersion$jscomp$inline_2261 = React.version;
1905519055
if (
19056-
"19.2.0-native-fb-123ff13b-20250625" !==
19056+
"19.2.0-native-fb-9894c488-20250625" !==
1905719057
isomorphicReactPackageVersion$jscomp$inline_2261
1905819058
)
1905919059
throw Error(
1906019060
formatProdErrorMessage(
1906119061
527,
1906219062
isomorphicReactPackageVersion$jscomp$inline_2261,
19063-
"19.2.0-native-fb-123ff13b-20250625"
19063+
"19.2.0-native-fb-9894c488-20250625"
1906419064
)
1906519065
);
1906619066
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19082,10 +19082,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1908219082
};
1908319083
var internals$jscomp$inline_2268 = {
1908419084
bundleType: 0,
19085-
version: "19.2.0-native-fb-123ff13b-20250625",
19085+
version: "19.2.0-native-fb-9894c488-20250625",
1908619086
rendererPackageName: "react-dom",
1908719087
currentDispatcherRef: ReactSharedInternals,
19088-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625",
19088+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625",
1908919089
getLaneLabelMap: function () {
1909019090
for (
1909119091
var map = new Map(), lane = 1, index$331 = 0;
@@ -19198,4 +19198,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1919819198
listenToAllSupportedEvents(container);
1919919199
return new ReactDOMHydrationRoot(initialChildren);
1920019200
};
19201-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
19201+
exports.version = "19.2.0-native-fb-9894c488-20250625";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2c61d4febbdcc5334e51372d20b00ce3>>
10+
* @generated SignedSource<<727ba832f1cbee1e1dbc93935792a08d>>
1111
*/
1212

1313
/*
@@ -28707,11 +28707,11 @@ __DEV__ &&
2870728707
};
2870828708
(function () {
2870928709
var isomorphicReactPackageVersion = React.version;
28710-
if ("19.2.0-native-fb-123ff13b-20250625" !== isomorphicReactPackageVersion)
28710+
if ("19.2.0-native-fb-9894c488-20250625" !== isomorphicReactPackageVersion)
2871128711
throw Error(
2871228712
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2871328713
(isomorphicReactPackageVersion +
28714-
"\n - react-dom: 19.2.0-native-fb-123ff13b-20250625\nLearn more: https://react.dev/warnings/version-mismatch")
28714+
"\n - react-dom: 19.2.0-native-fb-9894c488-20250625\nLearn more: https://react.dev/warnings/version-mismatch")
2871528715
);
2871628716
})();
2871728717
("function" === typeof Map &&
@@ -28748,10 +28748,10 @@ __DEV__ &&
2874828748
!(function () {
2874928749
var internals = {
2875028750
bundleType: 1,
28751-
version: "19.2.0-native-fb-123ff13b-20250625",
28751+
version: "19.2.0-native-fb-9894c488-20250625",
2875228752
rendererPackageName: "react-dom",
2875328753
currentDispatcherRef: ReactSharedInternals,
28754-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625"
28754+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625"
2875528755
};
2875628756
internals.overrideHookState = overrideHookState;
2875728757
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29205,7 +29205,7 @@ __DEV__ &&
2920529205
exports.useFormStatus = function () {
2920629206
return resolveDispatcher().useHostTransitionStatus();
2920729207
};
29208-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
29208+
exports.version = "19.2.0-native-fb-9894c488-20250625";
2920929209
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2921029210
"function" ===
2921129211
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d5ba384836e731c4be57f5168bcff553>>
10+
* @generated SignedSource<<8ce6156a4bd7818ab4f97d690dcd9364>>
1111
*/
1212

1313
/*
@@ -17132,14 +17132,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1713217132
};
1713317133
var isomorphicReactPackageVersion$jscomp$inline_2024 = React.version;
1713417134
if (
17135-
"19.2.0-native-fb-123ff13b-20250625" !==
17135+
"19.2.0-native-fb-9894c488-20250625" !==
1713617136
isomorphicReactPackageVersion$jscomp$inline_2024
1713717137
)
1713817138
throw Error(
1713917139
formatProdErrorMessage(
1714017140
527,
1714117141
isomorphicReactPackageVersion$jscomp$inline_2024,
17142-
"19.2.0-native-fb-123ff13b-20250625"
17142+
"19.2.0-native-fb-9894c488-20250625"
1714317143
)
1714417144
);
1714517145
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17161,10 +17161,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1716117161
};
1716217162
var internals$jscomp$inline_2545 = {
1716317163
bundleType: 0,
17164-
version: "19.2.0-native-fb-123ff13b-20250625",
17164+
version: "19.2.0-native-fb-9894c488-20250625",
1716517165
rendererPackageName: "react-dom",
1716617166
currentDispatcherRef: ReactSharedInternals,
17167-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625"
17167+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625"
1716817168
};
1716917169
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1717017170
var hook$jscomp$inline_2546 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17415,4 +17415,4 @@ exports.useFormState = function (action, initialState, permalink) {
1741517415
exports.useFormStatus = function () {
1741617416
return ReactSharedInternals.H.useHostTransitionStatus();
1741717417
};
17418-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
17418+
exports.version = "19.2.0-native-fb-9894c488-20250625";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<614bb4ec9801ce31d283c1cc1605e3c0>>
10+
* @generated SignedSource<<42e3666353f304e91e408588a8bf36fe>>
1111
*/
1212

1313
/*
@@ -19068,14 +19068,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1906819068
};
1906919069
var isomorphicReactPackageVersion$jscomp$inline_2262 = React.version;
1907019070
if (
19071-
"19.2.0-native-fb-123ff13b-20250625" !==
19071+
"19.2.0-native-fb-9894c488-20250625" !==
1907219072
isomorphicReactPackageVersion$jscomp$inline_2262
1907319073
)
1907419074
throw Error(
1907519075
formatProdErrorMessage(
1907619076
527,
1907719077
isomorphicReactPackageVersion$jscomp$inline_2262,
19078-
"19.2.0-native-fb-123ff13b-20250625"
19078+
"19.2.0-native-fb-9894c488-20250625"
1907919079
)
1908019080
);
1908119081
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19097,10 +19097,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1909719097
};
1909819098
var internals$jscomp$inline_2269 = {
1909919099
bundleType: 0,
19100-
version: "19.2.0-native-fb-123ff13b-20250625",
19100+
version: "19.2.0-native-fb-9894c488-20250625",
1910119101
rendererPackageName: "react-dom",
1910219102
currentDispatcherRef: ReactSharedInternals,
19103-
reconcilerVersion: "19.2.0-native-fb-123ff13b-20250625",
19103+
reconcilerVersion: "19.2.0-native-fb-9894c488-20250625",
1910419104
getLaneLabelMap: function () {
1910519105
for (
1910619106
var map = new Map(), lane = 1, index$331 = 0;
@@ -19366,7 +19366,7 @@ exports.useFormState = function (action, initialState, permalink) {
1936619366
exports.useFormStatus = function () {
1936719367
return ReactSharedInternals.H.useHostTransitionStatus();
1936819368
};
19369-
exports.version = "19.2.0-native-fb-123ff13b-20250625";
19369+
exports.version = "19.2.0-native-fb-9894c488-20250625";
1937019370
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1937119371
"function" ===
1937219372
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)