Skip to content

Commit 7002a67

Browse files
authored
[cleanup] remove unused values from ReactFeatureFlags.www-dynamic (#25575)
These values are never imported into `ReactFeatureFlags.www.js`, so they're unused: - `allowConcurrentByDefault` - `consoleManagedByDevToolsDuringStrictMode` These values are never set in the WWW module (https://fburl.com/code/dsb2ohv8), so they're always `undefined` on www: - `createRootStrictEffectsByDefault` - `enableClientRenderFallbackOnTextMismatch`
1 parent fb324fa commit 7002a67

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
2525
export const enableLazyContextPropagation = __VARIANT__;
2626
export const enableSyncDefaultUpdates = __VARIANT__;
2727
export const enableUnifiedSyncLane = __VARIANT__;
28-
export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
2928
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = __VARIANT__;
30-
export const enableClientRenderFallbackOnTextMismatch = __VARIANT__;
3129
export const enableTransitionTracing = __VARIANT__;
3230
// Enable this flag to help with concurrent mode debugging.
3331
// It logs information to the console about React scheduling, rendering, and commit phases.
@@ -57,7 +55,5 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
5755
export const enableTrustedTypesIntegration = false;
5856
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
5957
export const disableNativeComponentFrames = false;
60-
export const createRootStrictEffectsByDefault = false;
61-
export const allowConcurrentByDefault = true;
6258
// You probably *don't* want to add more hardcoded ones.
6359
// Instead, try to add them above with the __VARIANT__ value.

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,13 @@ export const {
2525
deferRenderPhaseUpdateToNextBatch,
2626
enableDebugTracing,
2727
skipUnmountedBoundaries,
28-
createRootStrictEffectsByDefault,
2928
enableUseRefAccessWarning,
3029
disableNativeComponentFrames,
3130
disableSchedulerTimeoutInWorkLoop,
3231
enableLazyContextPropagation,
3332
enableSyncDefaultUpdates,
3433
enableUnifiedSyncLane,
3534
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
36-
enableClientRenderFallbackOnTextMismatch,
3735
enableTransitionTracing,
3836
} = dynamicFeatureFlags;
3937

@@ -48,6 +46,7 @@ export const enableProfilerNestedUpdateScheduledHook: boolean =
4846
__PROFILE__ && dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
4947
export const enableUpdaterTracking = __PROFILE__;
5048

49+
export const createRootStrictEffectsByDefault = false;
5150
export const enableSuspenseAvoidThisFallback = true;
5251
export const enableSuspenseAvoidThisFallbackFizz = false;
5352
export const enableCPUSuspense = true;
@@ -56,6 +55,7 @@ export const enableUseHook = true;
5655
export const enableUseMemoCacheHook = true;
5756
export const enableUseEffectEventHook = true;
5857
export const enableHostSingletons = true;
58+
export const enableClientRenderFallbackOnTextMismatch = false;
5959

6060
// Logs additional User Timing API marks for use with an experimental profiling tool.
6161
export const enableSchedulingProfiler: boolean =

0 commit comments

Comments
 (0)