Skip to content

Commit 673f8bc

Browse files
author
Brian Vaughn
committed
Merged interaction-tracking package into react-scheduler
React UMD bundles inlines the new react-scheduler package and exposes the API via the SECRET_INTERNALS object. UMD bundles of e.g. ReactDOM access the API this way. This avoids breaking backwards compat for UMD bundles (since it avoids requiring a new <script> tag). react CJS bundles to not inline the react-scheduler package. Instead, react-dom and other renderers import the shared NPM module. A hard NPM depedency has been added to react-dom and other renderers on the new react-scheduler package so that upgrades will not require any additional npm-install steps. A UMD bundle of the new react-scheduler also exists which defines the same public API but lazily forwards method calls to the React SECRET_INTERNALS inlined version. This allows the new API to be used in e.g. Code Pens if people want to.
1 parent b9fa362 commit 673f8bc

File tree

68 files changed

+898
-509
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+898
-509
lines changed

fixtures/packaging/browserify/dev/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"name": "browserify-dev-fixture",
44
"dependencies": {
55
"browserify": "^13.3.0",
6-
"interaction-tracking": "link:../../../../build/node_modules/interaction-tracking",
76
"react": "link:../../../../build/node_modules/react",
8-
"react-dom": "link:../../../../build/node_modules/react-dom"
7+
"react-dom": "link:../../../../build/node_modules/react-dom",
8+
"react-scheduler": "link:../../../../build/node_modules/react-scheduler"
99
},
1010
"scripts": {
1111
"build": "rm -f output.js && browserify ./input.js -o output.js"

fixtures/packaging/browserify/dev/yarn.lock

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,6 @@ insert-module-globals@^7.0.0:
471471
through2 "^2.0.0"
472472
xtend "^4.0.0"
473473

474-
"interaction-tracking@link:../../../../build/node_modules/interaction-tracking":
475-
version "0.0.0"
476-
uid ""
477-
478474
is-buffer@^1.1.0:
479475
version "1.1.5"
480476
resolved "https://registry.yarnpkg.com/is-buffer/-/is-buffer-1.1.5.tgz#1f3b26ef613b214b88cbca23cc6c01d87961eecc"
@@ -487,6 +483,10 @@ isarray@~0.0.1:
487483
version "0.0.1"
488484
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
489485

486+
"js-tokens@^3.0.0 || ^4.0.0":
487+
version "4.0.0"
488+
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
489+
490490
json-stable-stringify@~0.0.0:
491491
version "0.0.1"
492492
resolved "https://registry.yarnpkg.com/json-stable-stringify/-/json-stable-stringify-0.0.1.tgz#611c23e814db375527df851193db59dd2af27f45"
@@ -519,6 +519,12 @@ lodash.memoize@~3.0.3:
519519
version "3.0.4"
520520
resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-3.0.4.tgz#2dcbd2c287cbc0a55cc42328bd0c736150d53e3f"
521521

522+
loose-envify@^1.1.0, loose-envify@^1.3.1:
523+
version "1.4.0"
524+
resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.4.0.tgz#71ee51fa7be4caec1a63839f7e682d8132d30caf"
525+
dependencies:
526+
js-tokens "^3.0.0 || ^4.0.0"
527+
522528
md5.js@^1.3.4:
523529
version "1.3.4"
524530
resolved "https://registry.yarnpkg.com/md5.js/-/md5.js-1.3.4.tgz#e9bdbde94a20a5ac18b04340fc5764d5b09d901d"
@@ -571,6 +577,10 @@ module-deps@^4.0.8:
571577
through2 "^2.0.0"
572578
xtend "^4.0.0"
573579

580+
object-assign@^4.1.1:
581+
version "4.1.1"
582+
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
583+
574584
once@^1.3.0:
575585
version "1.4.0"
576586
resolved "https://registry.yarnpkg.com/once/-/once-1.4.0.tgz#583b1aa775961d4b113ac17d9c50baef9dd76bd1"
@@ -635,6 +645,13 @@ process@~0.11.0:
635645
version "0.11.10"
636646
resolved "https://registry.yarnpkg.com/process/-/process-0.11.10.tgz#7332300e840161bda3e69a1d1d91a7d4bc16f182"
637647

648+
prop-types@^15.6.2:
649+
version "15.6.2"
650+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.2.tgz#05d5ca77b4453e985d60fc7ff8c859094a497102"
651+
dependencies:
652+
loose-envify "^1.3.1"
653+
object-assign "^4.1.1"
654+
638655
public-encrypt@^4.0.0:
639656
version "4.0.0"
640657
resolved "https://registry.yarnpkg.com/public-encrypt/-/public-encrypt-4.0.0.tgz#39f699f3a46560dd5ebacbca693caf7c65c18cc6"
@@ -671,6 +688,14 @@ randombytes@^2.0.0, randombytes@^2.0.1:
671688
version "0.0.0"
672689
uid ""
673690

691+
react-scheduler@^0.1.0-alpha-1:
692+
version "0.1.0"
693+
resolved "https://registry.yarnpkg.com/react-scheduler/-/react-scheduler-0.1.0.tgz#d16c0ee90d2895ff1941e0d681293dbe4f4b4f38"
694+
695+
"react-scheduler@link:../../../../build/node_modules/react-scheduler":
696+
version "0.0.0"
697+
uid ""
698+
674699
"react@link:../../../../build/node_modules/react":
675700
version "0.0.0"
676701
uid ""

fixtures/packaging/browserify/prod/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"name": "browserify-prod-fixture",
44
"dependencies": {
55
"browserify": "^13.3.0",
6-
"interaction-tracking": "link:../../../../build/node_modules/interaction-tracking",
76
"react": "link:../../../../build/node_modules/react",
8-
"react-dom": "link:../../../../build/node_modules/react-dom"
7+
"react-dom": "link:../../../../build/node_modules/react-dom",
8+
"react-scheduler": "link:../../../../build/node_modules/react-scheduler"
99
},
1010
"scripts": {
1111
"build": "rm -f output.js && browserify ./input.js -g [envify --NODE_ENV 'production'] -o output.js"

fixtures/packaging/browserify/prod/yarn.lock

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,6 @@ insert-module-globals@^7.0.0:
482482
through2 "^2.0.0"
483483
xtend "^4.0.0"
484484

485-
"interaction-tracking@link:../../../../build/node_modules/interaction-tracking":
486-
version "0.0.0"
487-
uid ""
488-
489485
is-buffer@^1.1.0:
490486
version "1.1.5"
491487
resolved "https://registry.yarnpkg.com/is-buffer/-/is-buffer-1.1.5.tgz#1f3b26ef613b214b88cbca23cc6c01d87961eecc"
@@ -498,6 +494,10 @@ isarray@~0.0.1:
498494
version "0.0.1"
499495
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
500496

497+
"js-tokens@^3.0.0 || ^4.0.0":
498+
version "4.0.0"
499+
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
500+
501501
json-stable-stringify@~0.0.0:
502502
version "0.0.1"
503503
resolved "https://registry.yarnpkg.com/json-stable-stringify/-/json-stable-stringify-0.0.1.tgz#611c23e814db375527df851193db59dd2af27f45"
@@ -530,6 +530,12 @@ lodash.memoize@~3.0.3:
530530
version "3.0.4"
531531
resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-3.0.4.tgz#2dcbd2c287cbc0a55cc42328bd0c736150d53e3f"
532532

533+
loose-envify@^1.1.0, loose-envify@^1.3.1:
534+
version "1.4.0"
535+
resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.4.0.tgz#71ee51fa7be4caec1a63839f7e682d8132d30caf"
536+
dependencies:
537+
js-tokens "^3.0.0 || ^4.0.0"
538+
533539
md5.js@^1.3.4:
534540
version "1.3.4"
535541
resolved "https://registry.yarnpkg.com/md5.js/-/md5.js-1.3.4.tgz#e9bdbde94a20a5ac18b04340fc5764d5b09d901d"
@@ -582,6 +588,10 @@ module-deps@^4.0.8:
582588
through2 "^2.0.0"
583589
xtend "^4.0.0"
584590

591+
object-assign@^4.1.1:
592+
version "4.1.1"
593+
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
594+
585595
once@^1.3.0:
586596
version "1.4.0"
587597
resolved "https://registry.yarnpkg.com/once/-/once-1.4.0.tgz#583b1aa775961d4b113ac17d9c50baef9dd76bd1"
@@ -646,6 +656,13 @@ process@~0.11.0:
646656
version "0.11.10"
647657
resolved "https://registry.yarnpkg.com/process/-/process-0.11.10.tgz#7332300e840161bda3e69a1d1d91a7d4bc16f182"
648658

659+
prop-types@^15.6.2:
660+
version "15.6.2"
661+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.2.tgz#05d5ca77b4453e985d60fc7ff8c859094a497102"
662+
dependencies:
663+
loose-envify "^1.3.1"
664+
object-assign "^4.1.1"
665+
649666
public-encrypt@^4.0.0:
650667
version "4.0.0"
651668
resolved "https://registry.yarnpkg.com/public-encrypt/-/public-encrypt-4.0.0.tgz#39f699f3a46560dd5ebacbca693caf7c65c18cc6"
@@ -682,6 +699,14 @@ randombytes@^2.0.0, randombytes@^2.0.1:
682699
version "0.0.0"
683700
uid ""
684701

702+
react-scheduler@^0.1.0-alpha-1:
703+
version "0.1.0"
704+
resolved "https://registry.yarnpkg.com/react-scheduler/-/react-scheduler-0.1.0.tgz#d16c0ee90d2895ff1941e0d681293dbe4f4b4f38"
705+
706+
"react-scheduler@link:../../../../build/node_modules/react-scheduler":
707+
version "0.0.0"
708+
uid ""
709+
685710
"react@link:../../../../build/node_modules/react":
686711
version "0.0.0"
687712
uid ""

fixtures/packaging/brunch/dev/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"devDependencies": {
55
"brunch": "^2.9.1",
66
"javascript-brunch": "^2.0.0",
7-
"interaction-tracking": "link:../../../../build/node_modules/interaction-tracking",
87
"react": "link:../../../../build/node_modules/react",
9-
"react-dom": "link:../../../../build/node_modules/react-dom"
8+
"react-dom": "link:../../../../build/node_modules/react-dom",
9+
"react-scheduler": "link:../../../../build/node_modules/react-scheduler"
1010
},
1111
"scripts": {
1212
"build": "rm -rf public && brunch build"

fixtures/packaging/brunch/dev/yarn.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,14 +1044,6 @@ init-skeleton@~1.0:
10441044
ncp "^2.0.0"
10451045
normalize-git-url "~3.0.1"
10461046

1047-
interaction-tracking@16.4.3-alpha.0:
1048-
version "0.0.1"
1049-
resolved "https://registry.yarnpkg.com/interaction-tracking/-/interaction-tracking-0.0.1.tgz#08877accb2ec479f2af83d7de7a9ae60b80e8dc5"
1050-
1051-
"interaction-tracking@link:../../../../build/node_modules/interaction-tracking":
1052-
version "0.0.0"
1053-
uid ""
1054-
10551047
ipaddr.js@1.5.2:
10561048
version "1.5.2"
10571049
resolved "https://registry.yarnpkg.com/ipaddr.js/-/ipaddr.js-1.5.2.tgz#d4b505bde9946987ccf0fc58d9010ff9607e3fa0"
@@ -1665,6 +1657,14 @@ rc@^1.1.7:
16651657
version "0.0.0"
16661658
uid ""
16671659

1660+
react-scheduler@^0.1.0-alpha-1:
1661+
version "0.1.0"
1662+
resolved "https://registry.yarnpkg.com/react-scheduler/-/react-scheduler-0.1.0.tgz#d16c0ee90d2895ff1941e0d681293dbe4f4b4f38"
1663+
1664+
"react-scheduler@link:../../../../build/node_modules/react-scheduler":
1665+
version "0.0.0"
1666+
uid ""
1667+
16681668
"react@link:../../../../build/node_modules/react":
16691669
version "0.0.0"
16701670
uid ""

fixtures/packaging/brunch/prod/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"devDependencies": {
55
"brunch": "^2.9.1",
66
"javascript-brunch": "^2.0.0",
7-
"interaction-tracking": "link:../../../../build/node_modules/interaction-tracking",
87
"react": "link:../../../../build/node_modules/react",
9-
"react-dom": "link:../../../../build/node_modules/react-dom"
8+
"react-dom": "link:../../../../build/node_modules/react-dom",
9+
"react-scheduler": "link:../../../../build/node_modules/react-scheduler"
1010
},
1111
"scripts": {
1212
"build": "rm -rf public && brunch build -p"

fixtures/packaging/brunch/prod/yarn.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,14 +1044,6 @@ init-skeleton@~1.0:
10441044
ncp "^2.0.0"
10451045
normalize-git-url "~3.0.1"
10461046

1047-
interaction-tracking@16.4.3-alpha.0:
1048-
version "0.0.1"
1049-
resolved "https://registry.yarnpkg.com/interaction-tracking/-/interaction-tracking-0.0.1.tgz#08877accb2ec479f2af83d7de7a9ae60b80e8dc5"
1050-
1051-
"interaction-tracking@link:../../../../build/node_modules/interaction-tracking":
1052-
version "0.0.0"
1053-
uid ""
1054-
10551047
ipaddr.js@1.5.2:
10561048
version "1.5.2"
10571049
resolved "https://registry.yarnpkg.com/ipaddr.js/-/ipaddr.js-1.5.2.tgz#d4b505bde9946987ccf0fc58d9010ff9607e3fa0"
@@ -1665,6 +1657,14 @@ rc@^1.1.7:
16651657
version "0.0.0"
16661658
uid ""
16671659

1660+
react-scheduler@^0.1.0-alpha-1:
1661+
version "0.1.0"
1662+
resolved "https://registry.yarnpkg.com/react-scheduler/-/react-scheduler-0.1.0.tgz#d16c0ee90d2895ff1941e0d681293dbe4f4b4f38"
1663+
1664+
"react-scheduler@link:../../../../build/node_modules/react-scheduler":
1665+
version "0.0.0"
1666+
uid ""
1667+
16681668
"react@link:../../../../build/node_modules/react":
16691669
version "0.0.0"
16701670
uid ""

fixtures/packaging/rjs/dev/config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ module.exports = {
44
out: 'output.js',
55
optimize: 'none',
66
paths: {
7-
'interaction-tracking':
8-
'../../../../build/dist/interaction-tracking.development',
97
react: '../../../../build/dist/react.development',
108
'react-dom': '../../../../build/dist/react-dom.development',
9+
'react-scheduler': '../../../../build/dist/react-scheduler.development',
1110
},
1211
};

fixtures/packaging/rjs/prod/config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ module.exports = {
44
out: 'output.js',
55
optimize: 'none',
66
paths: {
7-
'interaction-tracking':
8-
'../../../../build/dist/interaction-tracking.production.min',
97
react: '../../../../build/dist/react.production.min',
108
'react-dom': '../../../../build/dist/react-dom.production.min',
9+
'react-scheduler': '../../../../build/dist/react-scheduler.development',
1110
},
1211
};
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
System.config({
22
paths: {
3-
'interaction-tracking':
4-
'../../../../build/dist/interaction-tracking.development.js',
53
react: '../../../../build/dist/react.development.js',
64
'react-dom': '../../../../build/dist/react-dom.development.js',
5+
'react-scheduler': '../../../../build/dist/react-scheduler.development',
76
},
87
});
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
System.config({
22
paths: {
3-
'interaction-tracking':
4-
'../../../../build/dist/interaction-tracking.production.min.js',
53
react: '../../../../build/dist/react.production.min.js',
64
'react-dom': '../../../../build/dist/react-dom.production.min.js',
5+
'react-scheduler': '../../../../build/dist/react-scheduler.development',
76
},
87
});

fixtures/schedule/index.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@ <h2>Tests:</h2>
9292
<script src="../../build/dist/react-scheduler.development.js"></script>
9393
<script src="https://unpkg.com/babel-standalone@6/babel.js"></script>
9494
<script type="text/babel">
95-
const {scheduleWork, cancelWork, now} = ReactScheduler;
95+
const {
96+
unstable_scheduleWork: scheduleWork,
97+
unstable_cancelWork: cancelWork,
98+
unstable_now: now
99+
} = ReactScheduler;
96100
function displayTestResult(testNumber) {
97101
const expectationNode = document.getElementById('test-' + testNumber + '-expected');
98102
const resultNode = document.getElementById('test-' + testNumber);

0 commit comments

Comments
 (0)