Skip to content

Commit 6581486

Browse files
rickhanloniirickhanlonii
committed
Remove skipUnmountedBoundaries (#26489)
# Overview Landing this flag internally, will test this PR in React Native before merging. DiffTrain build for commit ca01f35.
1 parent 9a244f1 commit 6581486

File tree

13 files changed

+31
-82
lines changed

13 files changed

+31
-82
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22034,11 +22034,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error$1) {
2203422034
return;
2203522035
}
2203622036

22037-
var fiber = null;
22038-
22039-
{
22040-
fiber = sourceFiber.return;
22041-
}
22037+
var fiber = nearestMountedAncestor;
2204222038

2204322039
while (fiber !== null) {
2204422040
if (fiber.tag === HostRoot) {
@@ -22071,14 +22067,9 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error$1) {
2207122067
}
2207222068

2207322069
{
22074-
// TODO: Until we re-land skipUnmountedBoundaries (see #20147), this warning
22075-
// will fire for errors that are thrown by destroy functions inside deleted
22076-
// trees. What it should instead do is propagate the error to the parent of
22077-
// the deleted tree. In the meantime, do not add this warning to the
22078-
// allowlist; this is only for our internal use.
2207922070
error(
2208022071
"Internal React error: Attempted to capture a commit phase error " +
22081-
"inside a detached tree. This indicates a bug in React. Likely " +
22072+
"inside a detached tree. This indicates a bug in React. Potential " +
2208222073
"causes include deleting the same fiber more than once, committing an " +
2208322074
"already-finished tree, or an inconsistent return pointer.\n\n" +
2208422075
"Error message:\n\n%s",
@@ -23755,7 +23746,7 @@ function createFiberRoot(
2375523746
return root;
2375623747
}
2375723748

23758-
var ReactVersion = "18.3.0-next-43a70a610-20230330";
23749+
var ReactVersion = "18.3.0-next-ca01f359b-20230330";
2375923750

2376023751
// Might add PROFILE later.
2376123752

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7409,11 +7409,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error) {
74097409
if (3 === sourceFiber.tag)
74107410
captureCommitPhaseErrorOnRoot(sourceFiber, sourceFiber, error);
74117411
else
7412-
for (
7413-
nearestMountedAncestor = sourceFiber.return;
7414-
null !== nearestMountedAncestor;
7415-
7416-
) {
7412+
for (; null !== nearestMountedAncestor; ) {
74177413
if (3 === nearestMountedAncestor.tag) {
74187414
captureCommitPhaseErrorOnRoot(
74197415
nearestMountedAncestor,
@@ -8640,7 +8636,7 @@ var devToolsConfig$jscomp$inline_1007 = {
86408636
throw Error("TestRenderer does not support findFiberByHostInstance()");
86418637
},
86428638
bundleType: 0,
8643-
version: "18.3.0-next-43a70a610-20230330",
8639+
version: "18.3.0-next-ca01f359b-20230330",
86448640
rendererPackageName: "react-test-renderer"
86458641
};
86468642
var internals$jscomp$inline_1198 = {
@@ -8671,7 +8667,7 @@ var internals$jscomp$inline_1198 = {
86718667
scheduleRoot: null,
86728668
setRefreshHandler: null,
86738669
getCurrentFiber: null,
8674-
reconcilerVersion: "18.3.0-next-43a70a610-20230330"
8670+
reconcilerVersion: "18.3.0-next-ca01f359b-20230330"
86758671
};
86768672
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86778673
var hook$jscomp$inline_1199 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7816,11 +7816,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error) {
78167816
if (3 === sourceFiber.tag)
78177817
captureCommitPhaseErrorOnRoot(sourceFiber, sourceFiber, error);
78187818
else
7819-
for (
7820-
nearestMountedAncestor = sourceFiber.return;
7821-
null !== nearestMountedAncestor;
7822-
7823-
) {
7819+
for (; null !== nearestMountedAncestor; ) {
78247820
if (3 === nearestMountedAncestor.tag) {
78257821
captureCommitPhaseErrorOnRoot(
78267822
nearestMountedAncestor,
@@ -9065,7 +9061,7 @@ var devToolsConfig$jscomp$inline_1050 = {
90659061
throw Error("TestRenderer does not support findFiberByHostInstance()");
90669062
},
90679063
bundleType: 0,
9068-
version: "18.3.0-next-43a70a610-20230330",
9064+
version: "18.3.0-next-ca01f359b-20230330",
90699065
rendererPackageName: "react-test-renderer"
90709066
};
90719067
var internals$jscomp$inline_1239 = {
@@ -9096,7 +9092,7 @@ var internals$jscomp$inline_1239 = {
90969092
scheduleRoot: null,
90979093
setRefreshHandler: null,
90989094
getCurrentFiber: null,
9099-
reconcilerVersion: "18.3.0-next-43a70a610-20230330"
9095+
reconcilerVersion: "18.3.0-next-ca01f359b-20230330"
91009096
};
91019097
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91029098
var hook$jscomp$inline_1240 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-43a70a610-20230330";
30+
var ReactVersion = "18.3.0-next-ca01f359b-20230330";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-43a70a610-20230330";
642+
exports.version = "18.3.0-next-ca01f359b-20230330";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-43a70a610-20230330";
645+
exports.version = "18.3.0-next-ca01f359b-20230330";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
43a70a610dd2cc298ab5592deebfbf8f7bbac127
1+
ca01f359b9236292c749075bb2fd41bb7b569308

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25152,11 +25152,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error$1) {
2515225152
return;
2515325153
}
2515425154

25155-
var fiber = null;
25156-
25157-
{
25158-
fiber = sourceFiber.return;
25159-
}
25155+
var fiber = nearestMountedAncestor;
2516025156

2516125157
while (fiber !== null) {
2516225158
if (fiber.tag === HostRoot) {
@@ -25189,14 +25185,9 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error$1) {
2518925185
}
2519025186

2519125187
{
25192-
// TODO: Until we re-land skipUnmountedBoundaries (see #20147), this warning
25193-
// will fire for errors that are thrown by destroy functions inside deleted
25194-
// trees. What it should instead do is propagate the error to the parent of
25195-
// the deleted tree. In the meantime, do not add this warning to the
25196-
// allowlist; this is only for our internal use.
2519725188
error(
2519825189
"Internal React error: Attempted to capture a commit phase error " +
25199-
"inside a detached tree. This indicates a bug in React. Likely " +
25190+
"inside a detached tree. This indicates a bug in React. Potential " +
2520025191
"causes include deleting the same fiber more than once, committing an " +
2520125192
"already-finished tree, or an inconsistent return pointer.\n\n" +
2520225193
"Error message:\n\n%s",
@@ -27021,7 +27012,7 @@ function createFiberRoot(
2702127012
return root;
2702227013
}
2702327014

27024-
var ReactVersion = "18.3.0-next-43a70a610-20230330";
27015+
var ReactVersion = "18.3.0-next-ca01f359b-20230330";
2702527016

2702627017
function createPortal$1(
2702727018
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8473,11 +8473,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error) {
84738473
if (3 === sourceFiber.tag)
84748474
captureCommitPhaseErrorOnRoot(sourceFiber, sourceFiber, error);
84758475
else
8476-
for (
8477-
nearestMountedAncestor = sourceFiber.return;
8478-
null !== nearestMountedAncestor;
8479-
8480-
) {
8476+
for (; null !== nearestMountedAncestor; ) {
84818477
if (3 === nearestMountedAncestor.tag) {
84828478
captureCommitPhaseErrorOnRoot(
84838479
nearestMountedAncestor,
@@ -9507,7 +9503,7 @@ var roots = new Map(),
95079503
devToolsConfig$jscomp$inline_1027 = {
95089504
findFiberByHostInstance: getInstanceFromNode,
95099505
bundleType: 0,
9510-
version: "18.3.0-next-43a70a610-20230330",
9506+
version: "18.3.0-next-ca01f359b-20230330",
95119507
rendererPackageName: "react-native-renderer",
95129508
rendererConfig: {
95139509
getInspectorDataForViewTag: function () {
@@ -9549,7 +9545,7 @@ var internals$jscomp$inline_1273 = {
95499545
scheduleRoot: null,
95509546
setRefreshHandler: null,
95519547
getCurrentFiber: null,
9552-
reconcilerVersion: "18.3.0-next-43a70a610-20230330"
9548+
reconcilerVersion: "18.3.0-next-ca01f359b-20230330"
95539549
};
95549550
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95559551
var hook$jscomp$inline_1274 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9147,11 +9147,7 @@ function captureCommitPhaseError(sourceFiber, nearestMountedAncestor, error) {
91479147
if (3 === sourceFiber.tag)
91489148
captureCommitPhaseErrorOnRoot(sourceFiber, sourceFiber, error);
91499149
else
9150-
for (
9151-
nearestMountedAncestor = sourceFiber.return;
9152-
null !== nearestMountedAncestor;
9153-
9154-
) {
9150+
for (; null !== nearestMountedAncestor; ) {
91559151
if (3 === nearestMountedAncestor.tag) {
91569152
captureCommitPhaseErrorOnRoot(
91579153
nearestMountedAncestor,
@@ -10215,7 +10211,7 @@ var roots = new Map(),
1021510211
devToolsConfig$jscomp$inline_1106 = {
1021610212
findFiberByHostInstance: getInstanceFromNode,
1021710213
bundleType: 0,
10218-
version: "18.3.0-next-43a70a610-20230330",
10214+
version: "18.3.0-next-ca01f359b-20230330",
1021910215
rendererPackageName: "react-native-renderer",
1022010216
rendererConfig: {
1022110217
getInspectorDataForViewTag: function () {
@@ -10270,7 +10266,7 @@ var roots = new Map(),
1027010266
scheduleRoot: null,
1027110267
setRefreshHandler: null,
1027210268
getCurrentFiber: null,
10273-
reconcilerVersion: "18.3.0-next-43a70a610-20230330"
10269+
reconcilerVersion: "18.3.0-next-ca01f359b-20230330"
1027410270
});
1027510271
exports.createPortal = function (children, containerTag) {
1027610272
return createPortal$1(

0 commit comments

Comments
 (0)