SchedulerPostTask: Reuse original TaskController (#27595)

noahlemen · noahlemen · commit 63e0697e970b · 2023-11-02T15:08:54.000Z
## Summary It's not clear to me why we currently create a new TaskController in `runTask` – ultimately, we use the same signal and priority from the original created in `unstable_scheduleCallback` ## How did you test this change? ``` yarn test SchedulerPostTask ``` DiffTrain build for [a17467e](a17467e)
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-6bfc0e032acc7e5ad6da2a09f3c4f47f3321da2c
+a17467e7e2cd8947c595d1834889b5d184459f12
diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -16781,7 +16781,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1840 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-327d25fe",
+  version: "18.3.0-www-modern-9cbf42e3",
   rendererPackageName: "react-dom"
 };
 (function (internals) {
@@ -16826,7 +16826,7 @@ var devToolsConfig$jscomp$inline_1840 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-www-modern-327d25fe"
+  reconcilerVersion: "18.3.0-www-modern-9cbf42e3"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function (children, container) {
@@ -17078,7 +17078,7 @@ exports.useFormState = function () {
 exports.useFormStatus = function () {
   throw Error(formatProdErrorMessage(248));
 };
-exports.version = "18.3.0-www-modern-327d25fe";
+exports.version = "18.3.0-www-modern-9cbf42e3";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/SchedulerPostTask-dev.classic.js b/compiled/facebook-www/SchedulerPostTask-dev.classic.js
@@ -97,15 +97,9 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     if (typeof result === "function") {
       // Assume this is a continuation
       var continuation = result;
-      var continuationController = new TaskController({
-        priority: postTaskPriority
-      });
       var continuationOptions = {
-        signal: continuationController.signal
-      }; // Update the original callback node's controller, since even though we're
-      // posting a new task, conceptually it's the same one.
-
-      node._controller = continuationController;
+        signal: node._controller.signal
+      };
       var nextTask = runTask.bind(
         null,
         priorityLevel,
diff --git a/compiled/facebook-www/SchedulerPostTask-dev.modern.js b/compiled/facebook-www/SchedulerPostTask-dev.modern.js
@@ -97,15 +97,9 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     if (typeof result === "function") {
       // Assume this is a continuation
       var continuation = result;
-      var continuationController = new TaskController({
-        priority: postTaskPriority
-      });
       var continuationOptions = {
-        signal: continuationController.signal
-      }; // Update the original callback node's controller, since even though we're
-      // posting a new task, conceptually it's the same one.
-
-      node._controller = continuationController;
+        signal: node._controller.signal
+      };
       var nextTask = runTask.bind(
         null,
         priorityLevel,
diff --git a/compiled/facebook-www/SchedulerPostTask-prod.classic.js b/compiled/facebook-www/SchedulerPostTask-prod.classic.js
@@ -23,18 +23,14 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     currentPriorityLevel_DEPRECATED = priorityLevel;
     var result = callback(!1);
     if ("function" === typeof result) {
-      var continuationController = new TaskController({
-          priority: postTaskPriority
-        }),
-        continuationOptions = { signal: continuationController.signal };
-      node._controller = continuationController;
-      var nextTask = runTask.bind(
-        null,
-        priorityLevel,
-        postTaskPriority,
-        node,
-        result
-      );
+      var continuationOptions = { signal: node._controller.signal },
+        nextTask = runTask.bind(
+          null,
+          priorityLevel,
+          postTaskPriority,
+          node,
+          result
+        );
       void 0 !== scheduler.yield
         ? scheduler
             .yield(continuationOptions)
diff --git a/compiled/facebook-www/SchedulerPostTask-prod.modern.js b/compiled/facebook-www/SchedulerPostTask-prod.modern.js
@@ -23,18 +23,14 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     currentPriorityLevel_DEPRECATED = priorityLevel;
     var result = callback(!1);
     if ("function" === typeof result) {
-      var continuationController = new TaskController({
-          priority: postTaskPriority
-        }),
-        continuationOptions = { signal: continuationController.signal };
-      node._controller = continuationController;
-      var nextTask = runTask.bind(
-        null,
-        priorityLevel,
-        postTaskPriority,
-        node,
-        result
-      );
+      var continuationOptions = { signal: node._controller.signal },
+        nextTask = runTask.bind(
+          null,
+          priorityLevel,
+          postTaskPriority,
+          node,
+          result
+        );
       void 0 !== scheduler.yield
         ? scheduler
             .yield(continuationOptions)
diff --git a/compiled/facebook-www/SchedulerPostTask-profiling.classic.js b/compiled/facebook-www/SchedulerPostTask-profiling.classic.js
@@ -23,18 +23,14 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     currentPriorityLevel_DEPRECATED = priorityLevel;
     var result = callback(!1);
     if ("function" === typeof result) {
-      var continuationController = new TaskController({
-          priority: postTaskPriority
-        }),
-        continuationOptions = { signal: continuationController.signal };
-      node._controller = continuationController;
-      var nextTask = runTask.bind(
-        null,
-        priorityLevel,
-        postTaskPriority,
-        node,
-        result
-      );
+      var continuationOptions = { signal: node._controller.signal },
+        nextTask = runTask.bind(
+          null,
+          priorityLevel,
+          postTaskPriority,
+          node,
+          result
+        );
       void 0 !== scheduler.yield
         ? scheduler
             .yield(continuationOptions)
diff --git a/compiled/facebook-www/SchedulerPostTask-profiling.modern.js b/compiled/facebook-www/SchedulerPostTask-profiling.modern.js
@@ -23,18 +23,14 @@ function runTask(priorityLevel, postTaskPriority, node, callback) {
     currentPriorityLevel_DEPRECATED = priorityLevel;
     var result = callback(!1);
     if ("function" === typeof result) {
-      var continuationController = new TaskController({
-          priority: postTaskPriority
-        }),
-        continuationOptions = { signal: continuationController.signal };
-      node._controller = continuationController;
-      var nextTask = runTask.bind(
-        null,
-        priorityLevel,
-        postTaskPriority,
-        node,
-        result
-      );
+      var continuationOptions = { signal: node._controller.signal },
+        nextTask = runTask.bind(
+          null,
+          priorityLevel,
+          postTaskPriority,
+          node,
+          result
+        );
       void 0 !== scheduler.yield
         ? scheduler
             .yield(continuationOptions)

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-6bfc0e032acc7e5ad6da2a09f3c4f47f3321da2c`
	`1`	`+a17467e7e2cd8947c595d1834889b5d184459f12`