Skip to content

Commit 5f796aa

Browse files
author
Brian Vaughn
committed
Updated tests
1 parent 8a0e2ab commit 5f796aa

File tree

61 files changed

+325
-562
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+325
-562
lines changed

‎packages/create-subscription/src/__tests__/createSubscription-test.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ describe('createSubscription', () => {
268268
expect(Scheduler).toFlushAndYield(['b-1']);
269269
});
270270

271-
// @gate experimental || !enableSyncDefaultUpdates
272271
it('should ignore values emitted by a new subscribable until the commit phase', () => {
273272
const log = [];
274273

@@ -327,7 +326,7 @@ describe('createSubscription', () => {
327326

328327
// Start React update, but don't finish
329328
if (gate(flags => flags.enableSyncDefaultUpdates)) {
330-
React.unstable_startTransition(() => {
329+
React.startTransition(() => {
331330
ReactNoop.render(<Parent observed={observableB} />);
332331
});
333332
} else {
@@ -362,7 +361,6 @@ describe('createSubscription', () => {
362361
]);
363362
});
364363

365-
// @gate experimental || !enableSyncDefaultUpdates
366364
it('should not drop values emitted between updates', () => {
367365
const log = [];
368366

@@ -421,7 +419,7 @@ describe('createSubscription', () => {
421419

422420
// Start React update, but don't finish
423421
if (gate(flags => flags.enableSyncDefaultUpdates)) {
424-
React.unstable_startTransition(() => {
422+
React.startTransition(() => {
425423
ReactNoop.render(<Parent observed={observableB} />);
426424
});
427425
} else {

‎packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ describe('ReactHooksInspectionIntegration', () => {
369369
// @gate experimental
370370
it('should support composite useTransition hook', () => {
371371
function Foo(props) {
372-
React.unstable_useTransition();
372+
React.useTransition();
373373
const memoizedValue = React.useMemo(() => 'hello', []);
374374
return <div>{memoizedValue}</div>;
375375
}
@@ -394,10 +394,9 @@ describe('ReactHooksInspectionIntegration', () => {
394394
]);
395395
});
396396

397-
// @gate experimental
398397
it('should support composite useDeferredValue hook', () => {
399398
function Foo(props) {
400-
React.unstable_useDeferredValue('abc', {
399+
React.useDeferredValue('abc', {
401400
timeoutMs: 500,
402401
});
403402
const [state] = React.useState(() => 'hello', []);
@@ -424,7 +423,6 @@ describe('ReactHooksInspectionIntegration', () => {
424423
]);
425424
});
426425

427-
// @gate experimental
428426
it('should support composite useOpaqueIdentifier hook', () => {
429427
function Foo(props) {
430428
const id = React.unstable_useOpaqueIdentifier();
@@ -452,7 +450,6 @@ describe('ReactHooksInspectionIntegration', () => {
452450
});
453451
});
454452

455-
// @gate experimental
456453
it('should support composite useOpaqueIdentifier hook in concurrent mode', () => {
457454
function Foo(props) {
458455
const id = React.unstable_useOpaqueIdentifier();
@@ -848,9 +845,9 @@ describe('ReactHooksInspectionIntegration', () => {
848845

849846
if (__EXPERIMENTAL__) {
850847
it('should support composite useMutableSource hook', () => {
851-
const mutableSource = React.unstable_createMutableSource({}, () => 1);
848+
const mutableSource = React.createMutableSource({}, () => 1);
852849
function Foo(props) {
853-
React.unstable_useMutableSource(
850+
React.useMutableSource(
854851
mutableSource,
855852
() => 'snapshot',
856853
() => {},

‎packages/react-devtools-core/src/standalone.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
// $FlowFixMe Flow does not yet know about flushSync()
1313
flushSync,
1414
// $FlowFixMe Flow does not yet know about createRoot()
15-
unstable_createRoot as createRoot,
15+
createRoot,
1616
} from 'react-dom';
1717
import Bridge from 'react-devtools-shared/src/bridge';
1818
import Store from 'react-devtools-shared/src/devtools/store';

‎packages/react-devtools-extensions/src/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* global chrome */
22

33
import {createElement} from 'react';
4-
import {unstable_createRoot as createRoot, flushSync} from 'react-dom';
4+
import {createRoot, flushSync} from 'react-dom';
55
import Bridge from 'react-devtools-shared/src/bridge';
66
import Store from 'react-devtools-shared/src/devtools/store';
77
import {getBrowserName, getBrowserTheme} from './utils';

‎packages/react-devtools-scheduling-profiler/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import 'regenerator-runtime/runtime';
1111

1212
import * as React from 'react';
1313
// $FlowFixMe Flow does not yet know about createRoot()
14-
import {unstable_createRoot as createRoot} from 'react-dom';
14+
import {createRoot} from 'react-dom';
1515
import nullthrows from 'nullthrows';
1616
import App from './App';
1717

‎packages/react-devtools-shared/src/__tests__/profilingCommitTreeBuilder-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ describe('commit tree', () => {
149149

150150
it('should support Lazy components (createRoot)', async () => {
151151
const container = document.createElement('div');
152-
const root = ReactDOM.unstable_createRoot(container);
152+
const root = ReactDOM.createRoot(container);
153153

154154
utils.act(() => store.profilerStore.startProfiling());
155155
utils.act(() => root.render(<App renderChildren={true} />));
@@ -226,7 +226,7 @@ describe('commit tree', () => {
226226

227227
it('should support Lazy components that are unmounted before resolving (createRoot)', async () => {
228228
const container = document.createElement('div');
229-
const root = ReactDOM.unstable_createRoot(container);
229+
const root = ReactDOM.createRoot(container);
230230

231231
utils.act(() => store.profilerStore.startProfiling());
232232
utils.act(() => root.render(<App renderChildren={true} />));

‎packages/react-devtools-shared/src/__tests__/profilingHostRoot-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ describe('profiling HostRoot', () => {
8989
utils.act(() => store.profilerStore.startProfiling());
9090
utils.act(() => {
9191
const container = document.createElement('div');
92-
const root = ReactDOM.unstable_createRoot(container);
92+
const root = ReactDOM.createRoot(container);
9393
root.render(<App />);
9494
});
9595
utils.act(() => store.profilerStore.stopProfiling());
@@ -122,7 +122,7 @@ describe('profiling HostRoot', () => {
122122
}
123123

124124
const container = document.createElement('div');
125-
const root = ReactDOM.unstable_createRoot(container);
125+
const root = ReactDOM.createRoot(container);
126126

127127
utils.act(() => store.profilerStore.startProfiling());
128128
utils.act(() => root.render(<App />));

‎packages/react-devtools-shared/src/__tests__/store-test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -356,18 +356,18 @@ describe('Store', () => {
356356
};
357357
const Wrapper = ({shouldSuspense}) => (
358358
<React.Fragment>
359-
<React.unstable_SuspenseList revealOrder="forwards" tail="collapsed">
359+
<React.SuspenseList revealOrder="forwards" tail="collapsed">
360360
<Component key="A" />
361361
<React.Suspense fallback={<Loading />}>
362362
{shouldSuspense ? <SuspendingComponent /> : <Component key="B" />}
363363
</React.Suspense>
364364
<Component key="C" />
365-
</React.unstable_SuspenseList>
365+
</React.SuspenseList>
366366
</React.Fragment>
367367
);
368368

369369
const container = document.createElement('div');
370-
const root = ReactDOM.unstable_createRoot(container);
370+
const root = ReactDOM.createRoot(container);
371371
act(() => {
372372
root.render(<Wrapper shouldSuspense={true} />);
373373
});
@@ -984,7 +984,7 @@ describe('Store', () => {
984984

985985
it('should support Lazy components in (createRoot)', async () => {
986986
const container = document.createElement('div');
987-
const root = ReactDOM.unstable_createRoot(container);
987+
const root = ReactDOM.createRoot(container);
988988

989989
// Render once to start fetching the lazy component
990990
act(() => root.render(<App renderChildren={true} />));
@@ -1020,7 +1020,7 @@ describe('Store', () => {
10201020

10211021
it('should support Lazy components that are unmounted before they finish loading in (createRoot)', async () => {
10221022
const container = document.createElement('div');
1023-
const root = ReactDOM.unstable_createRoot(container);
1023+
const root = ReactDOM.createRoot(container);
10241024

10251025
// Render once to start fetching the lazy component
10261026
act(() => root.render(<App renderChildren={true} />));

‎packages/react-devtools-shared/src/__tests__/storeStressTestConcurrent-test.js

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('StoreStressConcurrent', () => {
6767
// 1. Render a normal version of [a, b, c, d, e].
6868
let container = document.createElement('div');
6969
// $FlowFixMe
70-
let root = ReactDOM.unstable_createRoot(container);
70+
let root = ReactDOM.createRoot(container);
7171
act(() => root.render(<Parent>{[a, b, c, d, e]}</Parent>));
7272
expect(store).toMatchInlineSnapshot(
7373
`
@@ -151,7 +151,7 @@ describe('StoreStressConcurrent', () => {
151151
// Ensure fresh mount.
152152
container = document.createElement('div');
153153
// $FlowFixMe
154-
root = ReactDOM.unstable_createRoot(container);
154+
root = ReactDOM.createRoot(container);
155155

156156
// Verify mounting 'abcde'.
157157
act(() => root.render(<Parent>{cases[i]}</Parent>));
@@ -181,7 +181,7 @@ describe('StoreStressConcurrent', () => {
181181
// There'll be no unmounting until the very end.
182182
container = document.createElement('div');
183183
// $FlowFixMe
184-
root = ReactDOM.unstable_createRoot(container);
184+
root = ReactDOM.createRoot(container);
185185
for (let i = 0; i < cases.length; i++) {
186186
// Verify mounting 'abcde'.
187187
act(() => root.render(<Parent>{cases[i]}</Parent>));
@@ -247,7 +247,7 @@ describe('StoreStressConcurrent', () => {
247247
const snapshots = [];
248248
let container = document.createElement('div');
249249
// $FlowFixMe
250-
let root = ReactDOM.unstable_createRoot(container);
250+
let root = ReactDOM.createRoot(container);
251251
for (let i = 0; i < steps.length; i++) {
252252
act(() => root.render(<Root>{steps[i]}</Root>));
253253
// We snapshot each step once so it doesn't regress.
@@ -320,7 +320,7 @@ describe('StoreStressConcurrent', () => {
320320
for (let j = 0; j < steps.length; j++) {
321321
container = document.createElement('div');
322322
// $FlowFixMe
323-
root = ReactDOM.unstable_createRoot(container);
323+
root = ReactDOM.createRoot(container);
324324
act(() => root.render(<Root>{steps[i]}</Root>));
325325
expect(print(store)).toMatch(snapshots[i]);
326326
act(() => root.render(<Root>{steps[j]}</Root>));
@@ -337,7 +337,7 @@ describe('StoreStressConcurrent', () => {
337337
for (let j = 0; j < steps.length; j++) {
338338
container = document.createElement('div');
339339
// $FlowFixMe
340-
root = ReactDOM.unstable_createRoot(container);
340+
root = ReactDOM.createRoot(container);
341341
act(() =>
342342
root.render(
343343
<Root>
@@ -409,7 +409,7 @@ describe('StoreStressConcurrent', () => {
409409
const snapshots = [];
410410
let container = document.createElement('div');
411411
// $FlowFixMe
412-
let root = ReactDOM.unstable_createRoot(container);
412+
let root = ReactDOM.createRoot(container);
413413
for (let i = 0; i < steps.length; i++) {
414414
act(() =>
415415
root.render(
@@ -536,7 +536,7 @@ describe('StoreStressConcurrent', () => {
536536
// Always start with a fresh container and steps[i].
537537
container = document.createElement('div');
538538
// $FlowFixMe
539-
root = ReactDOM.unstable_createRoot(container);
539+
root = ReactDOM.createRoot(container);
540540
act(() =>
541541
root.render(
542542
<Root>
@@ -582,7 +582,7 @@ describe('StoreStressConcurrent', () => {
582582
// Always start with a fresh container and steps[i].
583583
container = document.createElement('div');
584584
// $FlowFixMe
585-
root = ReactDOM.unstable_createRoot(container);
585+
root = ReactDOM.createRoot(container);
586586
act(() =>
587587
root.render(
588588
<Root>
@@ -640,7 +640,7 @@ describe('StoreStressConcurrent', () => {
640640
// Always start with a fresh container and steps[i].
641641
container = document.createElement('div');
642642
// $FlowFixMe
643-
root = ReactDOM.unstable_createRoot(container);
643+
root = ReactDOM.createRoot(container);
644644
act(() =>
645645
root.render(
646646
<Root>
@@ -690,7 +690,7 @@ describe('StoreStressConcurrent', () => {
690690
// Always start with a fresh container and steps[i].
691691
container = document.createElement('div');
692692
// $FlowFixMe
693-
root = ReactDOM.unstable_createRoot(container);
693+
root = ReactDOM.createRoot(container);
694694
act(() =>
695695
root.render(
696696
<Root>
@@ -744,7 +744,7 @@ describe('StoreStressConcurrent', () => {
744744
// Always start with a fresh container and steps[i].
745745
container = document.createElement('div');
746746
// $FlowFixMe
747-
root = ReactDOM.unstable_createRoot(container);
747+
root = ReactDOM.createRoot(container);
748748
act(() =>
749749
root.render(
750750
<Root>
@@ -898,7 +898,7 @@ describe('StoreStressConcurrent', () => {
898898
const snapshots = [];
899899
let container = document.createElement('div');
900900
// $FlowFixMe
901-
let root = ReactDOM.unstable_createRoot(container);
901+
let root = ReactDOM.createRoot(container);
902902
for (let i = 0; i < steps.length; i++) {
903903
act(() =>
904904
root.render(
@@ -1055,7 +1055,7 @@ describe('StoreStressConcurrent', () => {
10551055
// Always start with a fresh container and steps[i].
10561056
container = document.createElement('div');
10571057
// $FlowFixMe
1058-
root = ReactDOM.unstable_createRoot(container);
1058+
root = ReactDOM.createRoot(container);
10591059
act(() =>
10601060
root.render(
10611061
<Root>
@@ -1107,7 +1107,7 @@ describe('StoreStressConcurrent', () => {
11071107
// Always start with a fresh container and steps[i].
11081108
container = document.createElement('div');
11091109
// $FlowFixMe
1110-
root = ReactDOM.unstable_createRoot(container);
1110+
root = ReactDOM.createRoot(container);
11111111
act(() =>
11121112
root.render(
11131113
<Root>
@@ -1174,7 +1174,7 @@ describe('StoreStressConcurrent', () => {
11741174
// Always start with a fresh container and steps[i].
11751175
container = document.createElement('div');
11761176
// $FlowFixMe
1177-
root = ReactDOM.unstable_createRoot(container);
1177+
root = ReactDOM.createRoot(container);
11781178
act(() =>
11791179
root.render(
11801180
<Root>
@@ -1226,7 +1226,7 @@ describe('StoreStressConcurrent', () => {
12261226
// Always start with a fresh container and steps[i].
12271227
container = document.createElement('div');
12281228
// $FlowFixMe
1229-
root = ReactDOM.unstable_createRoot(container);
1229+
root = ReactDOM.createRoot(container);
12301230
act(() =>
12311231
root.render(
12321232
<Root>
@@ -1278,7 +1278,7 @@ describe('StoreStressConcurrent', () => {
12781278
// Always start with a fresh container and steps[i].
12791279
container = document.createElement('div');
12801280
// $FlowFixMe
1281-
root = ReactDOM.unstable_createRoot(container);
1281+
root = ReactDOM.createRoot(container);
12821282
act(() =>
12831283
root.render(
12841284
<Root>

‎packages/react-devtools-shell/src/devtools.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import {createElement} from 'react';
44
// $FlowFixMe Flow does not yet know about createRoot()
5-
import {unstable_createRoot as createRoot} from 'react-dom';
5+
import {createRoot} from 'react-dom';
66
import {
77
activate as activateBackend,
88
initialize as initializeBackend,

0 commit comments

Comments
 (0)