Commit 56c48f7
committed
[Fizz] Postponing in the shell (#27569)
When we postpone a prerender in the shell, we should just leave an empty
prelude and resume from the root. While preserving any options passed
in.
Since we haven't flushed anything we can't assume we've already emitted
html/body tags or any resources tracked in the resumable state. This
introduces a resetResumableState function to reset anything we didn't
flush.
This is a bit hacky. Ideally, we probably shouldn't have tracked it as
already happened until it flushed or something like that.
Basically, it's like restarting the prerender with the same options and
then immediately aborting. When we add the preload headers, we'd track
those as preload() being emitted after the reset and so they get readded
to the resumable state in that case.
DiffTrain build for commit 05fbd1a.1 parent d763d10 commit 56c48f7
File tree
7 files changed
+9
-9
lines changed- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
7 files changed
+9
-9
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24887 | 24887 | | |
24888 | 24888 | | |
24889 | 24889 | | |
24890 | | - | |
| 24890 | + | |
24891 | 24891 | | |
24892 | 24892 | | |
24893 | 24893 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9024 | 9024 | | |
9025 | 9025 | | |
9026 | 9026 | | |
9027 | | - | |
| 9027 | + | |
9028 | 9028 | | |
9029 | 9029 | | |
9030 | 9030 | | |
| |||
9055 | 9055 | | |
9056 | 9056 | | |
9057 | 9057 | | |
9058 | | - | |
| 9058 | + | |
9059 | 9059 | | |
9060 | 9060 | | |
9061 | 9061 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9450 | 9450 | | |
9451 | 9451 | | |
9452 | 9452 | | |
9453 | | - | |
| 9453 | + | |
9454 | 9454 | | |
9455 | 9455 | | |
9456 | 9456 | | |
| |||
9481 | 9481 | | |
9482 | 9482 | | |
9483 | 9483 | | |
9484 | | - | |
| 9484 | + | |
9485 | 9485 | | |
9486 | 9486 | | |
9487 | 9487 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
580 | 580 | | |
581 | 581 | | |
582 | 582 | | |
583 | | - | |
| 583 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
583 | 583 | | |
584 | 584 | | |
585 | 585 | | |
586 | | - | |
| 586 | + | |
587 | 587 | | |
588 | 588 | | |
589 | 589 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments