Skip to content

Commit 55c52b1

Browse files
committed
Regression test: Stylesheet suspends indefinitely when part of error boundary UI during initial hydration (#27258)
Adds a failing test for a case discovered by Next.js. An error boundary is triggered during initial hydration, and the error fallback includes a stylesheet. If the stylesheet has not yet been loaded, the commit suspends, but never resolves even after the stylesheet finishes loading. Triggering this bug depends on several very specific code paths being triggered simultaneously. There are a few ways we could fix the bug; I'll submit as one or more separate PRs to show that each one is sufficient. DiffTrain build for commit 7d1c3c1.
1 parent 3a83dba commit 55c52b1

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23966,7 +23966,7 @@ function createFiberRoot(
2396623966
return root;
2396723967
}
2396823968

23969-
var ReactVersion = "18.3.0-canary-b27725923-20230821";
23969+
var ReactVersion = "18.3.0-canary-7d1c3c158-20230821";
2397023970

2397123971
// Might add PROFILE later.
2397223972

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8615,7 +8615,7 @@ var devToolsConfig$jscomp$inline_1029 = {
86158615
throw Error("TestRenderer does not support findFiberByHostInstance()");
86168616
},
86178617
bundleType: 0,
8618-
version: "18.3.0-canary-b27725923-20230821",
8618+
version: "18.3.0-canary-7d1c3c158-20230821",
86198619
rendererPackageName: "react-test-renderer"
86208620
};
86218621
var internals$jscomp$inline_1228 = {
@@ -8646,7 +8646,7 @@ var internals$jscomp$inline_1228 = {
86468646
scheduleRoot: null,
86478647
setRefreshHandler: null,
86488648
getCurrentFiber: null,
8649-
reconcilerVersion: "18.3.0-canary-b27725923-20230821"
8649+
reconcilerVersion: "18.3.0-canary-7d1c3c158-20230821"
86508650
};
86518651
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86528652
var hook$jscomp$inline_1229 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9041,7 +9041,7 @@ var devToolsConfig$jscomp$inline_1071 = {
90419041
throw Error("TestRenderer does not support findFiberByHostInstance()");
90429042
},
90439043
bundleType: 0,
9044-
version: "18.3.0-canary-b27725923-20230821",
9044+
version: "18.3.0-canary-7d1c3c158-20230821",
90459045
rendererPackageName: "react-test-renderer"
90469046
};
90479047
var internals$jscomp$inline_1269 = {
@@ -9072,7 +9072,7 @@ var internals$jscomp$inline_1269 = {
90729072
scheduleRoot: null,
90739073
setRefreshHandler: null,
90749074
getCurrentFiber: null,
9075-
reconcilerVersion: "18.3.0-canary-b27725923-20230821"
9075+
reconcilerVersion: "18.3.0-canary-7d1c3c158-20230821"
90769076
};
90779077
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90789078
var hook$jscomp$inline_1270 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-b27725923-20230821";
30+
var ReactVersion = "18.3.0-canary-7d1c3c158-20230821";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,4 +616,4 @@ exports.useSyncExternalStore = function (
616616
exports.useTransition = function () {
617617
return ReactCurrentDispatcher.current.useTransition();
618618
};
619-
exports.version = "18.3.0-canary-b27725923-20230821";
619+
exports.version = "18.3.0-canary-7d1c3c158-20230821";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ exports.useSyncExternalStore = function (
619619
exports.useTransition = function () {
620620
return ReactCurrentDispatcher.current.useTransition();
621621
};
622-
exports.version = "18.3.0-canary-b27725923-20230821";
622+
exports.version = "18.3.0-canary-7d1c3c158-20230821";
623623

624624
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
625625
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b2772592321db426a81d52becea9dc86394afe29
1+
7d1c3c15892d8c31c7ca4661f601c41d8541fa8c

0 commit comments

Comments
 (0)