Skip to content

Commit 5426af3

Browse files
authored
Provide icon to edge devtools. (#26543)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Addresses #26352. This PR explicitly passes an icon to `chrome.devtools.panels.create()`, so that edge devtools will display the icon when in [Focus Mode](https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/experimental-features/focus-mode). <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? Passing test suite (`yarn test` & `yarn test --prod`) ✅ Passing lint (`yarn linc`) ✅ Passing type checks (`yarn flow`) ✅ **Visual Testing** Before Changes | After Changes :-------------------------:|:-------------------------: ![](https://user-images.githubusercontent.com/15645169/229591145-fe99df06-e2e3-4f21-ae31-f770d584ca6c.png) | ![](https://user-images.githubusercontent.com/15645169/229591594-26c6cbaf-f345-4367-b234-8f3c8ab3ccb1.png) <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
1 parent f9de24a commit 5426af3

File tree

1 file changed

+2
-2
lines changed
  • packages/react-devtools-extensions/src

1 file changed

+2
-2
lines changed

packages/react-devtools-extensions/src/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ function createPanelIfReactLoaded() {
475475

476476
chrome.devtools.panels.create(
477477
IS_CHROME || IS_EDGE ? '⚛️ Components' : 'Components',
478-
'',
478+
IS_EDGE ? 'icons/production.svg' : '',
479479
'panel.html',
480480
extensionPanel => {
481481
extensionPanel.onShown.addListener(panel => {
@@ -506,7 +506,7 @@ function createPanelIfReactLoaded() {
506506

507507
chrome.devtools.panels.create(
508508
IS_CHROME || IS_EDGE ? '⚛️ Profiler' : 'Profiler',
509-
'',
509+
IS_EDGE ? 'icons/production.svg' : '',
510510
'panel.html',
511511
extensionPanel => {
512512
extensionPanel.onShown.addListener(panel => {

0 commit comments

Comments
 (0)