Skip to content

Commit 533b5a9

Browse files
sebmarkbagesebmarkbage
committed
[Fiber] Trigger default indicator for isomorphic async actions with no root associated (#33190)
Stacked on #33160, #33162, #33186 and #33188. We have a special case that's awkward for default indicators. When you start a new async Transition from `React.startTransition` then there's not yet any associated root with the Transition because you haven't necessarily `setState` on anything yet until the promise resolves. That's what `entangleAsyncAction` handles by creating a lane that everything entangles with until all async actions are done. If there are no sync updates before the end of the event, we should trigger a default indicator until either the async action completes without update or if it gets entangled with some roots we should keep it going until those roots are done. DiffTrain build for [3a5b326](3a5b326)
1 parent 9c65b7e commit 533b5a9

24 files changed

+449
-449
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-59440424-20250513
1+
19.2.0-native-fb-3a5b326d-20250513

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<dec5042bc5f03cc4b5905cbafac45d5d>>
10+
* @generated SignedSource<<0a7b41fab34de0b1e461be707a0c0381>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-59440424-20250513";
407+
exports.version = "19.2.0-native-fb-3a5b326d-20250513";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2e17e4696030242c7e8aced13f53e62a>>
10+
* @generated SignedSource<<234e30397ebef552695a599d72f3453c>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-59440424-20250513";
206+
exports.version = "19.2.0-native-fb-3a5b326d-20250513";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2e17e4696030242c7e8aced13f53e62a>>
10+
* @generated SignedSource<<234e30397ebef552695a599d72f3453c>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-59440424-20250513";
206+
exports.version = "19.2.0-native-fb-3a5b326d-20250513";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 119 additions & 119 deletions
Large diffs are not rendered by default.

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5bd08c285c559e1d555ed66bced9133a>>
10+
* @generated SignedSource<<0bd1930d33a754a98f8f9076a5d36193>>
1111
*/
1212

1313
/*
@@ -12965,20 +12965,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1296512965
(nativeEventTarget[internalScrollTimer] = targetInst));
1296612966
}
1296712967
for (
12968-
var i$jscomp$inline_1640 = 0;
12969-
i$jscomp$inline_1640 < simpleEventPluginEvents.length;
12970-
i$jscomp$inline_1640++
12968+
var i$jscomp$inline_1641 = 0;
12969+
i$jscomp$inline_1641 < simpleEventPluginEvents.length;
12970+
i$jscomp$inline_1641++
1297112971
) {
12972-
var eventName$jscomp$inline_1641 =
12973-
simpleEventPluginEvents[i$jscomp$inline_1640],
12974-
domEventName$jscomp$inline_1642 =
12975-
eventName$jscomp$inline_1641.toLowerCase(),
12976-
capitalizedEvent$jscomp$inline_1643 =
12977-
eventName$jscomp$inline_1641[0].toUpperCase() +
12978-
eventName$jscomp$inline_1641.slice(1);
12972+
var eventName$jscomp$inline_1642 =
12973+
simpleEventPluginEvents[i$jscomp$inline_1641],
12974+
domEventName$jscomp$inline_1643 =
12975+
eventName$jscomp$inline_1642.toLowerCase(),
12976+
capitalizedEvent$jscomp$inline_1644 =
12977+
eventName$jscomp$inline_1642[0].toUpperCase() +
12978+
eventName$jscomp$inline_1642.slice(1);
1297912979
registerSimpleEvent(
12980-
domEventName$jscomp$inline_1642,
12981-
"on" + capitalizedEvent$jscomp$inline_1643
12980+
domEventName$jscomp$inline_1643,
12981+
"on" + capitalizedEvent$jscomp$inline_1644
1298212982
);
1298312983
}
1298412984
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -17092,16 +17092,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1709217092
0 === i && attemptExplicitHydrationTarget(target);
1709317093
}
1709417094
};
17095-
var isomorphicReactPackageVersion$jscomp$inline_2015 = React.version;
17095+
var isomorphicReactPackageVersion$jscomp$inline_2017 = React.version;
1709617096
if (
17097-
"19.2.0-native-fb-59440424-20250513" !==
17098-
isomorphicReactPackageVersion$jscomp$inline_2015
17097+
"19.2.0-native-fb-3a5b326d-20250513" !==
17098+
isomorphicReactPackageVersion$jscomp$inline_2017
1709917099
)
1710017100
throw Error(
1710117101
formatProdErrorMessage(
1710217102
527,
17103-
isomorphicReactPackageVersion$jscomp$inline_2015,
17104-
"19.2.0-native-fb-59440424-20250513"
17103+
isomorphicReactPackageVersion$jscomp$inline_2017,
17104+
"19.2.0-native-fb-3a5b326d-20250513"
1710517105
)
1710617106
);
1710717107
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17121,24 +17121,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1712117121
null === componentOrElement ? null : componentOrElement.stateNode;
1712217122
return componentOrElement;
1712317123
};
17124-
var internals$jscomp$inline_2534 = {
17124+
var internals$jscomp$inline_2536 = {
1712517125
bundleType: 0,
17126-
version: "19.2.0-native-fb-59440424-20250513",
17126+
version: "19.2.0-native-fb-3a5b326d-20250513",
1712717127
rendererPackageName: "react-dom",
1712817128
currentDispatcherRef: ReactSharedInternals,
17129-
reconcilerVersion: "19.2.0-native-fb-59440424-20250513"
17129+
reconcilerVersion: "19.2.0-native-fb-3a5b326d-20250513"
1713017130
};
1713117131
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
17132-
var hook$jscomp$inline_2535 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
17132+
var hook$jscomp$inline_2537 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1713317133
if (
17134-
!hook$jscomp$inline_2535.isDisabled &&
17135-
hook$jscomp$inline_2535.supportsFiber
17134+
!hook$jscomp$inline_2537.isDisabled &&
17135+
hook$jscomp$inline_2537.supportsFiber
1713617136
)
1713717137
try {
17138-
(rendererID = hook$jscomp$inline_2535.inject(
17139-
internals$jscomp$inline_2534
17138+
(rendererID = hook$jscomp$inline_2537.inject(
17139+
internals$jscomp$inline_2536
1714017140
)),
17141-
(injectedHook = hook$jscomp$inline_2535);
17141+
(injectedHook = hook$jscomp$inline_2537);
1714217142
} catch (err) {}
1714317143
}
1714417144
exports.createRoot = function (container, options) {
@@ -17224,4 +17224,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1722417224
listenToAllSupportedEvents(container);
1722517225
return new ReactDOMHydrationRoot(initialChildren);
1722617226
};
17227-
exports.version = "19.2.0-native-fb-59440424-20250513";
17227+
exports.version = "19.2.0-native-fb-3a5b326d-20250513";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7e1f32d8db4f8fd1ee8f002787de4b01>>
10+
* @generated SignedSource<<f32632a054b974ffa2b777d535552a43>>
1111
*/
1212

1313
/*
@@ -13667,20 +13667,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1366713667
(nativeEventTarget[internalScrollTimer] = targetInst));
1366813668
}
1366913669
for (
13670-
var i$jscomp$inline_1741 = 0;
13671-
i$jscomp$inline_1741 < simpleEventPluginEvents.length;
13672-
i$jscomp$inline_1741++
13670+
var i$jscomp$inline_1742 = 0;
13671+
i$jscomp$inline_1742 < simpleEventPluginEvents.length;
13672+
i$jscomp$inline_1742++
1367313673
) {
13674-
var eventName$jscomp$inline_1742 =
13675-
simpleEventPluginEvents[i$jscomp$inline_1741],
13676-
domEventName$jscomp$inline_1743 =
13677-
eventName$jscomp$inline_1742.toLowerCase(),
13678-
capitalizedEvent$jscomp$inline_1744 =
13679-
eventName$jscomp$inline_1742[0].toUpperCase() +
13680-
eventName$jscomp$inline_1742.slice(1);
13674+
var eventName$jscomp$inline_1743 =
13675+
simpleEventPluginEvents[i$jscomp$inline_1742],
13676+
domEventName$jscomp$inline_1744 =
13677+
eventName$jscomp$inline_1743.toLowerCase(),
13678+
capitalizedEvent$jscomp$inline_1745 =
13679+
eventName$jscomp$inline_1743[0].toUpperCase() +
13680+
eventName$jscomp$inline_1743.slice(1);
1368113681
registerSimpleEvent(
13682-
domEventName$jscomp$inline_1743,
13683-
"on" + capitalizedEvent$jscomp$inline_1744
13682+
domEventName$jscomp$inline_1744,
13683+
"on" + capitalizedEvent$jscomp$inline_1745
1368413684
);
1368513685
}
1368613686
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -17802,16 +17802,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1780217802
0 === i && attemptExplicitHydrationTarget(target);
1780317803
}
1780417804
};
17805-
var isomorphicReactPackageVersion$jscomp$inline_2118 = React.version;
17805+
var isomorphicReactPackageVersion$jscomp$inline_2120 = React.version;
1780617806
if (
17807-
"19.2.0-native-fb-59440424-20250513" !==
17808-
isomorphicReactPackageVersion$jscomp$inline_2118
17807+
"19.2.0-native-fb-3a5b326d-20250513" !==
17808+
isomorphicReactPackageVersion$jscomp$inline_2120
1780917809
)
1781017810
throw Error(
1781117811
formatProdErrorMessage(
1781217812
527,
17813-
isomorphicReactPackageVersion$jscomp$inline_2118,
17814-
"19.2.0-native-fb-59440424-20250513"
17813+
isomorphicReactPackageVersion$jscomp$inline_2120,
17814+
"19.2.0-native-fb-3a5b326d-20250513"
1781517815
)
1781617816
);
1781717817
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17831,12 +17831,12 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1783117831
null === componentOrElement ? null : componentOrElement.stateNode;
1783217832
return componentOrElement;
1783317833
};
17834-
var internals$jscomp$inline_2125 = {
17834+
var internals$jscomp$inline_2127 = {
1783517835
bundleType: 0,
17836-
version: "19.2.0-native-fb-59440424-20250513",
17836+
version: "19.2.0-native-fb-3a5b326d-20250513",
1783717837
rendererPackageName: "react-dom",
1783817838
currentDispatcherRef: ReactSharedInternals,
17839-
reconcilerVersion: "19.2.0-native-fb-59440424-20250513",
17839+
reconcilerVersion: "19.2.0-native-fb-3a5b326d-20250513",
1784017840
getLaneLabelMap: function () {
1784117841
for (
1784217842
var map = new Map(), lane = 1, index$313 = 0;
@@ -17854,16 +17854,16 @@ var internals$jscomp$inline_2125 = {
1785417854
}
1785517855
};
1785617856
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
17857-
var hook$jscomp$inline_2602 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
17857+
var hook$jscomp$inline_2604 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1785817858
if (
17859-
!hook$jscomp$inline_2602.isDisabled &&
17860-
hook$jscomp$inline_2602.supportsFiber
17859+
!hook$jscomp$inline_2604.isDisabled &&
17860+
hook$jscomp$inline_2604.supportsFiber
1786117861
)
1786217862
try {
17863-
(rendererID = hook$jscomp$inline_2602.inject(
17864-
internals$jscomp$inline_2125
17863+
(rendererID = hook$jscomp$inline_2604.inject(
17864+
internals$jscomp$inline_2127
1786517865
)),
17866-
(injectedHook = hook$jscomp$inline_2602);
17866+
(injectedHook = hook$jscomp$inline_2604);
1786717867
} catch (err) {}
1786817868
}
1786917869
exports.createRoot = function (container, options) {
@@ -17949,4 +17949,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1794917949
listenToAllSupportedEvents(container);
1795017950
return new ReactDOMHydrationRoot(initialChildren);
1795117951
};
17952-
exports.version = "19.2.0-native-fb-59440424-20250513";
17952+
exports.version = "19.2.0-native-fb-3a5b326d-20250513";

0 commit comments

Comments
 (0)