From 4d45e7eace2784feaf41d2bbd9315a85bf5e3df5 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 13 Feb 2019 18:58:31 +0000 Subject: [PATCH] Fix the first test --- .../__tests__/ESLintRuleReactiveDeps-test.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleReactiveDeps-test.js b/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleReactiveDeps-test.js index 77ced25939d04..ead781affac77 100644 --- a/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleReactiveDeps-test.js +++ b/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleReactiveDeps-test.js @@ -215,6 +215,7 @@ eslintTester.run('react-hooks', ReactHooksESLintRule, { invalid: [ { code: ` + /*only*/ function MyComponent() { const local = 42; useEffect(() => { @@ -222,7 +223,18 @@ eslintTester.run('react-hooks', ReactHooksESLintRule, { }, []); } `, - errors: [missingError('local')], + output: ` + /*only*/ + function MyComponent() { + const local = 42; + useEffect(() => { + console.log(local); + }, [local]); + } + `, + errors: [ + 'React Hook useEffect has missing [local] dependencies. Either fix or remove the dependency array.' + ], }, { code: `