Skip to content

Commit 4c48f1f

Browse files
javachejavache
committed
[react-native] Fix misleading crash when view config is not found (#30970)
## Summary When a view config can not be found, it currently errors with `TypeError: Cannot read property 'bubblingEventTypes' of null`. Instead invariant at the correct location and prevent further processing of the null viewConfig to improve the error logged. ## How did you test this change? Build and run RN playground app referencing an invalid native view through `requireNativeComponent`. DiffTrain build for commit 26855e4.
1 parent 4c73996 commit 4c48f1f

File tree

15 files changed

+49
-50
lines changed

15 files changed

+49
-50
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-f2df5694-20240916
1+
19.0.0-native-fb-26855e46-20240916

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<40679ac3de121003b93c964de30bcf93>>
10+
* @generated SignedSource<<f8a96fa0f2e72cb61ce052e8a5718a5b>>
1111
*/
1212

1313
"use strict";
@@ -15131,11 +15131,11 @@ __DEV__ &&
1513115131
(function () {
1513215132
var internals = {
1513315133
bundleType: 1,
15134-
version: "19.0.0-native-fb-f2df5694-20240916",
15134+
version: "19.0.0-native-fb-26855e46-20240916",
1513515135
rendererPackageName: "react-test-renderer",
1513615136
currentDispatcherRef: ReactSharedInternals,
1513715137
findFiberByHostInstance: getInstanceFromNode,
15138-
reconcilerVersion: "19.0.0-native-fb-f2df5694-20240916"
15138+
reconcilerVersion: "19.0.0-native-fb-26855e46-20240916"
1513915139
};
1514015140
internals.overrideHookState = overrideHookState;
1514115141
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -15280,5 +15280,5 @@ __DEV__ &&
1528015280
flushSyncWorkAcrossRoots_impl(0, !0));
1528115281
}
1528215282
};
15283-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
15283+
exports.version = "19.0.0-native-fb-26855e46-20240916";
1528415284
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9a9fb251219beceaeffc6b69776d3434>>
10+
* @generated SignedSource<<bc1eceaf1fd7b02a6c11ab1548ce65c8>>
1111
*/
1212

1313
"use strict";
@@ -9494,14 +9494,14 @@ function wrapFiber(fiber) {
94949494
}
94959495
var internals$jscomp$inline_1266 = {
94969496
bundleType: 0,
9497-
version: "19.0.0-native-fb-f2df5694-20240916",
9497+
version: "19.0.0-native-fb-26855e46-20240916",
94989498
rendererPackageName: "react-test-renderer",
94999499
currentDispatcherRef: ReactSharedInternals,
95009500
findFiberByHostInstance: function (mockNode) {
95019501
mockNode = nodeToInstanceMap.get(mockNode);
95029502
return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
95039503
},
9504-
reconcilerVersion: "19.0.0-native-fb-f2df5694-20240916"
9504+
reconcilerVersion: "19.0.0-native-fb-26855e46-20240916"
95059505
};
95069506
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95079507
var hook$jscomp$inline_1267 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -9637,4 +9637,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
96379637
flushSyncWorkAcrossRoots_impl(0, !0));
96389638
}
96399639
};
9640-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
9640+
exports.version = "19.0.0-native-fb-26855e46-20240916";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a850c1d37ecaa9e50bd6abf532024fd1>>
10+
* @generated SignedSource<<dbe78fc2470626489c135a835a479928>>
1111
*/
1212

1313
"use strict";
@@ -10066,14 +10066,14 @@ function wrapFiber(fiber) {
1006610066
}
1006710067
var internals$jscomp$inline_1144 = {
1006810068
bundleType: 0,
10069-
version: "19.0.0-native-fb-f2df5694-20240916",
10069+
version: "19.0.0-native-fb-26855e46-20240916",
1007010070
rendererPackageName: "react-test-renderer",
1007110071
currentDispatcherRef: ReactSharedInternals,
1007210072
findFiberByHostInstance: function (mockNode) {
1007310073
mockNode = nodeToInstanceMap.get(mockNode);
1007410074
return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
1007510075
},
10076-
reconcilerVersion: "19.0.0-native-fb-f2df5694-20240916",
10076+
reconcilerVersion: "19.0.0-native-fb-26855e46-20240916",
1007710077
getLaneLabelMap: function () {
1007810078
for (
1007910079
var map = new Map(), lane = 1, index$137 = 0;
@@ -10224,4 +10224,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
1022410224
flushSyncWorkAcrossRoots_impl(0, !0));
1022510225
}
1022610226
};
10227-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
10227+
exports.version = "19.0.0-native-fb-26855e46-20240916";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1c1b9763e7b42284daff249459a54514>>
10+
* @generated SignedSource<<9ce358f642b86db9f91ce63a7dcd60f9>>
1111
*/
1212

1313
"use strict";
@@ -1705,7 +1705,7 @@ __DEV__ &&
17051705
exports.useTransition = function () {
17061706
return resolveDispatcher().useTransition();
17071707
};
1708-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
1708+
exports.version = "19.0.0-native-fb-26855e46-20240916";
17091709
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17101710
"function" ===
17111711
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e678c9ab4742aa7571f90a33fc0dfaa6>>
10+
* @generated SignedSource<<fa3e5ac1d36b41a256ea5413edea7d19>>
1111
*/
1212

1313
"use strict";
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
580580
exports.useTransition = function () {
581581
return ReactSharedInternals.H.useTransition();
582582
};
583-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
583+
exports.version = "19.0.0-native-fb-26855e46-20240916";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0f502daf85a556bae5016204bf6af630>>
10+
* @generated SignedSource<<8c1789d2f2a99a0dd61d496b9005042d>>
1111
*/
1212

1313
"use strict";
@@ -584,7 +584,7 @@ exports.useSyncExternalStore = function (
584584
exports.useTransition = function () {
585585
return ReactSharedInternals.H.useTransition();
586586
};
587-
exports.version = "19.0.0-native-fb-f2df5694-20240916";
587+
exports.version = "19.0.0-native-fb-26855e46-20240916";
588588
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
589589
"function" ===
590590
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f2df5694f2be141954f22618fd3ad035203241a3
1+
26855e4680dedb21f2c73a069ed691822a242db1

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5ba7f2de6a46de16f61e9f39daee3a39>>
10+
* @generated SignedSource<<94110efa689aec012b44989bfbe6dea0>>
1111
*/
1212

1313
"use strict";
@@ -17180,11 +17180,11 @@ __DEV__ &&
1718017180
(function () {
1718117181
var internals = {
1718217182
bundleType: 1,
17183-
version: "19.0.0-native-fb-f2df5694-20240916",
17183+
version: "19.0.0-native-fb-26855e46-20240916",
1718417184
rendererPackageName: "react-native-renderer",
1718517185
currentDispatcherRef: ReactSharedInternals,
1718617186
findFiberByHostInstance: getInstanceFromNode,
17187-
reconcilerVersion: "19.0.0-native-fb-f2df5694-20240916"
17187+
reconcilerVersion: "19.0.0-native-fb-26855e46-20240916"
1718817188
};
1718917189
null !== extraDevToolsConfig &&
1719017190
(internals.rendererConfig = extraDevToolsConfig);

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<22685561eb8e04f40bed9d1b32d45795>>
10+
* @generated SignedSource<<35b97888ec5934d768b55cac672dae72>>
1111
*/
1212

1313
"use strict";
@@ -11085,11 +11085,11 @@ batchedUpdatesImpl = function (fn, a) {
1108511085
var roots = new Map(),
1108611086
internals$jscomp$inline_1164 = {
1108711087
bundleType: 0,
11088-
version: "19.0.0-native-fb-f2df5694-20240916",
11088+
version: "19.0.0-native-fb-26855e46-20240916",
1108911089
rendererPackageName: "react-native-renderer",
1109011090
currentDispatcherRef: ReactSharedInternals,
1109111091
findFiberByHostInstance: getInstanceFromNode,
11092-
reconcilerVersion: "19.0.0-native-fb-f2df5694-20240916"
11092+
reconcilerVersion: "19.0.0-native-fb-26855e46-20240916"
1109311093
};
1109411094
null !== extraDevToolsConfig &&
1109511095
(internals$jscomp$inline_1164.rendererConfig = extraDevToolsConfig);

0 commit comments

Comments
 (0)