Skip to content

Commit

Permalink
rename SuspenseList export to unstable_SuspenseList (#27061)
Browse files Browse the repository at this point in the history
## Summary

as we began [discussing
yesterday](#27056 (comment)),
`SuspenseList` is not actually stable yet, and should likely be exported
with the `unstable_` prefix.

the conversation yesterday began discussing this in the context of the
fb-specific packages, but changing it there without updating everywhere
else leads to test failures, so here the change is made across packages.

## How did you test this change?

```
yarn flow dom-browser
yarn test
```

DiffTrain build for commit eb2c2f7.
  • Loading branch information
noahlemen committed Jul 6, 2023
1 parent 4d06f41 commit 4880e36
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23982,7 +23982,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-a19bbebbe-20230706";
var ReactVersion = "18.3.0-canary-eb2c2f7c2-20230706";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8630,7 +8630,7 @@ var devToolsConfig$jscomp$inline_1032 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-a19bbebbe-20230706",
version: "18.3.0-canary-eb2c2f7c2-20230706",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1231 = {
Expand Down Expand Up @@ -8661,7 +8661,7 @@ var internals$jscomp$inline_1231 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-a19bbebbe-20230706"
reconcilerVersion: "18.3.0-canary-eb2c2f7c2-20230706"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1232 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9056,7 +9056,7 @@ var devToolsConfig$jscomp$inline_1074 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-a19bbebbe-20230706",
version: "18.3.0-canary-eb2c2f7c2-20230706",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1272 = {
Expand Down Expand Up @@ -9087,7 +9087,7 @@ var internals$jscomp$inline_1272 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-a19bbebbe-20230706"
reconcilerVersion: "18.3.0-canary-eb2c2f7c2-20230706"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1273 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e07addc76261adf5c9844f571089b66c>>
* @generated SignedSource<<7acac2f2a74dcdd0d337dca60149a207>>
*/

'use strict';
Expand All @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-a19bbebbe-20230706";
var ReactVersion = "18.3.0-canary-eb2c2f7c2-20230706";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -3898,7 +3898,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = cache;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c874b3507aeda09a93133667e1fcecd7>>
* @generated SignedSource<<baa752d40dc19ca131b74496ee679c02>>
*/

"use strict";
Expand Down Expand Up @@ -355,7 +355,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -617,4 +616,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-a19bbebbe-20230706";
exports.version = "18.3.0-canary-eb2c2f7c2-20230706";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<70baf3b541539dca5899f9c542f152f7>>
* @generated SignedSource<<fc291aa88e57315493fc94dd7aab82be>>
*/


Expand Down Expand Up @@ -333,7 +333,6 @@ exports.Profiler = REACT_PROFILER_TYPE;
exports.PureComponent = PureComponent;
exports.StrictMode = REACT_STRICT_MODE_TYPE;
exports.Suspense = REACT_SUSPENSE_TYPE;
exports.SuspenseList = REACT_SUSPENSE_LIST_TYPE;
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED =
ReactSharedInternals;
exports.cache = function (fn) {
Expand Down Expand Up @@ -620,7 +619,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-a19bbebbe-20230706";
exports.version = "18.3.0-canary-eb2c2f7c2-20230706";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a19bbebbe36abd34efbd8f003e0f3bb55e0f1fdc
eb2c2f7c2cf2652a168c2b433d2989131c69754b

0 comments on commit 4880e36

Please sign in to comment.