Skip to content

Commit 446d798

Browse files
noahlemennoahlemen
committed
Cleanup unused unstable_startTransition, unstable_useTransition, unstable_useDeferredValue exports from fb packages (#27056)
## Summary came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for [e91142d](e91142d)
1 parent f35b3c7 commit 446d798

10 files changed

+109
-139
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7118f5dd7bf5f1c44d0d2944ef8ad58e423909ad
1+
e91142dd69b0454e0d4e934c55dd541344fe32ca

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-cc85cd34";
30+
var ReactVersion = "18.3.0-www-classic-739b12ac";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -4180,11 +4180,8 @@ exports.unstable_TracingMarker = REACT_TRACING_MARKER_TYPE;
41804180
exports.unstable_act = act;
41814181
exports.unstable_getCacheForType = getCacheForType;
41824182
exports.unstable_getCacheSignal = getCacheSignal;
4183-
exports.unstable_startTransition = startTransition;
41844183
exports.unstable_useCacheRefresh = useCacheRefresh;
4185-
exports.unstable_useDeferredValue = useDeferredValue;
41864184
exports.unstable_useMemoCache = useMemoCache;
4187-
exports.unstable_useTransition = useTransition;
41884185
exports.use = use;
41894186
exports.useCallback = useCallback;
41904187
exports.useContext = useContext;

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-01767f27";
30+
var ReactVersion = "18.3.0-www-modern-d09ac638";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -4143,11 +4143,8 @@ exports.unstable_SuspenseList = REACT_SUSPENSE_LIST_TYPE;
41434143
exports.unstable_act = act;
41444144
exports.unstable_getCacheForType = getCacheForType;
41454145
exports.unstable_getCacheSignal = getCacheSignal;
4146-
exports.unstable_startTransition = startTransition;
41474146
exports.unstable_useCacheRefresh = useCacheRefresh;
4148-
exports.unstable_useDeferredValue = useDeferredValue;
41494147
exports.unstable_useMemoCache = useMemoCache;
4150-
exports.unstable_useTransition = useTransition;
41514148
exports.use = use;
41524149
exports.useCallback = useCallback;
41534150
exports.useContext = useContext;

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -282,37 +282,17 @@ function createCacheRoot() {
282282
function createCacheNode() {
283283
return { s: 0, v: void 0, o: null, p: null };
284284
}
285-
var ReactCurrentDispatcher = { current: null };
286-
function useTransition() {
287-
return ReactCurrentDispatcher.current.useTransition();
288-
}
289-
function useDeferredValue(value) {
290-
return ReactCurrentDispatcher.current.useDeferredValue(value);
291-
}
292-
var ReactCurrentBatchConfig = { transition: null },
285+
var ReactCurrentDispatcher = { current: null },
286+
ReactCurrentBatchConfig = { transition: null },
293287
ReactSharedInternals = {
294288
ReactCurrentDispatcher: ReactCurrentDispatcher,
295289
ReactCurrentCache: ReactCurrentCache,
296290
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
297291
ReactCurrentOwner: ReactCurrentOwner$1,
298292
ContextRegistry: {}
299293
},
300-
ContextRegistry = ReactSharedInternals.ContextRegistry;
301-
function startTransition(scope, options) {
302-
var prevTransition = ReactCurrentBatchConfig.transition;
303-
ReactCurrentBatchConfig.transition = {};
304-
enableTransitionTracing &&
305-
void 0 !== options &&
306-
void 0 !== options.name &&
307-
((ReactCurrentBatchConfig.transition.name = options.name),
308-
(ReactCurrentBatchConfig.transition.startTime = -1));
309-
try {
310-
scope();
311-
} finally {
312-
ReactCurrentBatchConfig.transition = prevTransition;
313-
}
314-
}
315-
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
294+
ContextRegistry = ReactSharedInternals.ContextRegistry,
295+
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
316296
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
317297
function jsx$1(type, config, maybeKey) {
318298
var propName,
@@ -544,7 +524,20 @@ exports.memo = function (type, compare) {
544524
compare: void 0 === compare ? null : compare
545525
};
546526
};
547-
exports.startTransition = startTransition;
527+
exports.startTransition = function (scope, options) {
528+
var prevTransition = ReactCurrentBatchConfig.transition;
529+
ReactCurrentBatchConfig.transition = {};
530+
enableTransitionTracing &&
531+
void 0 !== options &&
532+
void 0 !== options.name &&
533+
((ReactCurrentBatchConfig.transition.name = options.name),
534+
(ReactCurrentBatchConfig.transition.startTime = -1));
535+
try {
536+
scope();
537+
} finally {
538+
ReactCurrentBatchConfig.transition = prevTransition;
539+
}
540+
};
548541
exports.unstable_Cache = REACT_CACHE_TYPE;
549542
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
550543
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
@@ -571,15 +564,12 @@ exports.unstable_getCacheSignal = function () {
571564
),
572565
dispatcher.signal);
573566
};
574-
exports.unstable_startTransition = startTransition;
575567
exports.unstable_useCacheRefresh = function () {
576568
return ReactCurrentDispatcher.current.useCacheRefresh();
577569
};
578-
exports.unstable_useDeferredValue = useDeferredValue;
579570
exports.unstable_useMemoCache = function (size) {
580571
return ReactCurrentDispatcher.current.useMemoCache(size);
581572
};
582-
exports.unstable_useTransition = useTransition;
583573
exports.use = function (usable) {
584574
return ReactCurrentDispatcher.current.use(usable);
585575
};
@@ -590,7 +580,9 @@ exports.useContext = function (Context) {
590580
return ReactCurrentDispatcher.current.useContext(Context);
591581
};
592582
exports.useDebugValue = function () {};
593-
exports.useDeferredValue = useDeferredValue;
583+
exports.useDeferredValue = function (value) {
584+
return ReactCurrentDispatcher.current.useDeferredValue(value);
585+
};
594586
exports.useEffect = function (create, deps) {
595587
return ReactCurrentDispatcher.current.useEffect(create, deps);
596588
};
@@ -629,5 +621,7 @@ exports.useSyncExternalStore = function (
629621
getServerSnapshot
630622
);
631623
};
632-
exports.useTransition = useTransition;
633-
exports.version = "18.3.0-www-classic-89dfcb69";
624+
exports.useTransition = function () {
625+
return ReactCurrentDispatcher.current.useTransition();
626+
};
627+
exports.version = "18.3.0-www-classic-80690551";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -249,37 +249,17 @@ function createCacheRoot() {
249249
function createCacheNode() {
250250
return { s: 0, v: void 0, o: null, p: null };
251251
}
252-
var ReactCurrentDispatcher = { current: null };
253-
function useTransition() {
254-
return ReactCurrentDispatcher.current.useTransition();
255-
}
256-
function useDeferredValue(value) {
257-
return ReactCurrentDispatcher.current.useDeferredValue(value);
258-
}
259-
var ReactCurrentBatchConfig = { transition: null },
252+
var ReactCurrentDispatcher = { current: null },
253+
ReactCurrentBatchConfig = { transition: null },
260254
ReactSharedInternals = {
261255
ReactCurrentDispatcher: ReactCurrentDispatcher,
262256
ReactCurrentCache: ReactCurrentCache,
263257
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
264258
ReactCurrentOwner: ReactCurrentOwner$1,
265259
ContextRegistry: {}
266260
},
267-
ContextRegistry = ReactSharedInternals.ContextRegistry;
268-
function startTransition(scope, options) {
269-
var prevTransition = ReactCurrentBatchConfig.transition;
270-
ReactCurrentBatchConfig.transition = {};
271-
enableTransitionTracing &&
272-
void 0 !== options &&
273-
void 0 !== options.name &&
274-
((ReactCurrentBatchConfig.transition.name = options.name),
275-
(ReactCurrentBatchConfig.transition.startTime = -1));
276-
try {
277-
scope();
278-
} finally {
279-
ReactCurrentBatchConfig.transition = prevTransition;
280-
}
281-
}
282-
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
261+
ContextRegistry = ReactSharedInternals.ContextRegistry,
262+
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
283263
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
284264
function jsx$1(type, config, maybeKey) {
285265
var propName,
@@ -537,7 +517,20 @@ exports.memo = function (type, compare) {
537517
compare: void 0 === compare ? null : compare
538518
};
539519
};
540-
exports.startTransition = startTransition;
520+
exports.startTransition = function (scope, options) {
521+
var prevTransition = ReactCurrentBatchConfig.transition;
522+
ReactCurrentBatchConfig.transition = {};
523+
enableTransitionTracing &&
524+
void 0 !== options &&
525+
void 0 !== options.name &&
526+
((ReactCurrentBatchConfig.transition.name = options.name),
527+
(ReactCurrentBatchConfig.transition.startTime = -1));
528+
try {
529+
scope();
530+
} finally {
531+
ReactCurrentBatchConfig.transition = prevTransition;
532+
}
533+
};
541534
exports.unstable_Cache = REACT_CACHE_TYPE;
542535
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
543536
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
@@ -563,15 +556,12 @@ exports.unstable_getCacheSignal = function () {
563556
),
564557
dispatcher.signal);
565558
};
566-
exports.unstable_startTransition = startTransition;
567559
exports.unstable_useCacheRefresh = function () {
568560
return ReactCurrentDispatcher.current.useCacheRefresh();
569561
};
570-
exports.unstable_useDeferredValue = useDeferredValue;
571562
exports.unstable_useMemoCache = function (size) {
572563
return ReactCurrentDispatcher.current.useMemoCache(size);
573564
};
574-
exports.unstable_useTransition = useTransition;
575565
exports.use = function (usable) {
576566
return ReactCurrentDispatcher.current.use(usable);
577567
};
@@ -582,7 +572,9 @@ exports.useContext = function (Context) {
582572
return ReactCurrentDispatcher.current.useContext(Context);
583573
};
584574
exports.useDebugValue = function () {};
585-
exports.useDeferredValue = useDeferredValue;
575+
exports.useDeferredValue = function (value) {
576+
return ReactCurrentDispatcher.current.useDeferredValue(value);
577+
};
586578
exports.useEffect = function (create, deps) {
587579
return ReactCurrentDispatcher.current.useEffect(create, deps);
588580
};
@@ -621,5 +613,7 @@ exports.useSyncExternalStore = function (
621613
getServerSnapshot
622614
);
623615
};
624-
exports.useTransition = useTransition;
625-
exports.version = "18.3.0-www-modern-4c04bf5d";
616+
exports.useTransition = function () {
617+
return ReactCurrentDispatcher.current.useTransition();
618+
};
619+
exports.version = "18.3.0-www-modern-1670571e";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -293,37 +293,17 @@ function createCacheRoot() {
293293
function createCacheNode() {
294294
return { s: 0, v: void 0, o: null, p: null };
295295
}
296-
var ReactCurrentDispatcher = { current: null };
297-
function useTransition() {
298-
return ReactCurrentDispatcher.current.useTransition();
299-
}
300-
function useDeferredValue(value) {
301-
return ReactCurrentDispatcher.current.useDeferredValue(value);
302-
}
303-
var ReactCurrentBatchConfig = { transition: null },
296+
var ReactCurrentDispatcher = { current: null },
297+
ReactCurrentBatchConfig = { transition: null },
304298
ReactSharedInternals = {
305299
ReactCurrentDispatcher: ReactCurrentDispatcher,
306300
ReactCurrentCache: ReactCurrentCache,
307301
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
308302
ReactCurrentOwner: ReactCurrentOwner$1,
309303
ContextRegistry: {}
310304
},
311-
ContextRegistry = ReactSharedInternals.ContextRegistry;
312-
function startTransition(scope, options) {
313-
var prevTransition = ReactCurrentBatchConfig.transition;
314-
ReactCurrentBatchConfig.transition = {};
315-
enableTransitionTracing &&
316-
void 0 !== options &&
317-
void 0 !== options.name &&
318-
((ReactCurrentBatchConfig.transition.name = options.name),
319-
(ReactCurrentBatchConfig.transition.startTime = -1));
320-
try {
321-
scope();
322-
} finally {
323-
ReactCurrentBatchConfig.transition = prevTransition;
324-
}
325-
}
326-
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
305+
ContextRegistry = ReactSharedInternals.ContextRegistry,
306+
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
327307
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
328308
function jsx$1(type, config, maybeKey) {
329309
var propName,
@@ -555,7 +535,20 @@ exports.memo = function (type, compare) {
555535
compare: void 0 === compare ? null : compare
556536
};
557537
};
558-
exports.startTransition = startTransition;
538+
exports.startTransition = function (scope, options) {
539+
var prevTransition = ReactCurrentBatchConfig.transition;
540+
ReactCurrentBatchConfig.transition = {};
541+
enableTransitionTracing &&
542+
void 0 !== options &&
543+
void 0 !== options.name &&
544+
((ReactCurrentBatchConfig.transition.name = options.name),
545+
(ReactCurrentBatchConfig.transition.startTime = -1));
546+
try {
547+
scope();
548+
} finally {
549+
ReactCurrentBatchConfig.transition = prevTransition;
550+
}
551+
};
559552
exports.unstable_Cache = REACT_CACHE_TYPE;
560553
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
561554
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
@@ -582,15 +575,12 @@ exports.unstable_getCacheSignal = function () {
582575
),
583576
dispatcher.signal);
584577
};
585-
exports.unstable_startTransition = startTransition;
586578
exports.unstable_useCacheRefresh = function () {
587579
return ReactCurrentDispatcher.current.useCacheRefresh();
588580
};
589-
exports.unstable_useDeferredValue = useDeferredValue;
590581
exports.unstable_useMemoCache = function (size) {
591582
return ReactCurrentDispatcher.current.useMemoCache(size);
592583
};
593-
exports.unstable_useTransition = useTransition;
594584
exports.use = function (usable) {
595585
return ReactCurrentDispatcher.current.use(usable);
596586
};
@@ -601,7 +591,9 @@ exports.useContext = function (Context) {
601591
return ReactCurrentDispatcher.current.useContext(Context);
602592
};
603593
exports.useDebugValue = function () {};
604-
exports.useDeferredValue = useDeferredValue;
594+
exports.useDeferredValue = function (value) {
595+
return ReactCurrentDispatcher.current.useDeferredValue(value);
596+
};
605597
exports.useEffect = function (create, deps) {
606598
return ReactCurrentDispatcher.current.useEffect(create, deps);
607599
};
@@ -640,8 +632,10 @@ exports.useSyncExternalStore = function (
640632
getServerSnapshot
641633
);
642634
};
643-
exports.useTransition = useTransition;
644-
exports.version = "18.3.0-www-classic-5a120705";
635+
exports.useTransition = function () {
636+
return ReactCurrentDispatcher.current.useTransition();
637+
};
638+
exports.version = "18.3.0-www-classic-e0d9c072";
645639

646640
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
647641
if (

0 commit comments

Comments
 (0)