Skip to content

Commit 41b3c31

Browse files
authored
remove RTR from ReactCacheOld-test (#28409)
## Summary swaps `react-test-renderer` for `react-noop-rendererer` in ReactCacheOld-test ## How did you test this change? `yarn test-www ReactCacheOld`
1 parent dc30644 commit 41b3c31

File tree

1 file changed

+18
-31
lines changed

1 file changed

+18
-31
lines changed

packages/react-cache/src/__tests__/ReactCacheOld-test.internal.js

Lines changed: 18 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ let ReactCache;
1313
let createResource;
1414
let React;
1515
let ReactFeatureFlags;
16-
let ReactTestRenderer;
16+
let ReactNoop;
1717
let Scheduler;
1818
let Suspense;
1919
let TextResource;
@@ -34,7 +34,7 @@ describe('ReactCache', () => {
3434
Suspense = React.Suspense;
3535
ReactCache = require('react-cache');
3636
createResource = ReactCache.unstable_createResource;
37-
ReactTestRenderer = require('react-test-renderer');
37+
ReactNoop = require('react-noop-renderer');
3838
Scheduler = require('scheduler');
3939

4040
const InternalTestUtils = require('internal-test-utils');
@@ -120,9 +120,8 @@ describe('ReactCache', () => {
120120
);
121121
}
122122

123-
ReactTestRenderer.create(<App />, {
124-
isConcurrent: true,
125-
});
123+
const root = ReactNoop.createRoot();
124+
root.render(<App />);
126125

127126
await waitForAll(['Suspend! [Hi]', 'Loading...']);
128127

@@ -140,9 +139,8 @@ describe('ReactCache', () => {
140139
);
141140
}
142141

143-
const root = ReactTestRenderer.create(<App />, {
144-
isConcurrent: true,
145-
});
142+
const root = ReactNoop.createRoot();
143+
root.render(<App />);
146144

147145
await waitForAll(['Suspend! [Hi]', 'Loading...']);
148146

@@ -157,7 +155,7 @@ describe('ReactCache', () => {
157155
assertLog(['Promise rejected [Hi]', 'Error! [Hi]', 'Error! [Hi]']);
158156

159157
// Should throw again on a subsequent read
160-
root.update(<App />);
158+
root.render(<App />);
161159
await waitForThrow('Failed to load: Hi');
162160
assertLog(['Error! [Hi]', 'Error! [Hi]']);
163161
});
@@ -176,13 +174,11 @@ describe('ReactCache', () => {
176174
return BadTextResource.read(['Hi', 100]);
177175
}
178176

179-
ReactTestRenderer.create(
177+
const root = ReactNoop.createRoot();
178+
root.render(
180179
<Suspense fallback={<Text text="Loading..." />}>
181180
<App />
182181
</Suspense>,
183-
{
184-
isConcurrent: true,
185-
},
186182
);
187183

188184
if (__DEV__) {
@@ -202,16 +198,14 @@ describe('ReactCache', () => {
202198
it('evicts least recently used values', async () => {
203199
ReactCache.unstable_setGlobalCacheLimit(3);
204200

201+
const root = ReactNoop.createRoot();
205202
// Render 1, 2, and 3
206-
const root = ReactTestRenderer.create(
203+
root.render(
207204
<Suspense fallback={<Text text="Loading..." />}>
208205
<AsyncText ms={100} text={1} />
209206
<AsyncText ms={100} text={2} />
210207
<AsyncText ms={100} text={3} />
211208
</Suspense>,
212-
{
213-
isConcurrent: true,
214-
},
215209
);
216210
await waitForAll(['Suspend! [1]', 'Loading...']);
217211
jest.advanceTimersByTime(100);
@@ -228,7 +222,7 @@ describe('ReactCache', () => {
228222
expect(root).toMatchRenderedOutput('123');
229223

230224
// Render 1, 4, 5
231-
root.update(
225+
root.render(
232226
<Suspense fallback={<Text text="Loading..." />}>
233227
<AsyncText ms={100} text={1} />
234228
<AsyncText ms={100} text={4} />
@@ -255,7 +249,7 @@ describe('ReactCache', () => {
255249
// We've now rendered values 1, 2, 3, 4, 5, over our limit of 3. The least
256250
// recently used values are 2 and 3. They should have been evicted.
257251

258-
root.update(
252+
root.render(
259253
<Suspense fallback={<Text text="Loading..." />}>
260254
<AsyncText ms={100} text={1} />
261255
<AsyncText ms={100} text={2} />
@@ -293,13 +287,11 @@ describe('ReactCache', () => {
293287
return <Text text="Result" />;
294288
}
295289

296-
const root = ReactTestRenderer.create(
290+
const root = ReactNoop.createRoot();
291+
root.render(
297292
<Suspense fallback={<Text text="Loading..." />}>
298293
<App />
299294
</Suspense>,
300-
{
301-
isConcurrent: true,
302-
},
303295
);
304296

305297
await waitForAll(['Loading...']);
@@ -351,13 +343,11 @@ describe('ReactCache', () => {
351343
}
352344
}
353345

354-
const root = ReactTestRenderer.create(
346+
const root = ReactNoop.createRoot();
347+
root.render(
355348
<Suspense fallback={<Text text="Loading..." />}>
356349
<BadAsyncText text="Hi" />
357350
</Suspense>,
358-
{
359-
isConcurrent: true,
360-
},
361351
);
362352

363353
await waitForAll(['Suspend! [Hi]', 'Loading...']);
@@ -367,13 +357,10 @@ describe('ReactCache', () => {
367357
// cached value.
368358
resolveThenable('Hi muahahaha I am different');
369359

370-
root.update(
360+
root.render(
371361
<Suspense fallback={<Text text="Loading..." />}>
372362
<BadAsyncText text="Hi" />
373363
</Suspense>,
374-
{
375-
isConcurrent: true,
376-
},
377364
);
378365

379366
assertLog([]);

0 commit comments

Comments
 (0)