Skip to content

Commit 3c7faae

Browse files
committed
Remove errorHydratingContainer (#28664)
I originally added this in #21021 but I didn't mention why and I don't quite remember why. Maybe because there were no other message? However at the time the recoverable errors mechanism didn't exist. Today I believe all cases where this happens will trigger another recoverable error. Namely these two: https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L1442-L1446 https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L2962-L2965 Therefore this is just an extra unnecessary log. DiffTrain build for [323b6e9](323b6e9)
1 parent ab2961c commit 3c7faae

File tree

6 files changed

+5
-62
lines changed

6 files changed

+5
-62
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
9f33f699e4f832971dc0f2047129f832655a3b6d
1+
323b6e98a76fe6ee721f10d327a9a682334d1a97

compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8922,16 +8922,6 @@ if (__DEV__) {
89228922
return true;
89238923
}
89248924

8925-
function errorHydratingContainer(parentContainer) {
8926-
{
8927-
// TODO: This gets logged by onRecoverableError, too, so we should be
8928-
// able to remove it.
8929-
error(
8930-
"An error occurred during hydration. The server HTML was replaced with client content."
8931-
);
8932-
}
8933-
}
8934-
89358925
function warnNonHydratedInstance(fiber, rejectedCandidate) {
89368926
{
89378927
if (didSuspendOrErrorDEV) {
@@ -32068,10 +32058,6 @@ if (__DEV__) {
3206832058
// Something to consider for a future refactor.
3206932059
var rootWorkInProgress = prepareFreshStack(root, errorRetryLanes);
3207032060
rootWorkInProgress.flags |= ForceClientRender;
32071-
32072-
{
32073-
errorHydratingContainer();
32074-
}
3207532061
}
3207632062

3207732063
var exitStatus = renderRootSync(root, errorRetryLanes);
@@ -36345,7 +36331,7 @@ if (__DEV__) {
3634536331
return root;
3634636332
}
3634736333

36348-
var ReactVersion = "19.0.0-www-classic-06295a1e";
36334+
var ReactVersion = "19.0.0-www-classic-c7ac3967";
3634936335

3635036336
function createPortal$1(
3635136337
children,

compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8885,16 +8885,6 @@ if (__DEV__) {
88858885
return true;
88868886
}
88878887

8888-
function errorHydratingContainer(parentContainer) {
8889-
{
8890-
// TODO: This gets logged by onRecoverableError, too, so we should be
8891-
// able to remove it.
8892-
error(
8893-
"An error occurred during hydration. The server HTML was replaced with client content."
8894-
);
8895-
}
8896-
}
8897-
88988888
function warnNonHydratedInstance(fiber, rejectedCandidate) {
88998889
{
89008890
if (didSuspendOrErrorDEV) {
@@ -31925,10 +31915,6 @@ if (__DEV__) {
3192531915
// Something to consider for a future refactor.
3192631916
var rootWorkInProgress = prepareFreshStack(root, errorRetryLanes);
3192731917
rootWorkInProgress.flags |= ForceClientRender;
31928-
31929-
{
31930-
errorHydratingContainer();
31931-
}
3193231918
}
3193331919

3193431920
var exitStatus = renderRootSync(root, errorRetryLanes);
@@ -36193,7 +36179,7 @@ if (__DEV__) {
3619336179
return root;
3619436180
}
3619536181

36196-
var ReactVersion = "19.0.0-www-modern-2340f8c4";
36182+
var ReactVersion = "19.0.0-www-modern-40561912";
3619736183

3619836184
function createPortal$1(
3619936185
children,

compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9059,16 +9059,6 @@ if (__DEV__) {
90599059
return true;
90609060
}
90619061

9062-
function errorHydratingContainer(parentContainer) {
9063-
{
9064-
// TODO: This gets logged by onRecoverableError, too, so we should be
9065-
// able to remove it.
9066-
error(
9067-
"An error occurred during hydration. The server HTML was replaced with client content."
9068-
);
9069-
}
9070-
}
9071-
90729062
function warnNonHydratedInstance(fiber, rejectedCandidate) {
90739063
{
90749064
if (didSuspendOrErrorDEV) {
@@ -32692,10 +32682,6 @@ if (__DEV__) {
3269232682
// Something to consider for a future refactor.
3269332683
var rootWorkInProgress = prepareFreshStack(root, errorRetryLanes);
3269432684
rootWorkInProgress.flags |= ForceClientRender;
32695-
32696-
{
32697-
errorHydratingContainer();
32698-
}
3269932685
}
3270032686

3270132687
var exitStatus = renderRootSync(root, errorRetryLanes);
@@ -36969,7 +36955,7 @@ if (__DEV__) {
3696936955
return root;
3697036956
}
3697136957

36972-
var ReactVersion = "19.0.0-www-classic-542ebce8";
36958+
var ReactVersion = "19.0.0-www-classic-7d6a5e18";
3697336959

3697436960
function createPortal$1(
3697536961
children,

compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9022,16 +9022,6 @@ if (__DEV__) {
90229022
return true;
90239023
}
90249024

9025-
function errorHydratingContainer(parentContainer) {
9026-
{
9027-
// TODO: This gets logged by onRecoverableError, too, so we should be
9028-
// able to remove it.
9029-
error(
9030-
"An error occurred during hydration. The server HTML was replaced with client content."
9031-
);
9032-
}
9033-
}
9034-
90359025
function warnNonHydratedInstance(fiber, rejectedCandidate) {
90369026
{
90379027
if (didSuspendOrErrorDEV) {
@@ -32549,10 +32539,6 @@ if (__DEV__) {
3254932539
// Something to consider for a future refactor.
3255032540
var rootWorkInProgress = prepareFreshStack(root, errorRetryLanes);
3255132541
rootWorkInProgress.flags |= ForceClientRender;
32552-
32553-
{
32554-
errorHydratingContainer();
32555-
}
3255632542
}
3255732543

3255832544
var exitStatus = renderRootSync(root, errorRetryLanes);
@@ -36817,7 +36803,7 @@ if (__DEV__) {
3681736803
return root;
3681836804
}
3681936805

36820-
var ReactVersion = "19.0.0-www-modern-e8df89fb";
36806+
var ReactVersion = "19.0.0-www-modern-0276b2d8";
3682136807

3682236808
function createPortal$1(
3682336809
children,

compiled/facebook-www/__test_utils__/ReactAllWarnings.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)