Fix error handling when the Flight client itself errors

sebmarkbage · sebmarkbage · commit 3b201ddfb7c5 · 2022-08-27T18:33:21.000-04:00
diff --git a/packages/react-server-dom-webpack/src/ReactFlightDOMClient.js b/packages/react-server-dom-webpack/src/ReactFlightDOMClient.js
@@ -35,12 +35,18 @@ function startReadingFromStream(
     }
     const buffer: Uint8Array = (value: any);
     processBinaryChunk(response, buffer);
-    return reader.read().then(progress, error);
+    return reader
+      .read()
+      .then(progress)
+      .catch(error);
   }
   function error(e) {
     reportGlobalError(response, e);
   }
-  reader.read().then(progress, error);
+  reader
+    .read()
+    .then(progress)
+    .catch(error);
 }
 
 function createFromReadableStream(

Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,18 @@ function startReadingFromStream(`
`35`	`35`	`}`
`36`	`36`	`const buffer: Uint8Array = (value: any);`
`37`	`37`	`processBinaryChunk(response, buffer);`
`38`		`- return reader.read().then(progress, error);`
	`38`	`+ return reader`
	`39`	`+ .read()`
	`40`	`+ .then(progress)`
	`41`	`+ .catch(error);`
`39`	`42`	`}`
`40`	`43`	`function error(e) {`
`41`	`44`	`reportGlobalError(response, e);`
`42`	`45`	`}`
`43`		`- reader.read().then(progress, error);`
	`46`	`+ reader`
	`47`	`+ .read()`
	`48`	`+ .then(progress)`
	`49`	`+ .catch(error);`
`44`	`50`	`}`
`45`	`51`
`46`	`52`	`function createFromReadableStream(`