Skip to content

Commit 3a44621

Browse files
authored
Disable avoidThisFallback support in Fizz (#23224)
* disable fizz avoidThisFallback support * true
1 parent 0318ac2 commit 3a44621

11 files changed

+12
-3
lines changed

packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1526,7 +1526,7 @@ describe('ReactDOMFizzServer', () => {
15261526
expect(getVisibleChildren(container)).toEqual(<div>Hello</div>);
15271527
});
15281528

1529-
// @gate experimental && enableSuspenseAvoidThisFallback
1529+
// @gate experimental && enableSuspenseAvoidThisFallbackFizz
15301530
it('should respect unstable_avoidThisFallback', async () => {
15311531
const resolved = {
15321532
0: false,

packages/react-server/src/ReactFizzServer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ import {
113113
warnAboutDefaultPropsOnFunctionComponents,
114114
enableScopeAPI,
115115
enableLazyElements,
116-
enableSuspenseAvoidThisFallback,
116+
enableSuspenseAvoidThisFallbackFizz,
117117
} from 'shared/ReactFeatureFlags';
118118

119119
import getComponentNameFromType from 'shared/getComponentNameFromType';
@@ -1027,7 +1027,7 @@ function renderElement(
10271027
// eslint-disable-next-line-no-fallthrough
10281028
case REACT_SUSPENSE_TYPE: {
10291029
if (
1030-
enableSuspenseAvoidThisFallback &&
1030+
enableSuspenseAvoidThisFallbackFizz &&
10311031
props.unstable_avoidThisFallback === true
10321032
) {
10331033
renderBackupSuspenseBoundary(request, task, props);

packages/shared/ReactFeatureFlags.js

+1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ export const warnAboutSpreadingKeyToJSX = false;
102102
export const warnOnSubscriptionInsideStartTransition = false;
103103

104104
export const enableSuspenseAvoidThisFallback = false;
105+
export const enableSuspenseAvoidThisFallbackFizz = false;
105106

106107
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
107108

packages/shared/forks/ReactFeatureFlags.native-fb.js

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
5050
export const warnAboutSpreadingKeyToJSX = false;
5151
export const warnOnSubscriptionInsideStartTransition = false;
5252
export const enableSuspenseAvoidThisFallback = false;
53+
export const enableSuspenseAvoidThisFallbackFizz = false;
5354
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
5455
export const enableClientRenderFallbackOnHydrationMismatch = true;
5556
export const enableComponentStackLocations = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
4141
export const warnAboutSpreadingKeyToJSX = false;
4242
export const warnOnSubscriptionInsideStartTransition = false;
4343
export const enableSuspenseAvoidThisFallback = false;
44+
export const enableSuspenseAvoidThisFallbackFizz = false;
4445
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
4546
export const enableClientRenderFallbackOnHydrationMismatch = true;
4647
export const enableComponentStackLocations = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
4141
export const warnAboutSpreadingKeyToJSX = false;
4242
export const warnOnSubscriptionInsideStartTransition = false;
4343
export const enableSuspenseAvoidThisFallback = false;
44+
export const enableSuspenseAvoidThisFallbackFizz = false;
4445
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
4546
export const enableClientRenderFallbackOnHydrationMismatch = true;
4647
export const enableComponentStackLocations = true;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export const enableNewReconciler = false;
5151
export const deferRenderPhaseUpdateToNextBatch = false;
5252
export const warnOnSubscriptionInsideStartTransition = false;
5353
export const enableSuspenseAvoidThisFallback = false;
54+
export const enableSuspenseAvoidThisFallbackFizz = false;
5455
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
5556
export const enableClientRenderFallbackOnHydrationMismatch = true;
5657
export const enableStrictEffects = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
4141
export const warnAboutSpreadingKeyToJSX = false;
4242
export const warnOnSubscriptionInsideStartTransition = false;
4343
export const enableSuspenseAvoidThisFallback = true;
44+
export const enableSuspenseAvoidThisFallbackFizz = false;
4445
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
4546
export const enableClientRenderFallbackOnHydrationMismatch = true;
4647
export const enableComponentStackLocations = true;

packages/shared/forks/ReactFeatureFlags.testing.js

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
4141
export const warnAboutSpreadingKeyToJSX = false;
4242
export const warnOnSubscriptionInsideStartTransition = false;
4343
export const enableSuspenseAvoidThisFallback = false;
44+
export const enableSuspenseAvoidThisFallbackFizz = false;
4445
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
4546
export const enableClientRenderFallbackOnHydrationMismatch = true;
4647
export const enableComponentStackLocations = true;

packages/shared/forks/ReactFeatureFlags.testing.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
4141
export const warnAboutSpreadingKeyToJSX = false;
4242
export const warnOnSubscriptionInsideStartTransition = false;
4343
export const enableSuspenseAvoidThisFallback = true;
44+
export const enableSuspenseAvoidThisFallbackFizz = false;
4445
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
4546
export const enableClientRenderFallbackOnHydrationMismatch = true;
4647
export const enableComponentStackLocations = true;

packages/shared/forks/ReactFeatureFlags.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export const enableUpdaterTracking = __PROFILE__;
5151

5252
export const enableSuspenseLayoutEffectSemantics = true;
5353
export const enableSuspenseAvoidThisFallback = true;
54+
export const enableSuspenseAvoidThisFallbackFizz = false;
5455

5556
// Logs additional User Timing API marks for use with an experimental profiling tool.
5657
export const enableSchedulingProfiler =

0 commit comments

Comments
 (0)