Skip to content

Commit

Permalink
Hardcode disableIEWorkarounds for www (#28811)
Browse files Browse the repository at this point in the history
This has landed and is true everywhere, but let's keep the flag until it
lands in the stable release.
  • Loading branch information
rickhanlonii committed Apr 11, 2024
1 parent ce262b1 commit 39d0c82
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 0 additions & 1 deletion packages/shared/forks/ReactFeatureFlags.www-dynamic.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// Use __VARIANT__ to simulate a GK. The tests will be run twice: once
// with the __VARIANT__ set to `true`, and once set to `false`.

export const disableIEWorkarounds = __VARIANT__;
export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
export const enableLazyContextPropagation = __VARIANT__;
export const forceConcurrentByDefaultForTesting = __VARIANT__;
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/forks/ReactFeatureFlags.www.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import typeof * as DynamicFeatureFlags from './ReactFeatureFlags.www-dynamic';
const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags');

export const {
disableIEWorkarounds,
enableTrustedTypesIntegration,
enableDebugTracing,
enableLazyContextPropagation,
Expand Down Expand Up @@ -49,6 +48,7 @@ export const enableUpdaterTracking = __PROFILE__;
export const enableSuspenseAvoidThisFallback = true;
export const enableSuspenseAvoidThisFallbackFizz = false;

export const disableIEWorkarounds = true;
export const enableCPUSuspense = true;
export const enableUseMemoCacheHook = true;
export const enableUseEffectEventHook = true;
Expand Down
5 changes: 5 additions & 0 deletions scripts/jest/setupTests.www.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ jest.mock('shared/ReactFeatureFlags', () => {
// code live.
actual.disableInputAttributeSyncing = __VARIANT__;

// This is hardcoded to true for the next release,
// but still run the tests against both variants until
// we remove the flag.
actual.disableIEWorkarounds = __VARIANT__;

return actual;
});

Expand Down

0 comments on commit 39d0c82

Please sign in to comment.