Improve flagging of React.cache to remove indirection in bundled code (#28263)

Uses a better technique for conditionally disabling cache on the client

DiffTrain build for commit a1ace9d.

Author: gnoff

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

@@ -25725,7 +25725,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-canary-91caa96e4-20240206";
+    var ReactVersion = "18.3.0-canary-a1ace9d3c-20240206";
 
     // Might add PROFILE later.
 

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

@@ -9157,7 +9157,7 @@ var devToolsConfig$jscomp$inline_1012 = {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "18.3.0-canary-91caa96e4-20240206",
+  version: "18.3.0-canary-a1ace9d3c-20240206",
   rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1190 = {
@@ -9188,7 +9188,7 @@ var internals$jscomp$inline_1190 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-canary-91caa96e4-20240206"
+  reconcilerVersion: "18.3.0-canary-a1ace9d3c-20240206"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1191 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

@@ -9585,7 +9585,7 @@ var devToolsConfig$jscomp$inline_1054 = {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "18.3.0-canary-91caa96e4-20240206",
+  version: "18.3.0-canary-a1ace9d3c-20240206",
   rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1231 = {
@@ -9616,7 +9616,7 @@ var internals$jscomp$inline_1231 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-canary-91caa96e4-20240206"
+  reconcilerVersion: "18.3.0-canary-a1ace9d3c-20240206"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1232 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<41ebcac0959dc7c1f568b21dae3e2874>>
+ * @generated SignedSource<<e586d9c47ab7cba6a52560196c89aa09>>
  */
 
 "use strict";
@@ -24,7 +24,7 @@ if (__DEV__) {
     ) {
       __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
     }
-    var ReactVersion = "18.3.0-canary-91caa96e4-20240206";
+    var ReactVersion = "18.3.0-canary-a1ace9d3c-20240206";
 
     // ATTENTION
     // When adding new symbols to this file,
@@ -2735,26 +2735,25 @@ if (__DEV__) {
       return elementType;
     }
 
-    function cache(fn) {
-      {
-        // On the client (i.e. not a Server Components environment) `cache` has
-        // no caching behavior. We just return the function as-is.
-        //
-        // We intend to implement client caching in a future major release. In the
-        // meantime, it's only exposed as an API so that Shared Components can use
-        // per-request caching on the server without breaking on the client. But it
-        // does mean they need to be aware of the behavioral difference.
-        //
-        // The rest of the behavior is the same as the server implementation — it
-        // returns a new reference, extra properties like `displayName` are not
-        // preserved, the length of the new function is 0, etc. That way apps can't
-        // accidentally depend on those details.
-        return function () {
-          // $FlowFixMe[incompatible-call]: We don't want to use rest arguments since we transpile the code.
-          return fn.apply(null, arguments);
-        };
-      }
+    function noopCache(fn) {
+      // On the client (i.e. not a Server Components environment) `cache` has
+      // no caching behavior. We just return the function as-is.
+      //
+      // We intend to implement client caching in a future major release. In the
+      // meantime, it's only exposed as an API so that Shared Components can use
+      // per-request caching on the server without breaking on the client. But it
+      // does mean they need to be aware of the behavioral difference.
+      //
+      // The rest of the behavior is the same as the server implementation — it
+      // returns a new reference, extra properties like `displayName` are not
+      // preserved, the length of the new function is 0, etc. That way apps can't
+      // accidentally depend on those details.
+      return function () {
+        // $FlowFixMe[incompatible-call]: We don't want to use rest arguments since we transpile the code.
+        return fn.apply(null, arguments);
+      };
     }
+    var cache = noopCache;
 
     function resolveDispatcher() {
       var dispatcher = ReactCurrentDispatcher.current;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

@@ -548,4 +548,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-canary-91caa96e4-20240206";
+exports.version = "18.3.0-canary-a1ace9d3c-20240206";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

@@ -544,7 +544,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-canary-91caa96e4-20240206";
+exports.version = "18.3.0-canary-a1ace9d3c-20240206";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

@@ -1 +1 @@
-91caa96e4261704d42333f5e02ba32d870379fc4
+a1ace9d3c2a0fc53703f11e30f32d0a009c5a8c9