Skip to content

Commit 3168e08

Browse files
authored
[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)
So we can test the feature.
1 parent 2805f0e commit 3168e08

File tree

7 files changed

+19
-7
lines changed

7 files changed

+19
-7
lines changed

packages/react-dom/src/client/ReactDOMRootFB.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ function wwwOnCaughtError(
126126

127127
defaultOnCaughtError(error, errorInfo);
128128
}
129+
const noopOnDefaultTransitionIndicator = noop;
129130

130131
export function createRoot(
131132
container: Element | Document | DocumentFragment,
@@ -137,6 +138,7 @@ export function createRoot(
137138
({
138139
onUncaughtError: wwwOnUncaughtError,
139140
onCaughtError: wwwOnCaughtError,
141+
onDefaultTransitionIndicator: noopOnDefaultTransitionIndicator,
140142
}: any),
141143
options,
142144
),
@@ -155,6 +157,7 @@ export function hydrateRoot(
155157
({
156158
onUncaughtError: wwwOnUncaughtError,
157159
onCaughtError: wwwOnCaughtError,
160+
onDefaultTransitionIndicator: noopOnDefaultTransitionIndicator,
158161
}: any),
159162
options,
160163
),
@@ -211,7 +214,6 @@ function getReactRootElementInContainer(container: any) {
211214
// This isn't reachable because onRecoverableError isn't called in the
212215
// legacy API.
213216
const noopOnRecoverableError = noop;
214-
const noopOnDefaultTransitionIndicator = noop;
215217

216218
function legacyCreateRootFromDOMContainer(
217219
container: Container,

packages/react-native-renderer/src/ReactFabric.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ import {
4646
createPublicRootInstance,
4747
type PublicRootInstance,
4848
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
49-
import {disableLegacyMode} from 'shared/ReactFeatureFlags';
49+
import {
50+
disableLegacyMode,
51+
enableDefaultTransitionIndicator,
52+
} from 'shared/ReactFeatureFlags';
5053

5154
if (typeof ReactFiberErrorDialog.showErrorDialog !== 'function') {
5255
throw new Error(
@@ -132,6 +135,12 @@ function render(
132135
if (options && options.onRecoverableError !== undefined) {
133136
onRecoverableError = options.onRecoverableError;
134137
}
138+
let onDefaultTransitionIndicator = nativeOnDefaultTransitionIndicator;
139+
if (enableDefaultTransitionIndicator) {
140+
if (options && options.onDefaultTransitionIndicator !== undefined) {
141+
onDefaultTransitionIndicator = options.onDefaultTransitionIndicator;
142+
}
143+
}
135144

136145
const publicRootInstance = createPublicRootInstance(containerTag);
137146
const rootInstance = {
@@ -151,7 +160,7 @@ function render(
151160
onUncaughtError,
152161
onCaughtError,
153162
onRecoverableError,
154-
nativeOnDefaultTransitionIndicator,
163+
onDefaultTransitionIndicator,
155164
null,
156165
);
157166

packages/react-native-renderer/src/ReactNativeTypes.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ export type RenderRootOptions = {
134134
error: mixed,
135135
errorInfo: {+componentStack?: ?string},
136136
) => void,
137+
onDefaultTransitionIndicator?: () => void | (() => void),
137138
};
138139

139140
/**

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const enableSuspenseyImages: boolean = false;
7979
export const enableFizzBlockingRender: boolean = true;
8080
export const enableSrcObject: boolean = false;
8181
export const enableHydrationChangeEvent: boolean = true;
82-
export const enableDefaultTransitionIndicator: boolean = false;
82+
export const enableDefaultTransitionIndicator: boolean = true;
8383
export const ownerStackLimit = 1e4;
8484
export const enableComponentPerformanceTrack: boolean =
8585
__PROFILE__ && dynamicFlags.enableComponentPerformanceTrack;

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export const enableSuspenseyImages = false;
6666
export const enableFizzBlockingRender = true;
6767
export const enableSrcObject = false;
6868
export const enableHydrationChangeEvent = false;
69-
export const enableDefaultTransitionIndicator = false;
69+
export const enableDefaultTransitionIndicator = true;
7070
export const enableFragmentRefs = false;
7171
export const enableFragmentRefsScrollIntoView = false;
7272
export const ownerStackLimit = 1e4;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const enableSuspenseyImages: boolean = false;
7979
export const enableFizzBlockingRender: boolean = true;
8080
export const enableSrcObject: boolean = false;
8181
export const enableHydrationChangeEvent: boolean = false;
82-
export const enableDefaultTransitionIndicator: boolean = false;
82+
export const enableDefaultTransitionIndicator: boolean = true;
8383

8484
export const enableFragmentRefs: boolean = false;
8585
export const enableFragmentRefsScrollIntoView: boolean = false;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export const enableSuspenseyImages: boolean = false;
109109
export const enableFizzBlockingRender: boolean = true;
110110
export const enableSrcObject: boolean = false;
111111
export const enableHydrationChangeEvent: boolean = false;
112-
export const enableDefaultTransitionIndicator: boolean = false;
112+
export const enableDefaultTransitionIndicator: boolean = true;
113113

114114
export const ownerStackLimit = 1e4;
115115

0 commit comments

Comments
 (0)