Skip to content

Commit 2e28c42

Browse files
committed
fix[devtools/useTransition]: don't check for dispatch property when determining if hook is stateful
1 parent 2eed132 commit 2e28c42

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

packages/react-devtools-shared/src/backend/renderer.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,22 +1419,20 @@ export function attach(
14191419

14201420
const boundHasOwnProperty = hasOwnProperty.bind(queue);
14211421

1422-
// Detect the shape of useState() or useReducer()
1422+
// Detect the shape of useState() / useReducer() / useTransition()
14231423
// using the attributes that are unique to these hooks
14241424
// but also stable (e.g. not tied to current Lanes implementation)
1425-
const isStateOrReducer =
1426-
boundHasOwnProperty('pending') &&
1427-
boundHasOwnProperty('dispatch') &&
1428-
typeof queue.dispatch === 'function';
1425+
// We don't check for dispatch property, because useTransition doesn't have it
1426+
if (boundHasOwnProperty('pending')) {
1427+
return true;
1428+
}
14291429

14301430
// Detect useSyncExternalStore()
1431-
const isSyncExternalStore =
1431+
return (
14321432
boundHasOwnProperty('value') &&
14331433
boundHasOwnProperty('getSnapshot') &&
1434-
typeof queue.getSnapshot === 'function';
1435-
1436-
// These are the only types of hooks that can schedule an update.
1437-
return isStateOrReducer || isSyncExternalStore;
1434+
typeof queue.getSnapshot === 'function'
1435+
);
14381436
}
14391437

14401438
function didStatefulHookChange(prev: any, next: any): boolean {

0 commit comments

Comments
 (0)