[flags] remove enableRemoveConsolePatches (#32425)

rickhanlonii · web-flow · commit 25677265038b · 2025-02-24T10:00:22.000-05:00
wait to merge until we sync #32376, since that enables it in some testing builds that might break
diff --git a/packages/react-reconciler/src/ReactFiberDevToolsHook.js b/packages/react-reconciler/src/ReactFiberDevToolsHook.js
@@ -36,7 +36,6 @@ import {
   log,
   unstable_setDisableYieldValue,
 } from './Scheduler';
-import {setSuppressWarning} from 'shared/consoleWithStackDev';
 
 declare const __REACT_DEVTOOLS_GLOBAL_HOOK__: Object | void;
 
@@ -191,7 +190,6 @@ export function setIsStrictModeForDevtools(newIsStrictMode: boolean) {
     // in SchedulerMock. To reduce the noise in strict mode tests,
     // suppress warnings and disable scheduler yielding during the double render
     unstable_setDisableYieldValue(newIsStrictMode);
-    setSuppressWarning(newIsStrictMode);
   }
 
   if (injectedHook && typeof injectedHook.setStrictMode === 'function') {
diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js
@@ -267,5 +267,3 @@ export const enableUpdaterTracking = __PROFILE__;
 
 // Internal only.
 export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
-
-export const enableRemoveConsolePatches = true;
diff --git a/packages/shared/consoleWithStackDev.js b/packages/shared/consoleWithStackDev.js
diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js
@@ -34,7 +34,6 @@ export const {
 
 // These two can be removed
 export const enableOwnerStacks = true;
-export const enableRemoveConsolePatches = true;
 
 // The rest of the flags are static for better dead code elimination.
 export const disableClientCache = true;
diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js
@@ -81,7 +81,6 @@ export const enableProfilerTimer = __PROFILE__;
 export const enableProfilerCommitHooks = __PROFILE__;
 export const enableProfilerNestedUpdatePhase = __PROFILE__;
 export const enableUpdaterTracking = __PROFILE__;
-export const enableRemoveConsolePatches = true;
 
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js
@@ -91,7 +91,6 @@ export const disableDefaultPropsExceptForClasses = true;
 
 export const enableObjectFiber = false;
 export const enableOwnerStacks = true;
-export const enableRemoveConsolePatches = true;
 
 // Flow magic to verify the exports of this file match the original version.
 ((((null: any): ExportsType): FeatureFlagsType): ExportsType);
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
@@ -68,7 +68,6 @@ export const enableHydrationLaneScheduling = true;
 export const enableYieldingBeforePassive = false;
 export const enableThrottledScheduling = false;
 export const enableViewTransition = false;
-export const enableRemoveConsolePatches = true;
 export const enableSwipeTransition = false;
 export const enableFastAddPropertiesInDiffing = false;
 export const enableLazyPublicInstanceInFabric = false;
diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
@@ -83,7 +83,6 @@ export const enableYieldingBeforePassive = false;
 
 export const enableThrottledScheduling = false;
 export const enableViewTransition = false;
-export const enableRemoveConsolePatches = true;
 export const enableSwipeTransition = false;
 export const enableFastAddPropertiesInDiffing = false;
 export const enableLazyPublicInstanceInFabric = false;
diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js
@@ -44,7 +44,6 @@ export const {
 
 // Can remove these two
 export const enableOwnerStacks = true;
-export const enableRemoveConsolePatches = true;
 
 export const enableProfilerTimer = __PROFILE__;
 export const enableProfilerCommitHooks = __PROFILE__;
diff --git a/packages/shared/forks/consoleWithStackDev.rn.js b/packages/shared/forks/consoleWithStackDev.rn.js
diff --git a/packages/shared/forks/consoleWithStackDev.www.js b/packages/shared/forks/consoleWithStackDev.www.js
diff --git a/scripts/babel/transform-replace-console-calls.js b/scripts/babel/transform-replace-console-calls.js
diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js
@@ -145,8 +145,6 @@ function getBabelConfig(
   isDevelopment,
   bundle
 ) {
-  const canAccessReactObject =
-    packageName === 'react' || externals.indexOf('react') !== -1;
   let options = {
     exclude: '/**/node_modules/**',
     babelrc: false,
@@ -158,21 +156,6 @@ function getBabelConfig(
   };
   if (isDevelopment) {
     options.plugins.push(...babelToES5Plugins);
-    if (
-      bundleType === FB_WWW_DEV ||
-      bundleType === RN_OSS_DEV ||
-      bundleType === RN_FB_DEV
-    ) {
-      options.plugins.push(
-        // Turn console.error/warn() into a custom wrapper
-        [
-          require('../babel/transform-replace-console-calls'),
-          {
-            shouldError: !canAccessReactObject,
-          },
-        ]
-      );
-    }
   }
   if (updateBabelOptions) {
     options = updateBabelOptions(options);
diff --git a/scripts/rollup/forks.js b/scripts/rollup/forks.js
@@ -209,18 +209,6 @@ const forks = Object.freeze({
     }
   },
 
-  './packages/shared/consoleWithStackDev.js': (bundleType, entry) => {
-    switch (bundleType) {
-      case FB_WWW_DEV:
-        return './packages/shared/forks/consoleWithStackDev.www.js';
-      case RN_OSS_DEV:
-      case RN_FB_DEV:
-        return './packages/shared/forks/consoleWithStackDev.rn.js';
-      default:
-        return null;
-    }
-  },
-
   './packages/shared/DefaultPrepareStackTrace.js': (
     bundleType,
     entry,
