Remove shouldSetAttribute()

Its naming was confusing and it was used all over the place instead of more specific checks.
Now that we only have one call site, we might as well inline and get rid of it.

Author: gaearon

packages/react-dom/src/client/ReactDOMFiberComponent.js

@@ -24,7 +24,11 @@ import setTextContent from './setTextContent';
 import {listenTo, trapBubbledEvent} from '../events/ReactBrowserEventEmitter';
 import * as CSSPropertyOperations from '../shared/CSSPropertyOperations';
 import {Namespaces, getIntrinsicNamespace} from '../shared/DOMNamespaces';
-import {getPropertyInfo, shouldSetAttribute} from '../shared/DOMProperty';
+import {
+  getPropertyInfo,
+  shouldSkipAttribute,
+  shouldTreatAttributeValueAsNull,
+} from '../shared/DOMProperty';
 import assertValidProps from '../shared/assertValidProps';
 import {DOCUMENT_NODE, DOCUMENT_FRAGMENT_NODE} from '../shared/HTMLNodeType';
 import isCustomComponent from '../shared/isCustomComponent';
@@ -1000,7 +1004,14 @@ export function diffHydratedProperties(
         if (nextProp !== serverValue) {
           warnForPropDifference(propKey, serverValue, nextProp);
         }
-      } else if (shouldSetAttribute(propKey, nextProp, isCustomComponentTag)) {
+      } else if (
+        !shouldSkipAttribute(propKey, isCustomComponentTag) &&
+        !shouldTreatAttributeValueAsNull(
+          propKey,
+          nextProp,
+          isCustomComponentTag,
+        )
+      ) {
         if ((propertyInfo = getPropertyInfo(propKey))) {
           // $FlowFixMe - Should be inferred as not undefined.
           extraAttributeNames.delete(propertyInfo.attributeName);

packages/react-dom/src/server/DOMMarkupOperations.js

@@ -41,7 +41,7 @@ export function createMarkupForRoot() {
  * @return {?string} Markup string, or null if the property was invalid.
  */
 export function createMarkupForProperty(name, value) {
-  if (name !== 'style' && shouldSkipAttribute(name)) {
+  if (name !== 'style' && shouldSkipAttribute(name, false)) {
     return '';
   }
   if (shouldTreatAttributeValueAsNull(name, value, false)) {

packages/react-dom/src/shared/DOMProperty.js

@@ -234,16 +234,6 @@ export function shouldTreatAttributeValueAsNull(
   return false;
 }
 
-export function shouldSetAttribute(name, value, isCustomComponentTag) {
-  if (shouldSkipAttribute(name, isCustomComponentTag)) {
-    return false;
-  }
-  if (shouldTreatAttributeValueAsNull(name, value, isCustomComponentTag)) {
-    return false;
-  }
-  return true;
-}
-
 export function getPropertyInfo(name) {
   return properties.hasOwnProperty(name) ? properties[name] : null;
 }