Skip to content

Commit 1e507ec

Browse files
committed
[cleanup] remove unused values from ReactFeatureFlags.www-dynamic
These values are never imported into `ReactFeatureFlags.www.js`, so they're never used: - allowConcurrentByDefault - consoleManagedByDevToolsDuringStrictMode These values are never set in the WWW module, so they're always `undefined` on www: - createRootStrictEffectsByDefault - deferRenderPhaseUpdateToNextBatch - enableClientRenderFallbackOnTextMismatch
1 parent 28a574e commit 1e507ec

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ export const enableProfilerNestedUpdateScheduledHook = __VARIANT__;
2424
export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
2525
export const enableLazyContextPropagation = __VARIANT__;
2626
export const enableSyncDefaultUpdates = __VARIANT__;
27-
export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
2827
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = __VARIANT__;
29-
export const enableClientRenderFallbackOnTextMismatch = __VARIANT__;
3028
export const enableTransitionTracing = __VARIANT__;
3129
// Enable this flag to help with concurrent mode debugging.
3230
// It logs information to the console about React scheduling, rendering, and commit phases.
@@ -36,16 +34,6 @@ export const enableDebugTracing = __EXPERIMENTAL__;
3634

3735
export const enableSchedulingProfiler = __VARIANT__;
3836

39-
// This only has an effect in the new reconciler. But also, the new reconciler
40-
// is only enabled when __VARIANT__ is true. So this is set to the opposite of
41-
// __VARIANT__ so that it's `false` when running against the new reconciler.
42-
// Ideally we would test both against the new reconciler, but until then, we
43-
// should test the value that is used in www. Which is `false`.
44-
//
45-
// Once Lanes has landed in both reconciler forks, we'll get coverage of
46-
// both branches.
47-
export const deferRenderPhaseUpdateToNextBatch = !__VARIANT__;
48-
4937
// These are already tested in both modes using the build type dimension,
5038
// so we don't need to use __VARIANT__ to get extra coverage.
5139
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
@@ -56,7 +44,5 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
5644
export const enableTrustedTypesIntegration = false;
5745
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
5846
export const disableNativeComponentFrames = false;
59-
export const createRootStrictEffectsByDefault = false;
60-
export const allowConcurrentByDefault = true;
6147
// You probably *don't* want to add more hardcoded ones.
6248
// Instead, try to add them above with the __VARIANT__ value.

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ export const {
2222
replayFailedUnitOfWorkWithInvokeGuardedCallback,
2323
enableFilterEmptyStringAttributesDOM,
2424
enableLegacyFBSupport,
25-
deferRenderPhaseUpdateToNextBatch,
2625
enableDebugTracing,
2726
skipUnmountedBoundaries,
28-
createRootStrictEffectsByDefault,
2927
enableUseRefAccessWarning,
3028
disableNativeComponentFrames,
3129
disableSchedulerTimeoutInWorkLoop,
3230
enableLazyContextPropagation,
3331
enableSyncDefaultUpdates,
3432
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
35-
enableClientRenderFallbackOnTextMismatch,
3633
enableTransitionTracing,
3734
} = dynamicFeatureFlags;
3835

@@ -47,6 +44,8 @@ export const enableProfilerNestedUpdateScheduledHook: boolean =
4744
__PROFILE__ && dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
4845
export const enableUpdaterTracking = __PROFILE__;
4946

47+
export const createRootStrictEffectsByDefault = false;
48+
export const deferRenderPhaseUpdateToNextBatch = false;
5049
export const enableSuspenseAvoidThisFallback = true;
5150
export const enableSuspenseAvoidThisFallbackFizz = false;
5251
export const enableCPUSuspense = true;
@@ -55,6 +54,7 @@ export const enableUseHook = true;
5554
export const enableUseMemoCacheHook = true;
5655
export const enableUseEventHook = true;
5756
export const enableHostSingletons = true;
57+
export const enableClientRenderFallbackOnTextMismatch = false;
5858

5959
// Logs additional User Timing API marks for use with an experimental profiling tool.
6060
export const enableSchedulingProfiler: boolean =

0 commit comments

Comments
 (0)