Move ReactServerSharedInternals on to ReactSharedInternalsServer

Really the top level secret export should just be forked into two different versions. This was just trying to move some earlier than others.
facebook · Apr 8, 2024 · 1ddcf9e · 1ddcf9e
1 parent b88c7ba
commit 1ddcf9e
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 77 deletions.
diff --git a/packages/react-server/src/ReactFlightServer.js b/packages/react-server/src/ReactFlightServer.js
@@ -111,7 +111,6 @@ import {
 import type {SharedStateServer} from 'react/src/ReactSharedInternalsServer';
 import ReactSharedInternalsImpl from 'shared/ReactSharedInternals';
 const ReactSharedInternals: SharedStateServer = (ReactSharedInternalsImpl: any);
-import ReactServerSharedInternals from './ReactServerSharedInternals';
 import isArray from 'shared/isArray';
 import getPrototypeOf from 'shared/getPrototypeOf';
 import binaryToComparableString from 'shared/binaryToComparableString';
@@ -307,7 +306,7 @@ const {
   TaintRegistryValues,
   TaintRegistryByteLengths,
   TaintRegistryPendingRequests,
-} = ReactServerSharedInternals;
+} = ReactSharedInternals;
 
 function throwTaintViolation(message: string) {
   // eslint-disable-next-line react-internal/prod-error-codes

diff --git a/packages/react-server/src/ReactServerSharedInternals.js b/packages/react-server/src/ReactServerSharedInternals.js
diff --git a/packages/react/src/ReactServer.experimental.js b/packages/react/src/ReactServer.experimental.js
@@ -12,8 +12,6 @@ import './ReactFetch';
 
 export {default as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactSharedInternalsServer';
 
-export {default as __SECRET_SERVER_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactServerSharedInternals';
-
 import {forEach, map, count, toArray, only} from './ReactChildren';
 import {
   REACT_FRAGMENT_TYPE,

diff --git a/packages/react/src/ReactServer.js b/packages/react/src/ReactServer.js
@@ -12,8 +12,6 @@ import './ReactFetch';
 
 export {default as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactSharedInternalsServer';
 
-export {default as __SECRET_SERVER_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactServerSharedInternals';
-
 import {forEach, map, count, toArray, only} from './ReactChildren';
 import {
   REACT_FRAGMENT_TYPE,

diff --git a/packages/react/src/ReactServerSharedInternals.js b/packages/react/src/ReactServerSharedInternals.js
diff --git a/packages/react/src/ReactSharedInternalsServer.js b/packages/react/src/ReactSharedInternalsServer.js
@@ -11,12 +11,31 @@ import type {Dispatcher} from 'react-reconciler/src/ReactInternalTypes';
 import type {CacheDispatcher} from 'react-reconciler/src/ReactInternalTypes';
 import type {ReactComponentInfo} from 'shared/ReactTypes';
 
-import {disableStringRefs} from 'shared/ReactFeatureFlags';
+import type {
+  Reference,
+  TaintEntry,
+  RequestCleanupQueue,
+} from './ReactTaintRegistry';
+
+import {
+  TaintRegistryObjects,
+  TaintRegistryValues,
+  TaintRegistryByteLengths,
+  TaintRegistryPendingRequests,
+} from './ReactTaintRegistry';
+
+import {disableStringRefs, enableTaint} from 'shared/ReactFeatureFlags';
 
 export type SharedStateServer = {
   H: null | Dispatcher, // ReactCurrentDispatcher for Hooks
   C: null | CacheDispatcher, // ReactCurrentCache for Cache
 
+  // enableTaint
+  TaintRegistryObjects: WeakMap<Reference, string>,
+  TaintRegistryValues: Map<string | bigint, TaintEntry>,
+  TaintRegistryByteLengths: Set<number>,
+  TaintRegistryPendingRequests: Set<RequestCleanupQueue>,
+
   // DEV-only-ish
   owner: null | ReactComponentInfo, // ReactCurrentOwner is ReactComponentInfo in Flight, null in Fizz. Fiber/Fizz uses SharedStateClient.
 
@@ -33,6 +52,14 @@ const ReactSharedInternals: SharedStateServer = ({
   C: null,
 }: any);
 
+if (enableTaint) {
+  ReactSharedInternals.TaintRegistryObjects = TaintRegistryObjects;
+  ReactSharedInternals.TaintRegistryValues = TaintRegistryValues;
+  ReactSharedInternals.TaintRegistryByteLengths = TaintRegistryByteLengths;
+  ReactSharedInternals.TaintRegistryPendingRequests =
+    TaintRegistryPendingRequests;
+}
+
 if (__DEV__ || !disableStringRefs) {
   ReactSharedInternals.owner = null;
 }

diff --git a/packages/react/src/ReactTaint.js b/packages/react/src/ReactTaint.js
@@ -13,13 +13,13 @@ import getPrototypeOf from 'shared/getPrototypeOf';
 
 import binaryToComparableString from 'shared/binaryToComparableString';
 
-import ReactServerSharedInternals from './ReactServerSharedInternals';
+import ReactSharedInternals from './ReactSharedInternalsServer';
 const {
   TaintRegistryObjects,
   TaintRegistryValues,
   TaintRegistryByteLengths,
   TaintRegistryPendingRequests,
-} = ReactServerSharedInternals;
+} = ReactSharedInternals;
 
 interface Reference {}