Skip to content

Commit 1d35589

Browse files
authored
Disable deferRenderPhaseUpdateToNextBatch by default (#21605)
We're still experimenting with this and it causes a breaking behavior for setState in componentWillMount/componentWillReceiveProps atm.
1 parent a896464 commit 1d35589

8 files changed

+8
-8
lines changed

packages/shared/ReactFeatureFlags.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export const enableLegacyFBSupport = false;
158158
// not currently rendering. We treat them the same as if they came from an
159159
// interleaved event. Remove this flag once we have migrated to the
160160
// new behavior.
161-
export const deferRenderPhaseUpdateToNextBatch = true;
161+
export const deferRenderPhaseUpdateToNextBatch = false;
162162

163163
export const enableUseRefAccessWarning = false;
164164

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export const deletedTreeCleanUpLevel = 1;
5050
export const enableSuspenseLayoutEffectSemantics = false;
5151

5252
export const enableNewReconciler = false;
53-
export const deferRenderPhaseUpdateToNextBatch = true;
53+
export const deferRenderPhaseUpdateToNextBatch = false;
5454

5555
export const enableStrictEffects = __DEV__;
5656
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = false;
5555
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = false;
5555
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = false;
5555
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = true;
5555
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.testing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = false;
5555
export const createRootStrictEffectsByDefault = false;

packages/shared/forks/ReactFeatureFlags.testing.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
4949
export const enableSuspenseLayoutEffectSemantics = false;
5050

5151
export const enableNewReconciler = false;
52-
export const deferRenderPhaseUpdateToNextBatch = true;
52+
export const deferRenderPhaseUpdateToNextBatch = false;
5353

5454
export const enableStrictEffects = false;
5555
export const createRootStrictEffectsByDefault = false;

0 commit comments

Comments
 (0)