Commit 1c9b138
authored
Don't serialize chunk ids for Hint and Console rows (#31671)
Hints and Console logs are side-effects and don't belong to any
particular value. They're `void`. Therefore they don't need a row ID.
In the current parsing scheme it's ok to omit the id. It just becomes
`0` which is the initial value which is then unused for these row types.
So it looks like:
```
:HP[...]
:W[...]
0:{...}
```
We could patch the parsing to encode the tag in the ID so it's more like
the ID is the target of the side-effect.
```
H:P[...]
W:[...]
0:{...}
```
Or move the tagging to the beginning like it used to be.
But this seems simple enough for now.1 parent de68d2f commit 1c9b138
1 file changed
+3
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | 216 | | |
220 | | - | |
| 217 | + | |
221 | 218 | | |
222 | 219 | | |
223 | 220 | | |
| |||
3227 | 3224 | | |
3228 | 3225 | | |
3229 | 3226 | | |
3230 | | - | |
3231 | | - | |
| 3227 | + | |
3232 | 3228 | | |
3233 | 3229 | | |
3234 | 3230 | | |
| |||
3764 | 3760 | | |
3765 | 3761 | | |
3766 | 3762 | | |
3767 | | - | |
3768 | 3763 | | |
3769 | 3764 | | |
3770 | 3765 | | |
| |||
3828 | 3823 | | |
3829 | 3824 | | |
3830 | 3825 | | |
3831 | | - | |
| 3826 | + | |
3832 | 3827 | | |
3833 | 3828 | | |
3834 | 3829 | | |
| |||
0 commit comments