[compiler] Migrate compiler packages to tsup

Currently in the `compiler` workspace, we invoke esbuild directly to build most packages (with the exception of `snap`). This has been mostly fine, but does not allow us to do things like generate type declaration files.

I would like #32416 to be able to consume the merged eslint-plugin-react-compiler from source rather than via npm, and one of the things that has come up from my exploration in that stack using the compiler from source is that babel-plugin-react-compiler is missing type declarations.

I still need to test if this unblocks #32416 but this stack can be landed independently though as we could probably just release type declarations on npm. No one should be using the compiler directly, but if they really wanted to, lack of type declarations would not stop them (cf React secret internals).

Note that I still kept esbuild as we still use it directly for forgive.

Author: poteto

compiler/package.json

@@ -37,6 +37,7 @@
     "prettier-plugin-hermes-parser": "^0.26.0",
     "prompt-promise": "^1.0.3",
     "rimraf": "^5.0.10",
+    "tsup": "^8.4.0",
     "typescript": "^5.4.3",
     "wait-on": "^7.2.0",
     "yargs": "^17.7.2"

compiler/packages/babel-plugin-react-compiler/package.json

@@ -9,15 +9,15 @@
     "!*.tsbuildinfo"
   ],
   "scripts": {
-    "build": "rimraf dist && scripts/build.js",
+    "build": "rimraf dist && tsup",
     "test": "./scripts/link-react-compiler-runtime.sh && yarn snap:ci",
     "jest": "yarn build && ts-node node_modules/.bin/jest",
     "snap": "node ../snap/dist/main.js",
     "snap:build": "yarn workspace snap run build",
     "snap:ci": "yarn snap:build && yarn snap",
     "ts:analyze-trace": "scripts/ts-analyze-trace.sh",
     "lint": "yarn eslint src",
-    "watch": "scripts/build.js --watch"
+    "watch": "yarn build --watch"
   },
   "dependencies": {
     "@babel/types": "^7.19.0"

compiler/packages/babel-plugin-react-compiler/scripts/build.js

@@ -5,8 +5,6 @@
     "moduleResolution": "Bundler",
     "rootDir": "src",
     "outDir": "dist",
-    // https://github.com/microsoft/TypeScript/issues/30925
-    "tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
     "jsx": "react-jsxdev",
     // weaken strictness from preset
     "importsNotUsedAsValues": "remove",
@@ -16,7 +14,6 @@
     "target": "ES2015",
     // ideally turn off only during dev, or on a per-file basis
     "noUnusedLocals": false,
-    "composite": true,
     "removeComments": true
   },
   "exclude": [

compiler/packages/babel-plugin-react-compiler/tsconfig.json

@@ -0,0 +1,29 @@
+import {defineConfig} from 'tsup';
+
+export default defineConfig({
+  entry: ['./src/index.ts'],
+  outDir: './dist',
+  external: ['@babel/types'],
+  splitting: false,
+  sourcemap: false,
+  dts: true,
+  bundle: true,
+  format: 'cjs',
+  platform: 'node',
+  banner: {
+    js: `/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @lightSyntaxTransform
+ * @noflow
+ * @nolint
+ * @preventMunge
+ * @preserve-invariant-messages
+ */
+
+"use no memo";`,
+  },
+});

compiler/packages/babel-plugin-react-compiler/tsup.config.ts

@@ -4,9 +4,9 @@
   "description": "ESLint plugin to display errors found by the React compiler.",
   "main": "dist/index.js",
   "scripts": {
-    "build": "rimraf dist && scripts/build.js",
-    "test": "tsc && jest",
-    "watch": "scripts/build.js --watch"
+    "build": "rimraf dist && tsup",
+    "test": "jest",
+    "watch": "yarn build --watch"
   },
   "files": [
     "dist"

compiler/packages/eslint-plugin-react-compiler/package.json

@@ -7,22 +7,27 @@
 
 import ReactCompilerRule from './rules/ReactCompilerRule';
 
-module.exports = {
-  rules: {
-    'react-compiler': ReactCompilerRule,
-  },
-  configs: {
-    recommended: {
-      plugins: {
-        'react-compiler': {
-          rules: {
-            'react-compiler': ReactCompilerRule,
-          },
+const meta = {
+  name: 'eslint-plugin-react-compiler',
+};
+
+const rules = {
+  'react-compiler': ReactCompilerRule,
+};
+
+const configs = {
+  recommended: {
+    plugins: {
+      'react-compiler': {
+        rules: {
+          'react-compiler': ReactCompilerRule,
         },
       },
-      rules: {
-        'react-compiler/react-compiler': 'error',
-      },
+    },
+    rules: {
+      'react-compiler/react-compiler': 'error',
     },
   },
 };
+
+export {configs, rules, meta};

compiler/packages/eslint-plugin-react-compiler/scripts/build.js

@@ -6,9 +6,6 @@
     "rootDir": "../",
     "noEmit": true,
     "jsx": "react-jsxdev",
-    "paths": {
-      "*": ["./src/types/*"]
-    },
 
     // weaken strictness from preset
     "importsNotUsedAsValues": "remove",

compiler/packages/eslint-plugin-react-compiler/src/index.ts

@@ -0,0 +1,35 @@
+import {defineConfig} from 'tsup';
+
+export default defineConfig({
+  entry: ['./src/index.ts'],
+  outDir: './dist',
+  external: [
+    '@babel/core',
+    '@babel/plugin-proposal-private-methods',
+    'hermes-parser',
+    'zod',
+    'zod-validation-error',
+  ],
+  splitting: false,
+  sourcemap: false,
+  dts: true,
+  bundle: true,
+  format: 'cjs',
+  platform: 'node',
+  banner: {
+    js: `/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @lightSyntaxTransform
+ * @noflow
+ * @nolint
+ * @preventMunge
+ * @preserve-invariant-messages
+ */
+
+"use no memo";`,
+  },
+});