Skip to content

Commit

Permalink
Split out Edge and Node implementations of the Flight Client (#26187)
Browse files Browse the repository at this point in the history
This splits out the Edge and Node implementations of Flight Client into
their own implementations. The Node implementation now takes a Node
Stream as input.

I removed the bundler config from the Browser variant because you're
never supposed to use that in the browser since it's only for SSR.
Similarly, it's required on the server. This also enables generating a
SSR manifest from the Webpack plugin. This is necessary for SSR so that
you can reverse look up what a client module is called on the server.

I also removed the option to pass a callServer from the server. We might
want to add it back in the future but basically, we don't recommend
calling Server Functions from render for initial render because if that
happened client-side it would be a client-side waterfall. If it's never
called in initial render, then it also shouldn't ever happen during SSR.
This might be considered too restrictive.

~This also compiles the unbundled packages as ESM. This isn't strictly
necessary because we only need access to dynamic import to load the
modules but we don't have any other build options that leave
`import(...)` intact, and seems appropriate that this would also be an
ESM module.~ Went with `import(...)` in CJS instead.

DiffTrain build for commit 60144a0.
  • Loading branch information
sebmarkbage committed Feb 21, 2023
1 parent 1041fb1 commit 186e383
Show file tree
Hide file tree
Showing 28 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
70b0bbda767ed016925889e8952b10f49921c0cf
60144a04da7970e30266f591dbcd67afe1097e41
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
70b0bbda767ed016925889e8952b10f49921c0cf
60144a04da7970e30266f591dbcd67afe1097e41
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
exports.version = "18.3.0-www-classic-60144a04d-20230221";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
exports.version = "18.3.0-www-modern-60144a04d-20230221";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
exports.version = "18.3.0-www-classic-60144a04d-20230221";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
exports.version = "18.3.0-www-modern-60144a04d-20230221";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-70b0bbda7-20230221",
version: "18.3.0-www-classic-60144a04d-20230221",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1301 = {
Expand Down Expand Up @@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-70b0bbda7-20230221",
version: "18.3.0-www-modern-60144a04d-20230221",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1281 = {
Expand Down Expand Up @@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -41996,7 +41996,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -41600,7 +41600,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15469,7 +15469,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1742 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-70b0bbda7-20230221",
version: "18.3.0-www-classic-60144a04d-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2109 = {
Expand Down Expand Up @@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -14998,7 +14998,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1701 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-70b0bbda7-20230221",
version: "18.3.0-www-modern-60144a04d-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2073 = {
Expand Down Expand Up @@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16239,7 +16239,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-70b0bbda7-20230221",
version: "18.3.0-www-classic-60144a04d-20230221",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15758,7 +15758,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-70b0bbda7-20230221",
version: "18.3.0-www-modern-60144a04d-20230221",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
exports.version = "18.3.0-www-classic-60144a04d-20230221";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
exports.version = "18.3.0-www-modern-60144a04d-20230221";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31233,7 +31233,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -37624,7 +37624,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -11541,7 +11541,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1536 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-70b0bbda7-20230221",
version: "18.3.0-www-classic-60144a04d-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2059 = {
Expand Down Expand Up @@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13856,7 +13856,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1653 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-70b0bbda7-20230221",
version: "18.3.0-www-modern-60144a04d-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2033 = {
Expand Down Expand Up @@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-70b0bbda7-20230221";
exports.version = "18.3.0-next-60144a04d-20230221";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";

// Might add PROFILE later.

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";

// Might add PROFILE later.

Expand Down

0 comments on commit 186e383

Please sign in to comment.