Commit 1727bec
committed
Upgrade tests to use react/jsx-runtime (#28252)
Instead of createElement.
We should have done this when we initially released jsx-runtime but
better late than never. The general principle is that our tests should
be written using the most up-to-date idioms that we recommend for users,
except when explicitly testing an edge case or legacy behavior, like for
backwards compatibility.
Most of the diff is related to tweaking test output and isn't very
interesting.
I did have to workaround an issue related to component stacks. The
component stack logic depends on shared state that lives in the React
module. The problem is that most of our tests reset the React module
state and re-require a fresh instance of React, React DOM, etc. However,
the JSX runtime is not re-required because it's injected by the compiler
as a static import. This means its copy of the shared state is no longer
the same as the one used by React, causing any warning logged by the JSX
runtime to not include a component stack. (This same issue also breaks
string refs, but since we're removing those soon I'm not so concerned
about that.) The solution I went with for now is to mock the JSX runtime
with a proxy that re-requires the module on every function invocation. I
don't love this but it will have to do for now. What we should really do
is migrate our tests away from manually resetting the module state and
use import syntax instead.
DiffTrain build for commit 952aa74.1 parent 3d453eb commit 1727bec
File tree
7 files changed
+9
-9
lines changed- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
7 files changed
+9
-9
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25600 | 25600 | | |
25601 | 25601 | | |
25602 | 25602 | | |
25603 | | - | |
| 25603 | + | |
25604 | 25604 | | |
25605 | 25605 | | |
25606 | 25606 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9150 | 9150 | | |
9151 | 9151 | | |
9152 | 9152 | | |
9153 | | - | |
| 9153 | + | |
9154 | 9154 | | |
9155 | 9155 | | |
9156 | 9156 | | |
| |||
9181 | 9181 | | |
9182 | 9182 | | |
9183 | 9183 | | |
9184 | | - | |
| 9184 | + | |
9185 | 9185 | | |
9186 | 9186 | | |
9187 | 9187 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9578 | 9578 | | |
9579 | 9579 | | |
9580 | 9580 | | |
9581 | | - | |
| 9581 | + | |
9582 | 9582 | | |
9583 | 9583 | | |
9584 | 9584 | | |
| |||
9609 | 9609 | | |
9610 | 9610 | | |
9611 | 9611 | | |
9612 | | - | |
| 9612 | + | |
9613 | 9613 | | |
9614 | 9614 | | |
9615 | 9615 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
546 | | - | |
| 546 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
539 | 539 | | |
540 | 540 | | |
541 | 541 | | |
542 | | - | |
| 542 | + | |
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments