Skip to content

Commit 0adf8ac

Browse files
committed
better
1 parent cc2794d commit 0adf8ac

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

src/renderers/shared/fiber/ReactDebugFiberPerf.js

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -31,31 +31,24 @@ let isProfiling = true;
3131

3232
// TODO: individual render methods
3333

34-
function getLabel(fiber) {
34+
function getMarkName(fiber) {
35+
return `react:${fiber._debugID}`;
36+
}
37+
38+
function shouldIgnore(fiber) {
3539
switch (fiber.tag) {
3640
case HostRoot:
37-
return '(root)';
41+
case HostComponent:
3842
case HostText:
39-
return '(text)';
4043
case HostPortal:
41-
return '(portal)';
4244
case YieldComponent:
43-
return '(yield)';
4445
case Fragment:
45-
return '(fragment)';
46+
return true;
4647
default:
47-
return getComponentName(fiber);
48+
return false;
4849
}
4950
}
5051

51-
function getMarkName(fiber) {
52-
return `react:${fiber._debugID}`;
53-
}
54-
55-
function shouldIgnore(fiber) {
56-
return typeof fiber.type === 'string';
57-
}
58-
5952
let bailedFibers = new Set();
6053

6154
function markBeginWork(fiber) {
@@ -80,7 +73,7 @@ function markCompleteWork(fiber) {
8073
if (bailedFibers.has(fiber)) {
8174
bailedFibers.delete(fiber);
8275
} else {
83-
performance.measure(getLabel(fiber), getMarkName(fiber));
76+
performance.measure(getComponentName(fiber), getMarkName(fiber));
8477
}
8578
}
8679

@@ -89,15 +82,15 @@ function markWillCommit() {
8982
}
9083

9184
function markDidCommit() {
92-
performance.measure('React: Commit Tree', 'react:commit');
85+
performance.measure('Commit React Tree', 'react:commit');
9386
}
9487

9588
function markWillReconcile() {
9689
performance.mark('react:reconcile');
9790
}
9891

9992
function markDidReconcile() {
100-
performance.measure('React: Reconcile Tree', 'react:reconcile');
93+
performance.measure('Reconcile React Tree', 'react:reconcile');
10194
}
10295

10396
exports.markBeginWork = markBeginWork;

0 commit comments

Comments
 (0)