You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Flight] Instrument the Promise for Async Module instead of using a Module Cache (#26985)
Currently, since we use a module cache for async modules, it doesn't
automatically get updated when the module registry gets updated (HMR).
This technique ensures that if Webpack replaces the module (HMR) then
we'll get the new Promise when we require it again.
This technique doesn't work for ESM and probably not Vite since ESM will
provide a new Promise each time you call `import()` but in the
Webpack/CJS approach this Promise is an entry in the module cache and
not a promise for the entry.
I tried to replicate the original issue in the fixture but it's tricky
to replicate because 1) we can't really use async modules the same way
without compiling both server and client 2) even then I'm not quite sure
how to repro the HMR issue.
DiffTrain build for commit 5945e06.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -23991,7 +23991,7 @@ function createFiberRoot(
23991
23991
return root;
23992
23992
}
23993
23993
23994
-
var ReactVersion = "18.3.0-canary-a1c62b8a7-20230627";
23994
+
var ReactVersion = "18.3.0-canary-5945e068a-20230628";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -8646,7 +8646,7 @@ var devToolsConfig$jscomp$inline_1036 = {
8646
8646
throwError("TestRenderer does not support findFiberByHostInstance()");
8647
8647
},
8648
8648
bundleType: 0,
8649
-
version: "18.3.0-canary-a1c62b8a7-20230627",
8649
+
version: "18.3.0-canary-5945e068a-20230628",
8650
8650
rendererPackageName: "react-test-renderer"
8651
8651
};
8652
8652
varinternals$jscomp$inline_1238={
@@ -8677,7 +8677,7 @@ var internals$jscomp$inline_1238 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9072,7 +9072,7 @@ var devToolsConfig$jscomp$inline_1078 = {
9072
9072
throwError("TestRenderer does not support findFiberByHostInstance()");
9073
9073
},
9074
9074
bundleType: 0,
9075
-
version: "18.3.0-canary-a1c62b8a7-20230627",
9075
+
version: "18.3.0-canary-5945e068a-20230628",
9076
9076
rendererPackageName: "react-test-renderer"
9077
9077
};
9078
9078
varinternals$jscomp$inline_1279={
@@ -9103,7 +9103,7 @@ var internals$jscomp$inline_1279 = {
0 commit comments