Skip to content

Commit

Permalink
[ci] Standardize node version and timezones
Browse files Browse the repository at this point in the history
Quick change to standardize on a single timezone across all workflows
and to use the same version of node (18.20.1).

Also updates .nvmrc

ghstack-source-id: e1d43006ec018acfcd88444feadde1b1d260de9d
Pull Request resolved: #30323
  • Loading branch information
poteto committed Jul 12, 2024
1 parent ff3f1fa commit 064b0a0
Show file tree
Hide file tree
Showing 13 changed files with 66 additions and 31 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/compiler_playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ on:
branches: [main]
pull_request:
paths:
- "compiler/**"
- compiler/**
- .github/workflows/compiler-playground.yml

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
working-directory: compiler
Expand All @@ -20,8 +23,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/compiler_rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
env:
CARGO_TERM_COLOR: always
RUSTFLAGS: -Dwarnings
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
Expand Down
17 changes: 10 additions & 7 deletions .github/workflows/compiler_typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ on:
branches: [main]
pull_request:
paths:
- "compiler/**"
- compiler/**
- .github/workflows/compiler-typescript.yml

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
working-directory: compiler
Expand All @@ -31,8 +34,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -50,8 +53,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -74,8 +77,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/devtools_check_repro.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
issue_comment:
types: [created, edited]

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
check-repro:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/runtime_commit_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
branches: [main, meta-www, meta-fbsource]

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
download_artifacts:
runs-on: ubuntu-latest
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/runtime_fizz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
branches: [main]
pull_request:
paths-ignore:
- 'compiler/**'
- compiler/**

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
check_generated_fizz_runtime:
Expand All @@ -15,8 +18,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/runtime_flags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
branches: [main]
pull_request:
paths-ignore:
- 'compiler/**'
- compiler/**

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
flags:
Expand All @@ -15,8 +18,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/runtime_flow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
branches: [main]
pull_request:
paths-ignore:
- 'compiler/**'
- compiler/**

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
discover_flow_inline_configs:
Expand Down Expand Up @@ -34,8 +37,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/runtime_fuzz_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
inputs:
prerelease_commit_sha:
required: false

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
test_fuzz:
if: inputs.prerelease_commit_sha == ''
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/runtime_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
branches: [main]
pull_request:
paths-ignore:
- 'compiler/**'
- compiler/**

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
test:
Expand Down Expand Up @@ -44,8 +47,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
19 changes: 11 additions & 8 deletions .github/workflows/shared_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
branches: [main]
pull_request:

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
prettier:
name: Run prettier
Expand All @@ -13,8 +16,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -31,8 +34,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -49,8 +52,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -67,8 +70,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/shared_stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
# Run hourly
- cron: '0 * * * *'

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
stale:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.20.0
v18.20.1

0 comments on commit 064b0a0

Please sign in to comment.