Commit 0241d22
committed
Measure and apply names for the "new" phase (#32612)
Stacked on #32599 and #32611.
This is able to reuse the code from CommitViewTransitions for "enter",
"shared" and "layout". The difference is that for "enter"/"shared" in
the "new" phase we pass in the deletions.
For "layout" of nested boundaries we just need to measure the clones at
the same time we measure the original nodes since we haven't measured
them in a previous phase in the current approach.
With these updates, things move around more like expected in the fixture
because we're now applying the appropriate pairs to trigger individual
animations instead of just the full document cross-fade.
The "update" phase is a little more complicated and is coming soon.
DiffTrain build for [2c56037](2c56037)1 parent 9243463 commit 0241d22
File tree
34 files changed
+400
-294
lines changed- compiled/facebook-www
34 files changed
+400
-294
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1532 | 1532 | | |
1533 | 1533 | | |
1534 | 1534 | | |
1535 | | - | |
| 1535 | + | |
1536 | 1536 | | |
1537 | 1537 | | |
1538 | 1538 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1532 | 1532 | | |
1533 | 1533 | | |
1534 | 1534 | | |
1535 | | - | |
| 1535 | + | |
1536 | 1536 | | |
1537 | 1537 | | |
1538 | 1538 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
641 | 641 | | |
642 | 642 | | |
643 | 643 | | |
644 | | - | |
| 644 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
641 | 641 | | |
642 | 642 | | |
643 | 643 | | |
644 | | - | |
| 644 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
645 | 645 | | |
646 | 646 | | |
647 | 647 | | |
648 | | - | |
| 648 | + | |
649 | 649 | | |
650 | 650 | | |
651 | 651 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
645 | 645 | | |
646 | 646 | | |
647 | 647 | | |
648 | | - | |
| 648 | + | |
649 | 649 | | |
650 | 650 | | |
651 | 651 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18507 | 18507 | | |
18508 | 18508 | | |
18509 | 18509 | | |
18510 | | - | |
| 18510 | + | |
18511 | 18511 | | |
18512 | 18512 | | |
18513 | | - | |
| 18513 | + | |
18514 | 18514 | | |
18515 | 18515 | | |
18516 | 18516 | | |
| |||
18544 | 18544 | | |
18545 | 18545 | | |
18546 | 18546 | | |
18547 | | - | |
| 18547 | + | |
18548 | 18548 | | |
18549 | 18549 | | |
18550 | 18550 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18279 | 18279 | | |
18280 | 18280 | | |
18281 | 18281 | | |
18282 | | - | |
| 18282 | + | |
18283 | 18283 | | |
18284 | 18284 | | |
18285 | | - | |
| 18285 | + | |
18286 | 18286 | | |
18287 | 18287 | | |
18288 | 18288 | | |
| |||
18316 | 18316 | | |
18317 | 18317 | | |
18318 | 18318 | | |
18319 | | - | |
| 18319 | + | |
18320 | 18320 | | |
18321 | 18321 | | |
18322 | 18322 | | |
| |||
0 commit comments