Skip to content

Commit 0241d22

Browse files
committed
Measure and apply names for the "new" phase (#32612)
Stacked on #32599 and #32611. This is able to reuse the code from CommitViewTransitions for "enter", "shared" and "layout". The difference is that for "enter"/"shared" in the "new" phase we pass in the deletions. For "layout" of nested boundaries we just need to measure the clones at the same time we measure the original nodes since we haven't measured them in a previous phase in the current approach. With these updates, things move around more like expected in the fixture because we're now applying the appropriate pairs to trigger individual animations instead of just the full document cross-fade. The "update" phase is a little more complicated and is coming soon. DiffTrain build for [2c56037](2c56037)
1 parent 9243463 commit 0241d22

34 files changed

+400
-294
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2e385738a4dfd1554c146f6313b1530a09b5ce78
1+
2c560374d6276c51cfeeff7af39628058c155a13
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2e385738a4dfd1554c146f6313b1530a09b5ce78
1+
2c560374d6276c51cfeeff7af39628058c155a13

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-classic-2e385738-20250314";
1535+
exports.version = "19.1.0-www-classic-2c560374-20250314";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-modern-2e385738-20250314";
1535+
exports.version = "19.1.0-www-modern-2c560374-20250314";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-classic-2e385738-20250314";
644+
exports.version = "19.1.0-www-classic-2c560374-20250314";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-modern-2e385738-20250314";
644+
exports.version = "19.1.0-www-modern-2c560374-20250314";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-classic-2e385738-20250314";
648+
exports.version = "19.1.0-www-classic-2c560374-20250314";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-modern-2e385738-20250314";
648+
exports.version = "19.1.0-www-modern-2c560374-20250314";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18507,10 +18507,10 @@ __DEV__ &&
1850718507
(function () {
1850818508
var internals = {
1850918509
bundleType: 1,
18510-
version: "19.1.0-www-classic-2e385738-20250314",
18510+
version: "19.1.0-www-classic-2c560374-20250314",
1851118511
rendererPackageName: "react-art",
1851218512
currentDispatcherRef: ReactSharedInternals,
18513-
reconcilerVersion: "19.1.0-www-classic-2e385738-20250314"
18513+
reconcilerVersion: "19.1.0-www-classic-2c560374-20250314"
1851418514
};
1851518515
internals.overrideHookState = overrideHookState;
1851618516
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18544,7 +18544,7 @@ __DEV__ &&
1854418544
exports.Shape = Shape;
1854518545
exports.Surface = Surface;
1854618546
exports.Text = Text;
18547-
exports.version = "19.1.0-www-classic-2e385738-20250314";
18547+
exports.version = "19.1.0-www-classic-2c560374-20250314";
1854818548
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1854918549
"function" ===
1855018550
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18279,10 +18279,10 @@ __DEV__ &&
1827918279
(function () {
1828018280
var internals = {
1828118281
bundleType: 1,
18282-
version: "19.1.0-www-modern-2e385738-20250314",
18282+
version: "19.1.0-www-modern-2c560374-20250314",
1828318283
rendererPackageName: "react-art",
1828418284
currentDispatcherRef: ReactSharedInternals,
18285-
reconcilerVersion: "19.1.0-www-modern-2e385738-20250314"
18285+
reconcilerVersion: "19.1.0-www-modern-2c560374-20250314"
1828618286
};
1828718287
internals.overrideHookState = overrideHookState;
1828818288
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18316,7 +18316,7 @@ __DEV__ &&
1831618316
exports.Shape = Shape;
1831718317
exports.Surface = Surface;
1831818318
exports.Text = Text;
18319-
exports.version = "19.1.0-www-modern-2e385738-20250314";
18319+
exports.version = "19.1.0-www-modern-2c560374-20250314";
1832018320
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1832118321
"function" ===
1832218322
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)