lint: enable reportUnusedDisableDirectives and remove unused suppressions

This enables linting against unused suppressions and removes the ones that were unused.

Author: kassens

.eslintrc.js

@@ -17,6 +17,8 @@ module.exports = {
   // Stop ESLint from looking for a configuration file in parent folders
   root: true,
 
+  reportUnusedDisableDirectives: true,
+
   plugins: [
     'babel',
     'ft-flow',

packages/react-client/src/ReactFlightReplyClient.js

@@ -243,7 +243,6 @@ export function processReply(
             const partJSON = JSON.stringify(resolvedModel, resolveToJSON);
             // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
             const data: FormData = formData;
-            // eslint-disable-next-line react-internal/safe-string-coercion
             data.append(formFieldPrefix + lazyId, partJSON);
             return serializeByValueID(lazyId);
           } catch (x) {
@@ -263,7 +262,6 @@ export function processReply(
                   const partJSON = JSON.stringify(value, resolveToJSON);
                   // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
                   const data: FormData = formData;
-                  // eslint-disable-next-line react-internal/safe-string-coercion
                   data.append(formFieldPrefix + lazyId, partJSON);
                   pendingParts--;
                   if (pendingParts === 0) {
@@ -304,7 +302,6 @@ export function processReply(
               const partJSON = JSON.stringify(partValue, resolveToJSON);
               // $FlowFixMe[incompatible-type] We know it's not null because we assigned it above.
               const data: FormData = formData;
-              // eslint-disable-next-line react-internal/safe-string-coercion
               data.append(formFieldPrefix + promiseId, partJSON);
               pendingParts--;
               if (pendingParts === 0) {
@@ -459,7 +456,6 @@ export function processReply(
         }
         // The reference to this function came from the same client so we can pass it back.
         const refId = nextPartId++;
-        // eslint-disable-next-line react-internal/safe-string-coercion
         formData.set(formFieldPrefix + refId, metaDataJSON);
         return serializeServerReferenceID(refId);
       }

packages/react-client/src/forks/ReactFlightClientConfig.custom.js

@@ -42,7 +42,7 @@ export const usedWithSSR = true;
 
 export opaque type Source = mixed;
 
-export opaque type StringDecoder = mixed; // eslint-disable-line no-undef
+export opaque type StringDecoder = mixed;
 
 export const createStringDecoder = $$$config.createStringDecoder;
 export const readPartialStringChunk = $$$config.readPartialStringChunk;

packages/react-devtools-extensions/flow-typed/jest.js

@@ -146,13 +146,11 @@ type JestPromiseType = {
    * Use rejects to unwrap the reason of a rejected promise so any other
    * matcher can be chained. If the promise is fulfilled the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   rejects: JestExpectType,
   /**
    * Use resolves to unwrap the value of a fulfilled promise so any other
    * matcher can be chained. If the promise is rejected the assertion fails.
    */
-  // eslint-disable-next-line no-use-before-define
   resolves: JestExpectType,
 };
 
@@ -1098,10 +1096,8 @@ type JestPrettyFormatColors = {
 };
 
 type JestPrettyFormatIndent = string => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatRefs = Array<any>;
 type JestPrettyFormatPrint = any => string;
-// eslint-disable-next-line no-unused-vars
 type JestPrettyFormatStringOrNull = string | null;
 
 type JestPrettyFormatOptions = {
@@ -1112,7 +1108,6 @@ type JestPrettyFormatOptions = {
   indent: number,
   maxDepth: number,
   min: boolean,
-  // eslint-disable-next-line no-use-before-define
   plugins: JestPrettyFormatPlugins,
   printFunctionName: boolean,
   spacing: string,

packages/react-devtools-extensions/flow-typed/npm/react-test-renderer_v16.x.x.js

@@ -52,7 +52,6 @@ type TestRendererOptions = {
 };
 
 declare module 'react-test-renderer' {
-  // eslint-disable-next-line no-inner-declarations
   declare export type ReactTestRenderer = {
     toJSON(): null | ReactTestRendererJSON,
     toTree(): null | ReactTestRendererTree,

packages/react-devtools-shared/src/__tests__/inspectedElement-test.js

@@ -664,7 +664,6 @@ describe('InspectedElement', () => {
           anonymous_fn={instance.anonymousFunction}
           array_buffer={arrayBuffer}
           array_of_arrays={arrayOfArrays}
-          // eslint-disable-next-line no-undef
           big_int={BigInt(123)}
           bound_fn={exampleFunction.bind(this)}
           data_view={dataView}
@@ -1874,7 +1873,7 @@ describe('InspectedElement', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     await utils.actAsync(() =>
       render(

packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js

@@ -182,7 +182,6 @@ describe('InspectedElementContext', () => {
           anonymous_fn={instance.anonymousFunction}
           array_buffer={arrayBuffer}
           array_of_arrays={arrayOfArrays}
-          // eslint-disable-next-line no-undef
           big_int={BigInt(123)}
           bound_fn={exampleFunction.bind(this)}
           data_view={dataView}
@@ -868,7 +867,7 @@ describe('InspectedElementContext', () => {
         xyz: 1,
       },
     });
-    const bigInt = BigInt(123); // eslint-disable-line no-undef
+    const bigInt = BigInt(123);
 
     act(() =>
       ReactDOM.render(

packages/react-devtools-shared/src/backend/DevToolsConsolePatching.js

@@ -30,7 +30,6 @@ disabledLog.__reactDisabledLog = true;
 
 export function disableLogs(): void {
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     prevLog = console.log;
     prevInfo = console.info;
     prevWarn = console.warn;
@@ -63,7 +62,6 @@ export function disableLogs(): void {
 export function reenableLogs(): void {
   disabledDepth--;
   if (disabledDepth === 0) {
-    /* eslint-disable react-internal/no-production-logging */
     const props = {
       configurable: true,
       enumerable: true,

packages/react-devtools-shared/src/backend/renderer.js

@@ -1545,7 +1545,6 @@ export function attach(
     return changedKeys;
   }
 
-  // eslint-disable-next-line no-unused-vars
   function didFiberRender(prevFiber: Fiber, nextFiber: Fiber): boolean {
     switch (nextFiber.tag) {
       case ClassComponent:

packages/react-devtools-shell/src/app/InspectableElements/UnserializableProps.js

@@ -31,7 +31,7 @@ const immutable = Immutable.fromJS({
     xyz: 1,
   },
 });
-const bigInt = BigInt(123); // eslint-disable-line no-undef
+const bigInt = BigInt(123);
 
 class Foo {
   flag = false;