Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextInput] Added support for textAlign to TextInput #772

Closed
wants to merge 2 commits into from
Closed

[TextInput] Added support for textAlign to TextInput #772

wants to merge 2 commits into from

Conversation

darylrowland
Copy link
Contributor

Added remapping of style textAlign property to textAlignment (which is the name of the same property on text input components)

Added support for textAlign to TextInput
7300894 
Added remapping of style textAlign property to textAlignment (which is the name of the same property on text input components)
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2015
@darylrowland darylrowland mentioned this pull request Apr 9, 2015
Closed
Exposed textAlign in TextInput.js
7b9ba9c 
Exposed textAlign in TextInput.js. Hopefully this is all that is needed?
@darylrowland
Copy link
Contributor Author

Think I've exposed it now in RCTTextViewAttributes. Let me know if that's not correct. Thanks.

@darylrowland
Copy link
Contributor Author

Will this one be merged into the main branch soon?

@machard
Copy link
Contributor

machard commented Apr 30, 2015

+1

@ide
Copy link
Contributor

ide commented May 1, 2015

yeah. this seems simple and reasonable.

@ranyefet
Copy link

ranyefet commented May 7, 2015

+1

@rpastorelle
Copy link
Contributor

+1

I've been using this for a while by manually making the update. Wondering when this will get merged into the main branch as well...

@alinz
Copy link

alinz commented May 26, 2015

+1

just got into this problem. I hope this merge goes through. I really need it. Thanks @darylrowland

@brentvatne brentvatne changed the title Added support for textAlign to TextInput [TextInput] Added support for textAlign to TextInput May 30, 2015
@brentvatne
Copy link
Collaborator

Looks good to me

@brentvatne
Copy link
Collaborator

Scratch the above comment - @darylrowland could you also add support for this prop to RCTTextView? And ideally also include an example in UIExplorer so we can pull it down and see.

@sahrens
Copy link
Contributor

sahrens commented Jun 11, 2015

reassigning to nick (that's how we track who the internal owner is) but this still needs revision from @darylrowland based on @brentvatne's comments.

@stirman
Copy link

stirman commented Jun 14, 2015

:) Been waiting on this one!

@bobspace
Copy link

@facebook-github-bot import

@frantic frantic closed this in a5db0ce Jun 25, 2015
@quantuminformation
Copy link
Contributor

How to you align a text input itself?

image

I tried putting it in a flex container with center align:
image

@ixje
Copy link

ixje commented Jul 15, 2017

@quantuminformation use alignSelf: 'center' on the TextInput

@AngelTrinidad
Copy link

Some news about this?

ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
@Salakar @cpojer
[android] document required Network Security Config for React Native …
8a7cf75 
…packager (#772)

* add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs

* add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs
@DPOSPOS
Copy link

DPOSPOS commented Jul 3, 2021

textAlign={'center'}

@ebarahona ebarahona mentioned this pull request May 10, 2022
Open
@enterstudio enterstudio mentioned this pull request May 10, 2022
Open
@admmasters admmasters mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@kskobylko-carbon kskobylko-carbon mentioned this pull request May 11, 2022
Open
@joseroubert08 joseroubert08 mentioned this pull request May 11, 2022
Open
@harunpehlivan harunpehlivan mentioned this pull request May 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.