publish index.js.flow instead of index.flow.js
#52179
Conversation
|
Hi @buschco! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@robhogan here is my PR |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
Shared with Meta
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @buschco in fbbd20d When will my fix make it into a release? | How to file a pick request? |
Summary: I think in 50667ec the file name was mixed up. Instead of `index.flow.js` it should be `index.js.flow` (see https://github.com/facebook/react-native/blob/main/packages/react-native/index.js.flow) Should fix #51885 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. [General][Added] Publish top-level Flow types for `react-native` For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #52179 Test Plan: Steps to reproduce 1. Setup a react-native project with flow (or clone https://github.com/buschco/react-native-flow + `cd ReproducerApp && npm i`) 2. `import {Alert} from 'react-native'` -> `Alert` has type `any` 3. add `index.js.flow` File (https://github.com/facebook/react-native/blob/v0.79.3/packages/react-native/index.js.flow) to `node_modules/react-native/index.js.flow` -> `Alert` no longer `any` Reviewed By: christophpurrer Differential Revision: D77052871 Pulled By: robhogan fbshipit-source-id: 32b0052a9d96486aff66a1f6e4577ff62cbcd97e
|
This pull request was successfully merged by @buschco in b2cc82b When will my fix make it into a release? | How to file a pick request? |
|
Is there a way we can test this? 50667ec didn't fix the issue and we won't really know if this break again without some kind of test coverage |
Summary: I think in 50667ec the file name was mixed up. Instead of `index.flow.js` it should be `index.js.flow` (see https://github.com/facebook/react-native/blob/main/packages/react-native/index.js.flow) Should fix #51885 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. [General][Added] Publish top-level Flow types for `react-native` For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #52179 Test Plan: Steps to reproduce 1. Setup a react-native project with flow (or clone https://github.com/buschco/react-native-flow + `cd ReproducerApp && npm i`) 2. `import {Alert} from 'react-native'` -> `Alert` has type `any` 3. add `index.js.flow` File (https://github.com/facebook/react-native/blob/v0.79.3/packages/react-native/index.js.flow) to `node_modules/react-native/index.js.flow` -> `Alert` no longer `any` Reviewed By: christophpurrer Differential Revision: D77052871 Pulled By: robhogan fbshipit-source-id: 32b0052a9d96486aff66a1f6e4577ff62cbcd97e
|
This pull request was successfully merged by @buschco in bf07da1 When will my fix make it into a release? | How to file a pick request? |
4 participants
Summary:
I think in 50667ec the file name was mixed up. Instead of
index.flow.jsit should beindex.js.flow(see https://github.com/facebook/react-native/blob/main/packages/react-native/index.js.flow)Should fix #51885
Changelog:
Test Plan:
Steps to reproduce
cd ReproducerApp && npm i)import {Alert} from 'react-native'->Alerthas typeanyindex.js.flowFile (https://github.com/facebook/react-native/blob/v0.79.3/packages/react-native/index.js.flow) tonode_modules/react-native/index.js.flow->Alertno longerany