Dont call npm before node is available

[hkjorgensen]

This fixes an error introduced in 0.18.0-rc

node and npm isn't available if the developer is using nvm or nodeenv. XCode throws an error because of the call to npm. Simple move the line to after node and npm has been setup.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @lamberta, @frantic and @ide to be potential reviewers.

[skevy]

Good catch!

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/932279090153788/int_phab to review.

[mkonicek]

Cherry-picking the commit to 0.18.0-rc and creating a new project breaks the Xcode build for me with:

node_modules/react-native/local-cli/cli.js:73
  const setupEnvScript = /^win/.test(process.platform)
  ^^^^^
SyntaxError: Use of const in strict mode.

Stack trace: http://pastebin.com/DSFirYm1

npm and node version (I am using nvm):

$ npm -v
2.7.1
$ node --version
v4.2.1
$ nvm --version
0.26.1
$ which node
/Users/mkonicek/.nvm/versions/node/v4.2.1/bin/node

Any ideas?

[mkonicek]

cc @davidaurelio, @martinbigio for ideas why this happens.

[ide]

Is the cherry pick a problem or is master broken as well? If cherry picking is the issue how about we let this go out in a few weeks with 0.19?

[hkjorgensen]

@mkonicek I think my fix is unrelated to the error you're getting.
You're node is complaining about the use of const + 'use strict'; in the same file afaik :-)

[martinbigio]

@mkonicek this file doesn't support ES6 because the babekRegisterOnly is run on it (it works on the paths enabled by that call but not on the file which calls it because that one has already been processed). I'm not sure how this was working before, but changing the const for var should fix the problem.