Fix New Arch handling of inline views when text truncated #49960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922174 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922174 |
NickGerleman
force-pushed
the
export-D70922174
branch
from
423f204 to
aa0d125
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 11, 2025
…9960) Summary: Fixes facebook#49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174
NickGerleman
force-pushed
the
export-D70922174
branch
from
aa0d125 to
5ef3ceb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922174 |
NickGerleman
force-pushed
the
export-D70922174
branch
from
5ef3ceb to
6d2572a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 11, 2025
…9960) Summary: Fixes facebook#49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 11, 2025
…9960) Summary: Fixes facebook#49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174
NickGerleman
force-pushed
the
export-D70922174
branch
from
6d2572a to
fa9da03
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922174 |
…9960) Summary: Pull Request resolved: facebook#49960 Fixes facebook#49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922174 |
NickGerleman
force-pushed
the
export-D70922174
branch
from
fa9da03 to
14baa91
Compare
Contributor
|
This pull request has been merged in 99f9626. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 99f9626 When will my fix make it into a release? | How to file a pick request? |
joemun
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 2, 2025
…9960) Summary: Pull Request resolved: facebook#49960 Fixes facebook#49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174 fbshipit-source-id: 8c1f4aadbf53ff64ce55b44d6c7953d9b2e40bc5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #49106
RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform.
line-clamp: https://jsfiddle.net/7xgdke1b/text-overflow: https://jsfiddle.net/7xgdke1b/2/Fabric renderer does not, funnily enough, having an
isClippedfield onTextMeasurement::Attachmentthat is never used.This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with
DisplayType::Noneso that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-addingnumberOfLines.Changelog:
[General][Fixed] - Fix New Arch handling of inline views when text truncated
Reviewed By: mdvacca
Differential Revision: D70922174