ReactViewGroup - utilize onViewAdded/Removed #47890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66320586 |
tdn120
pushed a commit
to tdn120/react-native
that referenced
this pull request
Nov 22, 2024
Summary: The fix in [facebook#40859](facebook#40859) overrode every possible add or remove to ensure completeness, but all paths should also call onViewAdded/onViewRemoved via: - `addView`/`addViewInLayout` -> [addViewInner](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5310) - `removeView`/`removeViewInLayout` -> [removeViewInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5606) - `removeViews`/`removeViewsInLayout` -> [removeViewsInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5714) Changelog: [Android][Changed] Consolidated ReactViewGroup add/remove overrides Reviewed By: javache Differential Revision: D66320586
tdn120
force-pushed
the
export-D66320586
branch
from
f2e006f to
f3ba69c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66320586 |
added 3 commits
November 22, 2024 07:51
Summary: Small changes that can be done in Java and make a Kotlin conversion more seamless. Changelog: [Internal] Reviewed By: javache Differential Revision: D66033963
Summary: Make it clearer what we're checking, and provide a single point of code where we could potentially improve the logic. Changelog: [Internal] Reviewed By: rshest Differential Revision: D66302526
Summary: The fix in [facebook#40859](facebook#40859) overrode every possible add or remove to ensure completeness, but all paths should also call onViewAdded/onViewRemoved via: - `addView`/`addViewInLayout` -> [addViewInner](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5310) - `removeView`/`removeViewInLayout` -> [removeViewInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5606) - `removeViews`/`removeViewsInLayout` -> [removeViewsInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5714) Changelog: [Android][Changed] Consolidated ReactViewGroup add/remove overrides Reviewed By: javache Differential Revision: D66320586
tdn120
force-pushed
the
export-D66320586
branch
from
f3ba69c to
4ad03ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66320586 |
|
This pull request has been merged in 0b22b95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The fix in #40859 overrode every possible add or remove to ensure completeness, but all paths should also call onViewAdded/onViewRemoved via:
addView/addViewInLayout-> addViewInnerremoveView/removeViewInLayout-> removeViewInternalremoveViews/removeViewsInLayout-> removeViewsInternalChangelog: [Android][Changed] Consolidated ReactViewGroup add/remove overrides
Differential Revision: D66320586